typing: Remove organization_events_meta from soft list (#104102)

Author: armenzg

pyproject.toml

@@ -312,7 +312,6 @@ ignore_missing_imports = true
 # - python3 -m tools.mypy_helpers.find_easiest_modules
 [[tool.mypy.overrides]]
 module = [
-    "sentry.api.endpoints.organization_events_meta",
     "sentry.api.endpoints.organization_releases",
     "sentry.api.paginator",
     "sentry.db.postgres.base",

src/sentry/api/endpoints/organization_events_meta.py

@@ -147,13 +147,17 @@ def get(self, request: Request, organization: Organization) -> Response:
         with handle_query_errors():
             with sentry_sdk.start_span(op="discover.endpoint", name="filter_creation"):
                 projects = self.get_projects(request, organization)
+                # Filter out None values from environments
+                environments = [e for e in snuba_params.environments if e is not None]
                 query_kwargs = build_query_params_from_request(
-                    request, organization, projects, snuba_params.environments
+                    request, organization, projects, environments
                 )
                 query_kwargs["limit"] = 5
                 try:
                     # Need to escape quotes in case some "joker" has a transaction with quotes
-                    transaction_name = UNESCAPED_QUOTE_RE.sub('\\"', lookup_keys["transaction"])
+                    transaction_name = UNESCAPED_QUOTE_RE.sub(
+                        '\\"', lookup_keys["transaction"] or ""
+                    )
                     parsed_terms = parse_search_query(f'transaction:"{transaction_name}"')
                 except ParseError:
                     return Response({"detail": "Invalid transaction search"}, status=400)
@@ -198,11 +202,13 @@ def get(self, request: Request, organization: Organization) -> Response:
 
         with handle_query_errors():
             if use_eap:
-                result = get_eap_span_samples(request, snuba_params, orderby)
+                result: EAPResponse | EventsResponse = get_eap_span_samples(
+                    request, snuba_params, orderby
+                )
                 dataset = Spans
             else:
                 result = get_span_samples(request, snuba_params, orderby)
-                dataset = spans_indexed
+                dataset = spans_indexed  # type: ignore[assignment]
 
         return Response(
             self.handle_results_with_meta(
@@ -282,9 +288,10 @@ def get_span_samples(
             span_ids.append(top)
 
     if len(span_ids) > 0:
-        query = f"span_id:[{','.join(span_ids)}] {request.query_params.get('query')}"
+        user_query = request.query_params.get("query") or ""
+        query = f"span_id:[{','.join(span_ids)}] {user_query}"
     else:
-        query = request.query_params.get("query")
+        query = request.query_params.get("query") or ""
 
     return spans_indexed.query(
         selected_columns=selected_columns,
@@ -320,7 +327,7 @@ def get_eap_span_samples(
         "trace",
     ]
 
-    query_string = request.query_params.get("query")
+    query_string = request.query_params.get("query") or ""
     bounds_query_string = f"{column}:>{lower_bound}ms {column}:<{upper_bound}ms {query_string}"
 
     rpc_res = Spans.run_table_query(