tests

Author: trevor-e

tests/sentry/integrations/github/tasks/test_link_all_repos.py

@@ -81,7 +81,12 @@ def test_link_all_repos(self, mock_record: MagicMock, _: MagicMock) -> None:
         assert repos[0].name == "getsentry/sentry"
         assert repos[1].name == "getsentry/snuba"
 
-        assert_slo_metric(mock_record, EventLifecycleOutcome.SUCCESS)
+        assert len(mock_record.mock_calls) == 4
+        start1, start2, end2, end1 = mock_record.mock_calls
+        assert start1.args[0] == EventLifecycleOutcome.STARTED
+        assert start2.args[0] == EventLifecycleOutcome.STARTED
+        assert end2.args[0] == EventLifecycleOutcome.SUCCESS
+        assert end1.args[0] == EventLifecycleOutcome.SUCCESS
 
     @responses.activate
     @patch("sentry.integrations.utils.metrics.EventLifecycle.record_event")
@@ -121,7 +126,12 @@ def test_link_all_repos_api_response_keyerror(
 
         assert repos[0].name == "getsentry/snuba"
 
-        assert_slo_metric(mock_record, EventLifecycleOutcome.HALTED)
+        assert len(mock_record.mock_calls) == 4
+        start1, start2, end2, end1 = mock_record.mock_calls
+        assert start1.args[0] == EventLifecycleOutcome.STARTED
+        assert start2.args[0] == EventLifecycleOutcome.STARTED
+        assert end2.args[0] == EventLifecycleOutcome.SUCCESS
+        assert end1.args[0] == EventLifecycleOutcome.HALTED
         assert_halt_metric(
             mock_record, LinkAllReposHaltReason.REPOSITORY_NOT_CREATED.value
         )  # should be halt because it didn't complete successfully
@@ -155,7 +165,12 @@ def test_link_all_repos_api_response_keyerror_single_repo(
             repos = Repository.objects.all()
         assert len(repos) == 0
 
-        assert_slo_metric(mock_record, EventLifecycleOutcome.HALTED)
+        assert len(mock_record.mock_calls) == 4
+        start1, start2, end2, end1 = mock_record.mock_calls
+        assert start1.args[0] == EventLifecycleOutcome.STARTED
+        assert start2.args[0] == EventLifecycleOutcome.STARTED
+        assert end2.args[0] == EventLifecycleOutcome.SUCCESS
+        assert end1.args[0] == EventLifecycleOutcome.HALTED
         assert_halt_metric(mock_record, LinkAllReposHaltReason.REPOSITORY_NOT_CREATED.value)
 
     @patch("sentry.integrations.utils.metrics.EventLifecycle.record_event")
@@ -198,7 +213,12 @@ def test_link_all_repos_api_error(self, mock_record: MagicMock, _: MagicMock) ->
                 organization_id=self.organization.id,
             )
 
-        assert_slo_metric(mock_record, EventLifecycleOutcome.FAILURE)
+        assert len(mock_record.mock_calls) == 4
+        start1, start2, end2, end1 = mock_record.mock_calls
+        assert start1.args[0] == EventLifecycleOutcome.STARTED
+        assert start2.args[0] == EventLifecycleOutcome.STARTED
+        assert end2.args[0] == EventLifecycleOutcome.FAILURE
+        assert end1.args[0] == EventLifecycleOutcome.FAILURE
 
     @patch("sentry.integrations.utils.metrics.EventLifecycle.record_event")
     @responses.activate
@@ -221,7 +241,12 @@ def test_link_all_repos_api_error_rate_limited(
             organization_id=self.organization.id,
         )
 
-        assert_slo_metric(mock_record, EventLifecycleOutcome.HALTED)
+        assert len(mock_record.mock_calls) == 4
+        start1, start2, end2, end1 = mock_record.mock_calls
+        assert start1.args[0] == EventLifecycleOutcome.STARTED
+        assert start2.args[0] == EventLifecycleOutcome.STARTED
+        assert end2.args[0] == EventLifecycleOutcome.FAILURE
+        assert end1.args[0] == EventLifecycleOutcome.HALTED
         assert_halt_metric(mock_record, LinkAllReposHaltReason.RATE_LIMITED.value)
 
     @patch("sentry.integrations.utils.metrics.EventLifecycle.record_event")
@@ -240,7 +265,12 @@ def test_link_all_repos_repo_creation_error(
             organization_id=self.organization.id,
         )
 
-        assert_slo_metric(mock_record, EventLifecycleOutcome.HALTED)
+        assert len(mock_record.mock_calls) == 4
+        start1, start2, end2, end1 = mock_record.mock_calls
+        assert start1.args[0] == EventLifecycleOutcome.STARTED
+        assert start2.args[0] == EventLifecycleOutcome.STARTED
+        assert end2.args[0] == EventLifecycleOutcome.SUCCESS
+        assert end1.args[0] == EventLifecycleOutcome.HALTED
         assert_halt_metric(mock_record, LinkAllReposHaltReason.REPOSITORY_NOT_CREATED.value)
 
     @patch("sentry.integrations.utils.metrics.EventLifecycle.record_event")
@@ -262,4 +292,9 @@ def test_link_all_repos_repo_creation_exception(
                 organization_id=self.organization.id,
             )
 
-        assert_slo_metric(mock_record, EventLifecycleOutcome.FAILURE)
+        assert len(mock_record.mock_calls) == 4
+        start1, start2, end2, end1 = mock_record.mock_calls
+        assert start1.args[0] == EventLifecycleOutcome.STARTED
+        assert start2.args[0] == EventLifecycleOutcome.STARTED
+        assert end2.args[0] == EventLifecycleOutcome.SUCCESS
+        assert end1.args[0] == EventLifecycleOutcome.FAILURE