fix(detectors): Update span evidence section for MN+1 Detector (#97523)

this pr fixes an issue where for MN+1 detection we only showed 1
repeating span, when there could be a pattern of multiple spans. also
removes the pattern span id section, which is not particularly useful

Author: roggenkemper

src/sentry/performance_issues/detectors/experiments/mn_plus_one_db_span_detector.py

@@ -254,11 +254,12 @@ def _maybe_performance_problem(self) -> PerformanceProblem | None:
                 "offender_span_ids": offender_span_ids,
                 "transaction_name": self.event.get("transaction", ""),
                 "parent_span": get_span_evidence_value(common_parent_span),
-                "repeating_spans": get_span_evidence_value(db_span),
-                "repeating_spans_compact": get_span_evidence_value(db_span, include_op=False),
+                "repeating_spans": [get_span_evidence_value(span) for span in self.pattern],
+                "repeating_spans_compact": [
+                    get_span_evidence_value(span, include_op=False) for span in self.pattern
+                ],
                 "number_repeating_spans": str(len(offender_spans)),
                 "pattern_size": len(self.pattern),
-                "pattern_span_ids": [span["span_id"] for span in self.pattern],
                 "num_pattern_repetitions": times_occurred,
             },
             evidence_display=[

tests/sentry/performance_issues/experiments/test_m_n_plus_one_db_detector.py

@@ -178,11 +178,26 @@ def test_detects_prisma_client_m_n_plus_one(self) -> None:
             "op": "db",
             "parent_span": "default - render route (app) /products",
             "parent_span_ids": ["1bb013326ff579a4"],
-            "repeating_spans": f'db - {first_db_span["description"]}',
-            "repeating_spans_compact": first_db_span["description"],
+            "repeating_spans": [
+                "default - prisma:engine:serialize",
+                "default - prisma:client:operation",
+                "default - prisma:client:serialize",
+                "http.client - POST https://accelerate.prisma-data.net/5.21.1/298c9a80d6e969bf5a29b56584687fa4e2ad329bc97098090a7b081d6222e653/graphql",
+                "default - prisma:engine",
+                "default - prisma:engine:connection",
+                'db - SELECT "public"."reviews"."id", "public"."reviews"."productid", "public"."reviews"."rating", "public"."reviews"."customerid", "public"."reviews"."description", "public"."reviews"."created" FROM "public"."reviews" WHERE "public"."reviews"."id" = $1 OFFSET $2 /* traceparent=\'00-ee80032db36ee0e24a2f3c2f71fd5f11-aa3a15d285888d70-01\' */',
+            ],
+            "repeating_spans_compact": [
+                "prisma:engine:serialize",
+                "prisma:client:operation",
+                "prisma:client:serialize",
+                "POST https://accelerate.prisma-data.net/5.21.1/298c9a80d6e969bf5a29b56584687fa4e2ad329bc97098090a7b081d6222e653/graphql",
+                "prisma:engine",
+                "prisma:engine:connection",
+                'SELECT "public"."reviews"."id", "public"."reviews"."productid", "public"."reviews"."rating", "public"."reviews"."customerid", "public"."reviews"."description", "public"."reviews"."created" FROM "public"."reviews" WHERE "public"."reviews"."id" = $1 OFFSET $2 /* traceparent=\'00-ee80032db36ee0e24a2f3c2f71fd5f11-aa3a15d285888d70-01\' */',
+            ],
             "transaction_name": "GET /products",
             "pattern_size": num_spans_in_pattern,
-            "pattern_span_ids": pattern_span_ids,
             "num_pattern_repetitions": num_pattern_repetitions,
         }