Skip to content

Commit 4613dc6

Browse files
authored
fix(seer onboarding): remove on_command_phrase CR trigger from settings forms (#105696)
relates to ENG-6194 depends on codecov/overwatch#622 Since we are not charging by review, let's make sure the `on_command_phrase` trigger is always turned on and immutable in `RepositorySettings`. We remove it from the form options and update the help text to specify the command phrase. Before <img width="1398" height="207" alt="Screenshot 2026-01-06 at 12 03 10 PM" src="https://github.com/user-attachments/assets/8fc2a159-9bb3-4b20-9df3-1f4a5d046cbf" /> <img width="1396" height="204" alt="Screenshot 2026-01-06 at 1 33 22 PM" src="https://github.com/user-attachments/assets/0236e0a4-d676-45dd-a55f-cdc199d5ad53" /> After <img width="1396" height="218" alt="Screenshot 2026-01-06 at 1 25 07 PM" src="https://github.com/user-attachments/assets/b793d527-4f59-465a-a8a0-f001329bde00" /> <img width="1396" height="218" alt="Screenshot 2026-01-06 at 1 33 04 PM" src="https://github.com/user-attachments/assets/874fe826-fd99-4846-81ce-6a522232cedc" />
1 parent 0e331a7 commit 4613dc6

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

static/gsApp/views/seerAutomation/components/repoDetails/repoDetailsForm.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import Form from 'sentry/components/forms/form';
22
import JsonForm from 'sentry/components/forms/jsonForm';
3-
import {t} from 'sentry/locale';
3+
import {t, tct} from 'sentry/locale';
44
import {
55
DEFAULT_CODE_REVIEW_TRIGGERS,
66
type RepositoryWithSettings,
@@ -57,13 +57,13 @@ export default function RepoDetailsForm({organization, repoWithSettings}: Props)
5757
{
5858
name: 'codeReviewTriggers',
5959
label: t('Code Review Triggers'),
60-
help: t(
61-
'Reviews can run on demand, whenever a PR is opened, or after each commit is pushed to a PR.'
60+
help: tct(
61+
'Reviews can always run on demand by calling [code:@sentry review], whenever a PR is opened, or after each commit is pushed to a PR.',
62+
{code: <code />}
6263
),
6364
type: 'choice',
6465
multiple: true,
6566
choices: [
66-
['on_command_phrase', t('On Command Phrase')],
6767
['on_ready_for_review', t('On Ready for Review')],
6868
['on_new_commit', t('On New Commit')],
6969
],

static/gsApp/views/seerAutomation/settings.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -98,13 +98,13 @@ export default function SeerAutomationSettings() {
9898
{
9999
name: 'defaultCodeReviewTriggers',
100100
label: t('Code Review Triggers'),
101-
help: t(
102-
'Reviews can run on demand, whenever a PR is opened, or after each commit is pushed to a PR.'
101+
help: tct(
102+
'Reviews can always run on demand by calling [code:@sentry review], whenever a PR is opened, or after each commit is pushed to a PR.',
103+
{code: <code />}
103104
),
104105
type: 'choice',
105106
multiple: true,
106107
choices: [
107-
['on_command_phrase', t('On Command Phrase')],
108108
['on_ready_for_review', t('On Ready for Review')],
109109
['on_new_commit', t('On New Commit')],
110110
],

0 commit comments

Comments
 (0)