ref(access-logs): revert logging access logs (#97643)

Reverts #97183 (also see
getsentry/sentry-options-automator#4886) — even
with the additional information, I haven't been able to narrow down the
issue and am planning to move on
(https://linear.app/getsentry/issue/ID-805/fix-missing-organization-id-in-api-access-logs
for more investigation), so this cleans the leftover logging up before I
stop working on it.

Author: cvxluo

src/sentry/middleware/access_log.py

@@ -5,15 +5,13 @@
 from collections.abc import Callable
 from dataclasses import dataclass
 
-import sentry_sdk
 from django.conf import settings
 from django.utils.encoding import force_str
 from rest_framework.authentication import get_authorization_header
 from rest_framework.request import Request
 from rest_framework.response import Response
 
 from sentry.auth.services.auth import AuthenticatedToken
-from sentry.options.rollout import in_random_rollout
 from sentry.types.ratelimit import RateLimitMeta, SnubaRateLimitMeta
 from sentry.utils import metrics
 
@@ -104,6 +102,8 @@ def _create_api_access_log(
         request_user = getattr(request, "user", None)
         user_id = getattr(request_user, "id", None)
         is_app = getattr(request_user, "is_sentry_app", None)
+        # TODO: `org_id` is often None even if we should have it
+        # Likely `organization` is not being correctly set in the base endpoints on _request
         org_id = getattr(getattr(request, "organization", None), "id", None)
         entity_id = getattr(request_auth, "entity_id", None)
         status_code = getattr(response, "status_code", 500)
@@ -131,9 +131,6 @@ def _create_api_access_log(
         api_access_logger.info("api.access", extra=log_metrics)
         metrics.incr("middleware.access_log.created")
 
-        if in_random_rollout("issues.log-access-logs") and not org_id:
-            sentry_sdk.capture_message("Acesss log created without org_id", level="debug")
-
     except Exception:
         api_access_logger.exception("api.access: Error capturing API access logs")
 

src/sentry/options/defaults.py

@@ -3448,8 +3448,6 @@
     flags=FLAG_AUTOMATOR_MODIFIABLE,
 )
 
-register("issues.log-access-logs", type=Float, default=0.0, flags=FLAG_AUTOMATOR_MODIFIABLE)
-
 # Use "first-seen" group instead of "most-seen" group when merging
 register(
     "issues.merging.first-seen",