chore(eap): Remove option to switch entities for EAP subscriptions (#96607)

We do not need this option anymore.

Author: phacops

src/sentry/incidents/logic.py

@@ -16,7 +16,7 @@
 from django.utils import timezone as django_timezone
 from snuba_sdk import Column, Condition, Limit, Op
 
-from sentry import analytics, audit_log, features, options, quotas
+from sentry import analytics, audit_log, features, quotas
 from sentry.api.exceptions import ResourceDoesNotExist
 from sentry.auth.access import SystemAccess
 from sentry.constants import CRASH_RATE_ALERT_AGGREGATE_ALIAS, ObjectStatus
@@ -165,7 +165,9 @@ def create_incident(
             # `bulk_create` doesn't send `post_save` signals, so we manually fire them here.
             for incident_project in incident_projects:
                 post_save.send_robust(
-                    sender=type(incident_project), instance=incident_project, created=True
+                    sender=type(incident_project),
+                    instance=incident_project,
+                    created=True,
                 )
 
         create_incident_activity(
@@ -205,7 +207,10 @@ def update_incident_status(
         )
 
         prev_status = incident.status
-        kwargs: dict[str, Any] = {"status": status.value, "status_method": status_method.value}
+        kwargs: dict[str, Any] = {
+            "status": status.value,
+            "status_method": status_method.value,
+        }
         if status == IncidentStatus.CLOSED:
             kwargs["date_closed"] = date_closed if date_closed else django_timezone.now()
         elif status == IncidentStatus.OPEN:
@@ -414,11 +419,7 @@ def get_metric_issue_aggregates(
             )
 
         except Exception:
-            entity_key = (
-                EntityKey.EAPItems
-                if options.get("alerts.spans.use-eap-items")
-                else EntityKey.EAPItemsSpan
-            )
+            entity_key = EntityKey.EAPItems
             metrics.incr(
                 "incidents.get_incident_aggregates.snql.query.error",
                 tags={
@@ -1051,7 +1052,9 @@ def update_detector(detector: Detector, enabled: bool) -> None:
 
 
 def delete_alert_rule(
-    alert_rule: AlertRule, user: User | RpcUser | None = None, ip_address: str | None = None
+    alert_rule: AlertRule,
+    user: User | RpcUser | None = None,
+    ip_address: str | None = None,
 ) -> None:
     """
     Marks an alert rule as deleted and fires off a task to actually delete it.
@@ -1223,7 +1226,9 @@ def _schedule_trigger_action(
     )
 
 
-def _sort_by_priority_list(triggers: Collection[AlertRuleTrigger]) -> list[AlertRuleTrigger]:
+def _sort_by_priority_list(
+    triggers: Collection[AlertRuleTrigger],
+) -> list[AlertRuleTrigger]:
     priority_dict = {
         WARNING_TRIGGER_LABEL: 0,
         CRITICAL_TRIGGER_LABEL: 1,
@@ -1234,7 +1239,9 @@ def _sort_by_priority_list(triggers: Collection[AlertRuleTrigger]) -> list[Alert
     )
 
 
-def _prioritize_actions(triggers: Collection[AlertRuleTrigger]) -> list[AlertRuleTriggerAction]:
+def _prioritize_actions(
+    triggers: Collection[AlertRuleTrigger],
+) -> list[AlertRuleTriggerAction]:
     """
     Function that given an input array of AlertRuleTriggers, prioritizes those triggers
     based on their label, and then re-orders actions based on that ordering
@@ -1364,7 +1371,10 @@ def create_alert_rule_trigger_action(
         target = AlertTarget(target_identifier, target_display)
 
     # store priority in the json sentry_app_config
-    if priority is not None and type in [ActionService.PAGERDUTY, ActionService.OPSGENIE]:
+    if priority is not None and type in [
+        ActionService.PAGERDUTY,
+        ActionService.OPSGENIE,
+    ]:
         if sentry_app_config:
             sentry_app_config.update({"priority": priority})
         else:
@@ -1455,7 +1465,10 @@ def update_alert_rule_trigger_action(
         updated_fields["target_identifier"] = target.identifier
 
     # store priority in the json sentry_app_config
-    if priority is not None and type in [ActionService.PAGERDUTY, ActionService.OPSGENIE]:
+    if priority is not None and type in [
+        ActionService.PAGERDUTY,
+        ActionService.OPSGENIE,
+    ]:
         if updated_fields.get("sentry_app_config"):
             updated_fields["sentry_app_config"].update({"priority": priority})
         else:
@@ -1483,7 +1496,11 @@ def get_target_identifier_display_for_integration(
 ) -> AlertTarget:
     if action_type == AlertRuleTriggerAction.Type.SLACK.value:
         return _get_target_identifier_display_for_slack(
-            target_value, integration_id, use_async_lookup, input_channel_id, integrations
+            target_value,
+            integration_id,
+            use_async_lookup,
+            input_channel_id,
+            integrations,
         )
 
     if target_value is None:
@@ -1705,11 +1722,15 @@ def delete_alert_rule_trigger_action(trigger_action: AlertRuleTriggerAction) ->
     trigger_action.update(status=ObjectStatus.PENDING_DELETION)
 
 
-def get_actions_for_trigger(trigger: AlertRuleTrigger) -> QuerySet[AlertRuleTriggerAction]:
+def get_actions_for_trigger(
+    trigger: AlertRuleTrigger,
+) -> QuerySet[AlertRuleTriggerAction]:
     return AlertRuleTriggerAction.objects.filter(alert_rule_trigger=trigger)
 
 
-def get_available_action_integrations_for_org(organization: Organization) -> list[RpcIntegration]:
+def get_available_action_integrations_for_org(
+    organization: Organization,
+) -> list[RpcIntegration]:
     """
     Returns a list of integrations that the organization has installed. Integrations are
     filtered by the list of registered providers.
@@ -1878,7 +1899,10 @@ def check_aggregate_column_support(
 
 
 def translate_aggregate_field(
-    aggregate: str, reverse: bool = False, allow_mri: bool = False, allow_eap: bool = False
+    aggregate: str,
+    reverse: bool = False,
+    allow_mri: bool = False,
+    allow_eap: bool = False,
 ) -> str:
     column = get_column_from_aggregate(aggregate, allow_mri, allow_eap)
     if not reverse: