chore(sub v3): Remove dead code (#105677)

Kills old subscription settings code.

Closes BIL-1883

Author: isabellaenriquez

static/gsAdmin/components/customers/pendingChanges.tsx

@@ -21,7 +21,7 @@ import {
   isOnDemandBudgetsEqual,
   parseOnDemandBudgets,
   parseOnDemandBudgetsFromSubscription,
-} from 'getsentry/views/onDemandBudgets/utils';
+} from 'getsentry/views/spendLimits/utils';
 
 function getStringForPrice(
   price: number | null | undefined,

static/gsApp/actionCreators/modal.tsx

@@ -1,26 +1,28 @@
 import type {ComponentType} from 'react';
+import type {Theme} from '@emotion/react';
+import {css} from '@emotion/react';
 import styled from '@emotion/styled';
-import type {Location} from 'history';
 
+import {addErrorMessage} from 'sentry/actionCreators/indicator';
 import {openModal} from 'sentry/actionCreators/modal';
 import {promptsUpdate} from 'sentry/actionCreators/prompts';
 import {Client} from 'sentry/api';
 import {openConfirmModal} from 'sentry/components/confirm';
-import {t} from 'sentry/locale';
+import {t, tct} from 'sentry/locale';
 import type {Organization} from 'sentry/types/organization';
 
 import type {PromotionModalBodyProps} from 'getsentry/components/promotionModal';
 import type {Reservations} from 'getsentry/components/upgradeNowModal/types';
 import SubscriptionStore from 'getsentry/stores/subscriptionStore';
 import type {
-  BillingDetails,
   Invoice,
   Plan,
   PreviewData,
   Promotion,
   PromotionClaimed,
   Subscription,
 } from 'getsentry/types';
+import {displayBudgetName, hasBillingAccess, supportsPayg} from 'getsentry/utils/billing';
 import type {AM2UpdateSurfaces} from 'getsentry/utils/trackGetsentryAnalytics';
 
 type UpsellModalOptions = {
@@ -118,30 +120,40 @@ export async function openPartnerPlanEndingModal(options: PartnerPlanModalProps)
   openModal(deps => <Modal {...deps} {...options} />, {modalCss, onClose});
 }
 
-type EditCreditCardOptions = {
-  onSuccess: (data: Subscription) => void;
+interface OpenOnDemandBudgetEditModalProps {
   organization: Organization;
   subscription: Subscription;
-  location?: Location;
-};
-
-export async function openEditCreditCard(options: EditCreditCardOptions) {
-  const {default: Modal} = await import('getsentry/components/creditCardEdit/modal');
-
-  openModal(deps => <Modal {...deps} {...options} />);
+  theme?: Theme;
 }
 
-type EditBillingDetailsOptions = {
-  organization: Organization;
-  refetch: () => void;
-  initialData?: BillingDetails;
-};
-
-export async function openEditBillingDetails(options: EditBillingDetailsOptions) {
-  const {default: Modal} = await import('getsentry/components/billingDetails/modal');
-  openModal(deps => <Modal {...deps} {...options} />);
+export async function openOnDemandBudgetEditModal(
+  options: OpenOnDemandBudgetEditModalProps
+) {
+  const {default: Modal} = await import('getsentry/views/spendLimits/editModal');
+  const {theme, organization, subscription} = options;
+  const hasBillingPerms = hasBillingAccess(organization);
+  const canUsePayg = supportsPayg(subscription);
+
+  if (hasBillingPerms && canUsePayg) {
+    openModal(deps => <Modal {...deps} {...options} />, {
+      closeEvents: 'escape-key',
+      modalCss: theme ? onDemandBudgetEditModalCss(theme) : undefined,
+    });
+  } else {
+    addErrorMessage(
+      tct("You don't have permission to edit [budgetTerm] budgets.", {
+        budgetTerm: displayBudgetName(subscription.planDetails),
+      })
+    );
+  }
 }
 
+const onDemandBudgetEditModalCss = (theme: Theme) => css`
+  @media (min-width: ${theme.breakpoints.md}) {
+    width: 1000px;
+  }
+`;
+
 type OpenInvoicePaymentOptions = {
   invoice: Invoice;
   organization: Organization;

static/gsApp/components/addEventsCTA.tsx

@@ -8,6 +8,7 @@ import {t, tct} from 'sentry/locale';
 import type {Organization} from 'sentry/types/organization';
 import withApi from 'sentry/utils/withApi';
 
+import {openOnDemandBudgetEditModal} from 'getsentry/actionCreators/modal';
 import {sendAddEventsRequest, sendUpgradeRequest} from 'getsentry/actionCreators/upsell';
 import StartTrialButton from 'getsentry/components/startTrialButton';
 import type {Subscription} from 'getsentry/types';
@@ -17,7 +18,6 @@ import {
   type UsageAction,
 } from 'getsentry/utils/billing';
 import trackGetsentryAnalytics from 'getsentry/utils/trackGetsentryAnalytics';
-import {openOnDemandBudgetEditModal} from 'getsentry/views/onDemandBudgets/editOnDemandButton';
 
 /**
  * Event types for quota CTAs and notifications.

static/gsApp/components/ai/AiSetupDataConsent.tsx

@@ -21,13 +21,13 @@ import useApi from 'sentry/utils/useApi';
 import {useNavigate} from 'sentry/utils/useNavigate';
 import useOrganization from 'sentry/utils/useOrganization';
 
+import {openOnDemandBudgetEditModal} from 'getsentry/actionCreators/modal';
 import {sendAddEventsRequest} from 'getsentry/actionCreators/upsell';
 import type {EventType} from 'getsentry/components/addEventsCTA';
 import StartTrialButton from 'getsentry/components/startTrialButton';
 import useSubscription from 'getsentry/hooks/useSubscription';
 import {BillingType, OnDemandBudgetMode} from 'getsentry/types';
 import {getPotentialProductTrial, getSeerTrialCategory} from 'getsentry/utils/billing';
-import {openOnDemandBudgetEditModal} from 'getsentry/views/onDemandBudgets/editOnDemandButton';
 
 type AiSetupDataConsentProps = {
   groupId?: string;

static/gsApp/components/billingDetails/modal.tsx

@@ -6,17 +6,12 @@ import {Alert} from '@sentry/scraps/alert';
 import {Button} from 'sentry/components/core/button';
 import {Flex} from 'sentry/components/core/layout';
 import {Heading, Text} from 'sentry/components/core/text';
-import FieldGroup from 'sentry/components/forms/fieldGroup';
 import LoadingError from 'sentry/components/loadingError';
 import LoadingIndicator from 'sentry/components/loadingIndicator';
-import Panel from 'sentry/components/panels/panel';
-import PanelBody from 'sentry/components/panels/panelBody';
-import PanelHeader from 'sentry/components/panels/panelHeader';
 import QuestionTooltip from 'sentry/components/questionTooltip';
 import {t, tct} from 'sentry/locale';
 import type {Organization} from 'sentry/types/organization';
 
-import {openEditBillingDetails} from 'getsentry/actionCreators/modal';
 import BillingDetailsForm from 'getsentry/components/billingDetails/form';
 import {useBillingDetails} from 'getsentry/hooks/useBillingDetails';
 import type {Subscription} from 'getsentry/types';
@@ -26,37 +21,21 @@ import {getCountryByCode} from 'getsentry/utils/ISO3166codes';
 import {countryHasSalesTax, getTaxFieldInfo} from 'getsentry/utils/salesTax';
 import type {GetsentryEventKey} from 'getsentry/utils/trackGetsentryAnalytics';
 
-/**
- * Sets the min-height so a field displaying text will be the same height as a
- * field that has an input
- */
-function TextForField({children}: {children: React.ReactNode}) {
-  return (
-    <Flex minHeight="37px" align="center">
-      <Text as="span">{children}</Text>
-    </Flex>
-  );
-}
-
 /**
  * Panel displaying existing billing details.
  */
 function BillingDetailsPanel({
   organization,
   subscription,
-  title,
-  isNewBillingUI,
   analyticsEvent,
   shouldExpandInitially,
   maxPanelWidth,
 }: {
   organization: Organization;
   subscription: Subscription;
   analyticsEvent?: GetsentryEventKey;
-  isNewBillingUI?: boolean;
   maxPanelWidth?: string;
   shouldExpandInitially?: boolean;
-  title?: string;
 }) {
   const [isEditing, setIsEditing] = useState(false);
   const [expandInitially, setExpandInitially] = useState(shouldExpandInitially);
@@ -98,74 +77,6 @@ function BillingDetailsPanel({
         })
       : `${formatCurrency(subscription.accountBalance)}`;
 
-  if (!isNewBillingUI) {
-    return (
-      <Panel className="ref-billing-details">
-        <PanelHeader>
-          {title ?? t('Billing Details')}
-          <Button
-            priority="primary"
-            size="sm"
-            onClick={() =>
-              openEditBillingDetails({
-                organization,
-                initialData: billingDetails,
-                refetch: fetchBillingDetails,
-              })
-            }
-            disabled={!organization.access.includes('org:billing')}
-          >
-            {t('Update details')}
-          </Button>
-        </PanelHeader>
-        <PanelBody>
-          {subscription.accountBalance ? (
-            <FieldGroup id="account-balance" label="Account Balance">
-              {balance}
-            </FieldGroup>
-          ) : null}
-          <FieldGroup label={t('Billing Email')}>
-            <TextForField>{billingDetails?.billingEmail}</TextForField>
-          </FieldGroup>
-          <FieldGroup label={t('Company Name')}>
-            <TextForField>{billingDetails?.companyName}</TextForField>
-          </FieldGroup>
-          <FieldGroup label={t('Address Line 1')}>
-            <TextForField>{billingDetails?.addressLine1}</TextForField>
-          </FieldGroup>
-          <FieldGroup label={t('Address Line 2')}>
-            <TextForField>{billingDetails?.addressLine2}</TextForField>
-          </FieldGroup>
-          <FieldGroup label={t('City')}>
-            <TextForField>{billingDetails?.city}</TextForField>
-          </FieldGroup>
-          <FieldGroup label={t('State / Region')}>
-            <TextForField>{billingDetails?.region}</TextForField>
-          </FieldGroup>
-          <FieldGroup label={t('Postal Code')}>
-            <TextForField>{billingDetails?.postalCode}</TextForField>
-          </FieldGroup>
-          <FieldGroup label={t('Country')}>
-            <TextForField>
-              {getCountryByCode(billingDetails?.countryCode)?.name}
-            </TextForField>
-          </FieldGroup>
-          {countryHasSalesTax(billingDetails?.countryCode) && taxFieldInfo && (
-            <FieldGroup
-              label={taxFieldInfo.label}
-              help={tct(
-                "Your company's [taxNumberName] will appear on all receipts. You may be subject to taxes depending on country specific tax policies.",
-                {taxNumberName: <strong>{taxFieldInfo.taxNumberName}</strong>}
-              )}
-            >
-              <TextForField>{billingDetails?.taxNumber}</TextForField>
-            </FieldGroup>
-          )}
-        </PanelBody>
-      </Panel>
-    );
-  }
-
   return (
     <Flex
       justify={isEditing ? 'start' : 'between'}