feat(preprod): Add comparisonRunInfo data to response + new extra frontend models

Author: NicoHinderling

src/sentry/preprod/api/endpoints/preprod_artifact_snapshot.py

@@ -258,11 +258,19 @@ def on_results(images: list[SnapshotImageResponse]) -> dict[str, Any]:
             )
 
             result = response.dict()
-            result["org_id"] = str(organization.id)
             result["project_id"] = str(artifact.project_id)
             result["comparison_type"] = comparison_type
+
+            run_info: dict[str, Any] = {}
             if comparison_state is not None:
-                result["comparison_state"] = comparison_state
+                run_info["state"] = comparison_state
+            if comparison is not None:
+                run_info["state"] = PreprodSnapshotComparison.State(comparison.state).name.lower()
+                run_info["completed_at"] = comparison.date_updated.isoformat()
+                duration = comparison.date_updated - comparison.date_added
+                run_info["duration_ms"] = int(duration.total_seconds() * 1000)
+            if run_info:
+                result["comparison_run_info"] = run_info
 
             return result
 

src/sentry/preprod/api/models/snapshots/project_preprod_snapshot_models.py

@@ -11,6 +11,7 @@
 class SnapshotDiffSection(StrEnum):
     ADDED = "added"
     REMOVED = "removed"
+    RENAMED = "renamed"
     CHANGED = "changed"
     UNCHANGED = "unchanged"
     ERRORED = "errored"
@@ -34,6 +35,12 @@ class SnapshotDiffPair(BaseModel):
     diff: float | None = None
 
 
+class SnapshotComparisonRunInfo(BaseModel):
+    state: str | None = None
+    completed_at: str | None = None
+    duration_ms: int | None = None
+
+
 class SnapshotDetailsApiResponse(BaseModel):
     head_artifact_id: str
     base_artifact_id: str | None = None  # Only present for diffs
@@ -51,6 +58,9 @@ class SnapshotDetailsApiResponse(BaseModel):
     removed: list[SnapshotImageResponse] = []
     removed_count: int = 0
 
+    renamed: list[SnapshotImageResponse] = []
+    renamed_count: int = 0
+
     changed: list[SnapshotDiffPair] = []
     changed_count: int = 0
 
@@ -60,5 +70,7 @@ class SnapshotDetailsApiResponse(BaseModel):
     errored: list[SnapshotDiffPair] = []
     errored_count: int = 0
 
+    comparison_run_info: SnapshotComparisonRunInfo | None = None
+
 
 # TODO: POST request in the future when we migrate away from current schemas

src/sentry/preprod/snapshots/manifest.py

@@ -41,7 +41,7 @@ class ComparisonSummary(BaseModel):
     unchanged: int
     added: int
     removed: int
-    errored: int
+    errored: int = 0
 
 
 class ComparisonManifest(BaseModel):

static/app/views/preprod/types/snapshotTypes.ts

@@ -16,6 +16,12 @@ export interface SnapshotDiffPair {
   head_image: SnapshotImage;
 }
 
+export interface SnapshotComparisonRunInfo {
+  completed_at?: string;
+  duration_ms?: number;
+  state?: ComparisonState;
+}
+
 export interface SnapshotDetailsApiResponse {
   comparison_type: 'solo' | 'diff';
   head_artifact_id: string;
@@ -25,6 +31,8 @@ export interface SnapshotDetailsApiResponse {
   state: string;
   vcs_info: BuildDetailsVcsInfo;
 
+  comparison_run_info?: SnapshotComparisonRunInfo;
+
   // Diff fields
   added: SnapshotImage[];
   added_count: number;
@@ -33,6 +41,20 @@ export interface SnapshotDetailsApiResponse {
   changed_count: number;
   removed: SnapshotImage[];
   removed_count: number;
+  renamed?: SnapshotImage[];
+  renamed_count?: number;
   unchanged: SnapshotImage[];
   unchanged_count: number;
 }
+
+export type ComparisonState = 'pending' | 'processing' | 'success' | 'failed';
+
+export type DiffStatus = 'changed' | 'added' | 'removed' | 'renamed' | 'unchanged';
+
+export type SidebarItem =
+  | {type: 'solo'; name: string; images: SnapshotImage[]}
+  | {type: 'changed'; name: string; pair: SnapshotDiffPair}
+  | {type: 'added'; name: string; image: SnapshotImage}
+  | {type: 'removed'; name: string; image: SnapshotImage}
+  | {type: 'renamed'; name: string; image: SnapshotImage}
+  | {type: 'unchanged'; name: string; image: SnapshotImage};