Skip to content

Commit 63479a8

Browse files
authored
chore(integrations): Silence 404s from GitHubs when firing alert handlers (#101266)
This is like any other configuration error and handling the uninstall behaviour shouldn't be done in the alert receiver. Ideally we'd remove this handler when we get a delete webhook, but either way this shouldn't be alerting here.
1 parent 9215bc9 commit 63479a8

File tree

1 file changed

+2
-0
lines changed
  • src/sentry/rules/actions/integrations/create_ticket

1 file changed

+2
-0
lines changed

src/sentry/rules/actions/integrations/create_ticket/utils.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
ApiUnauthorized,
2525
IntegrationConfigurationError,
2626
IntegrationFormError,
27+
IntegrationResourceNotFoundError,
2728
)
2829
from sentry.silo.base import region_silo_function
2930
from sentry.types.rules import RuleFuture
@@ -183,6 +184,7 @@ def create_issue(event: GroupEvent, futures: Sequence[RuleFuture]) -> None:
183184
IntegrationFormError,
184185
InvalidIdentity,
185186
ApiUnauthorized,
187+
IntegrationResourceNotFoundError,
186188
) as e:
187189
# Most of the time, these aren't explicit failures, they're
188190
# some misconfiguration of an issue field - typically Jira.

0 commit comments

Comments
 (0)