chore(cells) Switch ReactView and GenericReactView to control silo v2

Mulligan on #104552 which broke sentry-wizard.

We render the bulk of our HTML via ReactPage. Right now that endpoint is
marked as all_silo to make integration with tests simpler. Switch these
endpoints to control as we're trying to have a minimal number of
endpoints marked as all_silo and I want to better understand the scope
of test failures from this change.

This time around I've limited the excluded views to only subclasses of
`ReactPage` as we *do* have HTML views that the UI code uses.

Refs INFRENG-238

Author: markstory

src/sentry/management/commands/generate_controlsilo_urls.py

@@ -13,7 +13,7 @@
 from django.urls import URLPattern, URLResolver
 
 from sentry.silo.base import SiloMode
-from sentry.web.frontend.base import BaseView
+from sentry.web.frontend.react_page import GenericReactPageView, ReactPageView
 
 # There are a handful of catchall routes
 # that we don't want to handle in controlsilo
@@ -115,15 +115,19 @@ def handle(self, **options):
             except ImportError as err:
                 raise CommandError(f"Could not load view in {module}: {err}")
 
-            # If a view/endpoint doesn't have a silo_limit it is likely a basic django view
+            # If a view/endpoint doesn't have a silo_limit it is likely a basic django view.
             # We have tests in tests/sentry/silo/test_base.py that ensure all views/endpoints
-            # have silo annotations on them. BaseView subclasses generally render HTML,
-            # and we don't need them in the controlsilo URL inventory as the UI doesn't
-            # fetch data from them.
-            if (
-                not hasattr(view_func, "silo_limit")
-                or isinstance(view_func, type)
-                and issubclass(view_func, BaseView)
+            # have silo annotations on them. We skip including URLs for react views
+            # as those should be control only.
+            if not hasattr(view_func, "silo_limit") or (
+                isinstance(view_func, type)
+                and issubclass(
+                    view_func,
+                    (
+                        ReactPageView,
+                        GenericReactPageView,
+                    ),
+                )
             ):
                 continue
 

static/app/data/controlsiloUrlPatterns.ts

@@ -4,7 +4,10 @@ const patterns: RegExp[] = [
   new RegExp('^remote/heroku/resources(?:/[^/]+)?$'),
   new RegExp('^remote/heroku/sso-login/?$'),
   new RegExp('^remote/beacon/$'),
+  new RegExp('^remote/newsletter/unsubscribe/$'),
+  new RegExp('^remote/github-copilot/oauth/$'),
   new RegExp('^remote/github-secret-scanning/$'),
+  new RegExp('^remote/github/marketplace/purchase/$'),
   new RegExp('^remote/channel-provision/account/$'),
   new RegExp('^remote/vercel/v1/installations/new/plans/$'),
   new RegExp('^remote/vercel/v1/installations/[^/]+/plans/$'),
@@ -16,6 +19,9 @@ const patterns: RegExp[] = [
   new RegExp('^remote/vercel/v1/installations/[^/]+/resources/[^/]+/secrets/rotate$'),
   new RegExp('^remote/vercel/oauth$'),
   new RegExp('^support/$'),
+  new RegExp('^identity/login/[^/]+/$'),
+  new RegExp('^orgredirect/try-business/$'),
+  new RegExp('^orgredirect/'),
   new RegExp('^associate/complete/[^/]+/$'),
   new RegExp('^associate/[^/]+/$'),
   new RegExp('^api/0/staff-auth/$'),
@@ -49,6 +55,7 @@ const patterns: RegExp[] = [
   new RegExp('^api/0/sponsored_account_request/$'),
   new RegExp('^api/0/migrate_to_hosted/$'),
   new RegExp('^api/0/sponsored_education_account/$'),
+  new RegExp('^organizations/[^/]+/documents/[^/]+/?$'),
   new RegExp('^api/0/organizations/[^/]+/broadcasts/$'),
   new RegExp('^api/0/billing-config/$'),
   new RegExp('^api/0/auth-details/$'),
@@ -153,21 +160,41 @@ const patterns: RegExp[] = [
   new RegExp('^api/0/tempest-ips/$'),
   new RegExp('^api/0/secret-scanning/github/$'),
   new RegExp('^api/hooks/mailgun/inbound/'),
+  new RegExp('^oauth/authorize/$'),
   new RegExp('^oauth/token/$'),
   new RegExp('^oauth/userinfo/$'),
+  new RegExp('^saml/acs/[^/]+/$'),
+  new RegExp('^saml/sls/[^/]+/$'),
+  new RegExp('^saml/metadata/[^/]+/$'),
+  new RegExp('^auth/login/$'),
+  new RegExp('^auth/login/[^/]+/$'),
+  new RegExp('^auth/channel/[^/]+/[^/]+/$'),
+  new RegExp('^auth/link/[^/]+/$'),
+  new RegExp('^auth/2fa/$'),
   new RegExp('^auth/2fa/u2fappid\\.json$'),
+  new RegExp('^auth/sso/$'),
+  new RegExp('^auth/logout/$'),
+  new RegExp('^auth/reactivate/$'),
+  new RegExp('^auth/register/$'),
+  new RegExp('^auth/close/$'),
   new RegExp('^login-redirect/$'),
   new RegExp('^account/sudo/$'),
   new RegExp('^account/confirm-email/$'),
   new RegExp('^account/confirm-email/[^/]+/[^/]+/$'),
   new RegExp('^account/confirm-signed-email/[^/]+/$'),
+  new RegExp('^account/user-confirm/[^/]+/$'),
   new RegExp('^account/recover/$'),
   new RegExp('^account/recover/confirm/[^/]+/[^/]+/$'),
   new RegExp('^account/relocation/reclaim/[^/]+/$'),
+  new RegExp('^account/settings/identities/associate/[^/]+/[^/]+/[^/]+/$'),
+  new RegExp('^account/settings/wizard/[^/]+/$'),
   new RegExp('^account/settings/social/associate/complete/[^/]+/$'),
   new RegExp('^account/settings/social/associate/[^/]+/$'),
   new RegExp('^auth/sso/account/settings/social/associate/complete/[^/]+/$'),
   new RegExp('^out/$'),
+  new RegExp('^settings/organization/auth/configure/$'),
+  new RegExp('^organizations/[^/]+/auth/configure/$'),
+  new RegExp('^organizations/[^/]+/integrations/[^/]+/setup/$'),
   new RegExp('^avatar/[^/]+/$'),
   new RegExp('^sentry-app-avatar/[^/]+/$'),
   new RegExp('^doc-integration-avatar/[^/]+/$'),
@@ -176,18 +203,29 @@ const patterns: RegExp[] = [
   new RegExp('^extensions/jira/installed/$'),
   new RegExp('^extensions/jira/uninstalled/$'),
   new RegExp('^extensions/jira/search/[^/]+/[^/]+/$'),
+  new RegExp('^extensions/jira/configure/$'),
   new RegExp('^extensions/jira/issue-details/[^/]+/$'),
   new RegExp('^extensions/jira-server/search/[^/]+/[^/]+/$'),
+  new RegExp('^extensions/slack/link-identity/[^/]+/$'),
+  new RegExp('^extensions/slack/unlink-identity/[^/]+/$'),
   new RegExp('^extensions/github/installation/[^/]+/$'),
   new RegExp('^extensions/github/search/[^/]+/[^/]+/$'),
   new RegExp('^extensions/gitlab/search/[^/]+/[^/]+/$'),
   new RegExp('^extensions/vsts/search/[^/]+/[^/]+/$'),
+  new RegExp('^extensions/vsts/configure/$'),
   new RegExp('^extensions/bitbucket/descriptor/$'),
   new RegExp('^extensions/bitbucket/installed/$'),
   new RegExp('^extensions/bitbucket/uninstalled/$'),
   new RegExp('^extensions/bitbucket/search/[^/]+/[^/]+/$'),
+  new RegExp('^extensions/vercel/configure/$'),
   new RegExp('^extensions/vercel/delete/$'),
   new RegExp('^extensions/vercel/webhook/$'),
+  new RegExp('^extensions/msteams/configure/$'),
+  new RegExp('^extensions/msteams/link-identity/[^/]+/$'),
+  new RegExp('^extensions/msteams/unlink-identity/[^/]+/$'),
+  new RegExp('^extensions/discord/configure/$'),
+  new RegExp('^extensions/discord/link-identity/[^/]+/$'),
+  new RegExp('^extensions/discord/unlink-identity/[^/]+/$'),
 ];
 
 export default patterns;

tests/sentry/management/commands/test_generate_controlsilo_urls.py

@@ -37,9 +37,14 @@ def test_write_file(self) -> None:
             tf.seek(0)
             result = tf.read().decode("utf8")
         assert "This is generated code" in result
-        assert "new RegExp('^api/0/users/$')," in result
         assert "const patterns" in result
         assert "export default patterns;" in result
+        assert "new RegExp('^api/0/users/$')," in result
+        # Wizard is an HTML view that gets POST from UI code.
+        assert "new RegExp('^account/settings/wizard/[^/]+/$')," in result
+        # Views that render react application (like /dashboards)
+        # are not be used by UI code, and shouldn't be in the URL list
+        assert "new RegExp('^dashboards" not in result
 
     def test_no_missing_urls(self) -> None:
         pattern_file = "static/app/data/controlsiloUrlPatterns.ts"