Skip to content

Commit 6789e2b

Browse files
ref(quick-start): Update logic to display celebration when all tasks are done instead complete (#85927)
1 parent a394f69 commit 6789e2b

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

static/app/components/onboardingWizard/content.tsx

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -579,7 +579,8 @@ interface OnboardingSidebarContentProps {
579579
}
580580

581581
export function OnboardingSidebarContent({onClose}: OnboardingSidebarContentProps) {
582-
const {gettingStartedTasks, beyondBasicsTasks} = useOnboardingTasks();
582+
const {gettingStartedTasks, beyondBasicsTasks, allTasks, doneTasks} =
583+
useOnboardingTasks();
583584

584585
const sortedGettingStartedTasks = gettingStartedTasks.sort(
585586
(a, b) =>
@@ -598,10 +599,6 @@ export function OnboardingSidebarContent({onClose}: OnboardingSidebarContentProp
598599
)?.task;
599600
}, [sortedGettingStartedTasks, sortedBeyondBasicsTasks]);
600601

601-
const allTasksCompleted = [...gettingStartedTasks, ...beyondBasicsTasks].every(
602-
findCompleteTasks
603-
);
604-
605602
return (
606603
<Content>
607604
<TaskGroup
@@ -629,7 +626,7 @@ export function OnboardingSidebarContent({onClose}: OnboardingSidebarContentProp
629626
group="beyond_basics"
630627
/>
631628
)}
632-
{allTasksCompleted && (
629+
{allTasks.length === doneTasks.length && (
633630
<CompletionCelebrationText>
634631
<div>{t('Good job, you’re all done here!')}</div>
635632
{t('Now get out of here and write some broken code.')}

0 commit comments

Comments
 (0)