implement not in issue alert filter (#74595)

corollary to #74517

Author: nhsiehgit

src/sentry/api/endpoints/project_rules_configuration.py

@@ -95,11 +95,13 @@ def get(self, request: Request, project) -> Response:
                     context["id"] == "sentry.rules.filters.tagged_event.TaggedEventFilter"
                     or context["id"] == "sentry.rules.filters.event_attribute.EventAttributeFilter"
                 ) and not has_is_in:
-                    # Filter the form_fields to strip `is_in` choices
+                    # Filter the form_fields to strip `is_in` and `not_in` choices
                     match_choices = context["formFields"]["match"]["choices"]
                     copied_context = copy.deepcopy(context)
                     copied_context["formFields"]["match"]["choices"] = [
-                        choice for choice in match_choices if choice[0] != MatchType.IS_IN
+                        choice
+                        for choice in match_choices
+                        if (choice[0] != MatchType.IS_IN and choice[0] != MatchType.NOT_IN)
                     ]
                     filter_list.append(copied_context)
                     continue

src/sentry/rules/match.py

@@ -17,6 +17,7 @@ class MatchType:
     NOT_EQUAL = "ne"
     NOT_SET = "ns"
     NOT_STARTS_WITH = "nsw"
+    NOT_IN = "nin"
     STARTS_WITH = "sw"
 
 
@@ -43,6 +44,7 @@ class MatchType:
     MatchType.NOT_EQUAL: "does not equal",
     MatchType.NOT_SET: "is not set",
     MatchType.NOT_STARTS_WITH: "does not start with",
+    MatchType.NOT_IN: "not in (comma separated)",
     MatchType.STARTS_WITH: "starts with",
 }
 
@@ -92,4 +94,8 @@ def match_values(group_values: Iterable[Any], match_value: str, match_type: str)
         values_set = set(match_value.replace(" ", "").split(","))
         return any(g_value in values_set for g_value in group_values)
 
+    elif match_type == MatchType.NOT_IN:
+        values_set = set(match_value.replace(" ", "").split(","))
+        return not any(g_value in values_set for g_value in group_values)
+
     raise RuntimeError("Invalid Match")

tests/sentry/api/endpoints/test_project_rules_configuration.py

@@ -231,6 +231,7 @@ def test_has_in_feature(self):
                 choice[0] for choice in tagged_event_filter["formFields"]["match"]["choices"]
             ]
             assert MatchType.IS_IN not in filter_list
+            assert MatchType.NOT_IN not in filter_list
 
         with self.feature({"organizations:issues-alerts-is-in": True}):
             response = self.get_success_response(self.organization.slug, self.project.slug)
@@ -247,3 +248,4 @@ def test_has_in_feature(self):
                 choice[0] for choice in tagged_event_filter["formFields"]["match"]["choices"]
             ]
             assert MatchType.IS_IN in filter_list
+            assert MatchType.NOT_IN in filter_list

tests/sentry/rules/conditions/test_event_attribute.py

@@ -856,3 +856,15 @@ def test_attr_is_in(self):
             data={"match": MatchType.IS_IN, "attribute": "platform", "value": "python"}
         )
         self.assertDoesNotPass(rule, event)
+
+    def test_attr_not_in(self):
+        event = self.get_event()
+        rule = self.get_rule(
+            data={"match": MatchType.NOT_IN, "attribute": "platform", "value": "php, python"}
+        )
+        self.assertDoesNotPass(rule, event)
+
+        rule = self.get_rule(
+            data={"match": MatchType.NOT_IN, "attribute": "platform", "value": "python"}
+        )
+        self.assertPasses(rule, event)

tests/sentry/rules/conditions/test_tagged_event.py

@@ -141,3 +141,13 @@ def test_is_in(self):
 
         rule = self.get_rule(data={"match": MatchType.IS_IN, "key": "logger", "value": "foo.bar"})
         self.assertPasses(rule, event)
+
+    def test_not_in(self):
+        event = self.get_event()
+        rule = self.get_rule(
+            data={"match": MatchType.NOT_IN, "key": "logger", "value": "bar.foo, wee, wow"}
+        )
+        self.assertPasses(rule, event)
+
+        rule = self.get_rule(data={"match": MatchType.NOT_IN, "key": "logger", "value": "foo.bar"})
+        self.assertDoesNotPass(rule, event)

tests/sentry/rules/test_match.py

@@ -37,3 +37,9 @@ def test_does_not_contain(self):
     def test_is_in(self):
         assert match_values(["sentry.example"], "sentry.example, biz.baz, foo.bar", MatchType.IS_IN)
         assert not match_values(["sentry.example"], "biz.baz, foo.bar", MatchType.IS_IN)
+
+    def test_not_in(self):
+        assert match_values(["sentry.example"], "biz.baz, foo.bar", MatchType.NOT_IN)
+        assert not match_values(
+            ["sentry.example"], "sentry.example, biz.baz, foo.bar", MatchType.NOT_IN
+        )