ref(eslint): enable typescript-eslint/no-meaningless-void-operator (#97377)

reports when the `void` operator is used on a function that already
returns `void`. Most violations were in test code only.

Author: TkDodo

eslint.config.mjs

@@ -485,6 +485,7 @@ export default typescript.config([
           '@typescript-eslint/no-for-in-array': 'error',
           '@typescript-eslint/no-unnecessary-type-assertion': 'error',
           '@typescript-eslint/prefer-optional-chain': 'error',
+          '@typescript-eslint/no-meaningless-void-operator': 'error',
         }
       : {},
   },

static/app/components/autoComplete.spec.tsx

@@ -45,7 +45,7 @@ describe('AutoComplete', function () {
     itemCount: number;
     registerItemCount: (count?: number) => void;
   }) {
-    useEffect(() => void registerItemCount(itemCount), [itemCount, registerItemCount]);
+    useEffect(() => registerItemCount(itemCount), [itemCount, registerItemCount]);
     return <ul {...props} />;
   }
 

static/app/components/events/rrwebReplayer/baseRRWebReplayer.tsx

@@ -30,7 +30,7 @@ function BaseRRWebReplayerComponent({events, className}: Props) {
     });
   }, [events]);
 
-  useEffect(() => void initPlayer(), [initPlayer]);
+  useEffect(() => initPlayer(), [initPlayer]);
 
   return <div ref={playerEl} className={className} />;
 }

static/app/components/groupPreviewTooltip/groupPreviewHovercard.tsx

@@ -19,7 +19,7 @@ export function GroupPreviewHovercard({
 }: GroupPreviewHovercardProps) {
   const theme = useTheme();
   const handleStackTracePreviewClick = useCallback(
-    (e: React.MouseEvent) => void e.stopPropagation(),
+    (e: React.MouseEvent) => e.stopPropagation(),
     []
   );
 

static/app/components/modals/commandPalette.tsx

@@ -13,7 +13,7 @@ function CommandPalette({Body}: ModalRenderProps) {
 
   useEffect(
     () =>
-      void trackAnalytics('omnisearch.open', {
+      trackAnalytics('omnisearch.open', {
         organization: null,
       }),
     []

static/app/components/profiling/flamegraph/flamegraph.spec.tsx

@@ -109,7 +109,7 @@ Object.defineProperty(window, 'matchMedia', {
 describe('Flamegraph', function () {
   beforeEach(() => {
     const project = ProjectFixture({slug: 'foo-project'});
-    act(() => void ProjectsStore.loadInitialData([project]));
+    act(() => ProjectsStore.loadInitialData([project]));
     setWindowLocation('http://localhost/');
   });
   it('renders a missing profile', async function () {

static/app/components/sidebar/index.spec.tsx

@@ -168,7 +168,7 @@ describe('Sidebar', function () {
     });
 
     it('can open "Switch Organization" sub-menu', async function () {
-      act(() => void ConfigStore.set('features', new Set(['organizations:create'])));
+      act(() => ConfigStore.set('features', new Set(['organizations:create'])));
 
       renderSidebar({organization});
 

static/app/components/sidebar/index.tsx

@@ -127,7 +127,7 @@ function Sidebar() {
   }, [collapsed]);
 
   // Close panel on any navigation
-  useEffect(() => void hidePanel(), [location?.pathname]);
+  useEffect(() => hidePanel(), [location?.pathname]);
 
   // Add classname to body
   useEffect(() => {

static/app/components/themeAndStyleProvider.tsx

@@ -30,7 +30,7 @@ cache.compat = true;
  */
 export function ThemeAndStyleProvider({children}: Props) {
   // @TODO(jonasbadalic): the preferences state here seems related to just the sidebar collapse state
-  useEffect(() => void loadPreferencesState(), []);
+  useEffect(() => loadPreferencesState(), []);
 
   const config = useLegacyStore(ConfigStore);
   const theme = useThemeSwitcher();

static/app/stores/useLegacyStore.spec.tsx

@@ -8,7 +8,7 @@ import {useLegacyStore} from 'sentry/stores/useLegacyStore';
 describe('useLegacyStore', () => {
   const team = TeamFixture();
 
-  beforeEach(() => void TeamStore.reset());
+  beforeEach(() => TeamStore.reset());
 
   it('should update on change to store', () => {
     const {result} = renderHook(useLegacyStore, {initialProps: TeamStore});