fix tests

Author: Cathy Teng

tests/sentry/workflow_engine/processors/test_detector.py

@@ -838,7 +838,7 @@ class TestGetDetectorsForEvent(TestCase):
     def setUp(self) -> None:
         super().setUp()
         self.project = self.create_project()
-        self.group = self.create_group(project=self.project)
+        self.group = self.create_group(project=self.project, type=MetricIssue.type_id)
         self.detector = self.create_detector(project=self.project, type=MetricIssue.slug)
         self.error_detector = self.create_detector(project=self.project, type=ErrorGroupType.slug)
         self.issue_stream_detector = self.create_detector(
@@ -950,7 +950,7 @@ def test_exclude_issue_stream_detector(self) -> None:
 class TestGetDetectorByEvent(TestCase):
     def setUp(self) -> None:
         super().setUp()
-        self.group = self.create_group(project=self.project)
+        self.group = self.create_group(project=self.project, type=MetricIssue.type_id)
         self.detector = self.create_detector(project=self.project, type=MetricIssue.slug)
         self.error_detector = self.create_detector(project=self.project, type=ErrorGroupType.slug)
         self.event = self.store_event(project_id=self.project.id, data={})
@@ -981,6 +981,7 @@ def test_with_occurrence(self) -> None:
         assert result == self.detector
 
     def test_without_occurrence(self) -> None:
+        self.group.type = ErrorGroupType.type_id
         group_event = GroupEvent.from_event(self.event, self.group)
         group_event.occurrence = None
 
@@ -1028,7 +1029,7 @@ def test_no_detector_id(self) -> None:
         with pytest.raises(Detector.DoesNotExist):
             get_detector_by_event(event_data)
 
-    def test_defaults_to_error_detector(self) -> None:
+    def test_errors_on_no_detector(self) -> None:
         occurrence = IssueOccurrence(
             id=uuid.uuid4().hex,
             project_id=self.project.id,
@@ -1051,9 +1052,8 @@ def test_defaults_to_error_detector(self) -> None:
 
         event_data = WorkflowEventData(event=group_event, group=self.group)
 
-        result = get_detector_by_event(event_data)
-
-        assert result == self.error_detector
+        with pytest.raises(Detector.DoesNotExist):
+            get_detector_by_event(event_data)
 
 
 class TestAssociateNewGroupWithDetector(TestCase):

tests/sentry/workflow_engine/processors/test_workflow.py

@@ -6,6 +6,7 @@
 
 from sentry.eventstream.base import GroupState
 from sentry.grouping.grouptype import ErrorGroupType
+from sentry.incidents.grouptype import MetricIssue
 from sentry.models.activity import Activity
 from sentry.models.environment import Environment
 from sentry.services.eventstore.models import GroupEvent
@@ -63,7 +64,9 @@ def setUp(self) -> None:
             )
         )
 
-        self.group, self.event, self.group_event = self.create_group_event()
+        self.group, self.event, self.group_event = self.create_group_event(
+            group_type_id=MetricIssue.type_id
+        )
         self.event_data = WorkflowEventData(
             event=self.group_event,
             group=self.group,
@@ -304,6 +307,7 @@ def test_same_environment_only(self) -> None:
     def test_issue_occurrence_event(self) -> None:
         issue_occurrence = self.build_occurrence(evidence_data={"detector_id": self.detector.id})
         self.group_event.occurrence = issue_occurrence
+        self.group_event.group.type = issue_occurrence.type.type_id
 
         result = process_workflows(self.batch_client, self.event_data, FROZEN_TIME)
         assert result.data.triggered_workflows == {self.workflow}
@@ -670,6 +674,7 @@ class TestWorkflowEnqueuing(BaseWorkflowTest):
     buffer_timestamp = (FROZEN_TIME + timedelta(seconds=1)).timestamp()
 
     def setUp(self) -> None:
+        self.project = self.create_project(create_default_detectors=True)
         (
             self.workflow,
             self.detector,
@@ -679,7 +684,7 @@ def setUp(self) -> None:
 
         occurrence = self.build_occurrence(evidence_data={"detector_id": self.detector.id})
         self.group, self.event, self.group_event = self.create_group_event(
-            occurrence=occurrence,
+            occurrence=occurrence, group_type_id=MetricIssue.type_id
         )
         self.event_data = WorkflowEventData(event=self.group_event, group=self.group)
         self.action_group, _ = self.create_workflow_action(self.workflow)
@@ -877,17 +882,23 @@ def setUp(self) -> None:
         ) = self.create_detector_and_workflow()
 
         self.action_group, self.action = self.create_workflow_action(workflow=self.workflow)
+        self.issue_stream_detector = self.create_detector(
+            project=self.project,
+            type=IssueStreamGroupType.slug,
+        )
 
         self.group, self.event, self.group_event = self.create_group_event(
-            occurrence=self.build_occurrence(evidence_data={"detector_id": self.detector.id})
+            occurrence=self.build_occurrence(evidence_data={"detector_id": self.detector.id}),
+            group_type_id=MetricIssue.type_id,
         )
         self.event_data = WorkflowEventData(event=self.group_event, group=self.group)
         self.batch_client = DelayedWorkflowClient()
 
     @patch("sentry.utils.metrics.incr")
     @patch("sentry.workflow_engine.tasks.utils.IssueOccurrence.fetch")
+    @patch("sentry.workflow_engine.processors.action.Action.trigger")
     def test_metrics_issue_dual_processing_metrics(
-        self, mock_fetch: MagicMock, mock_incr: MagicMock
+        self, mock_trigger: MagicMock, mock_fetch: MagicMock, mock_incr: MagicMock
     ) -> None:
         mock_fetch.return_value = self.group_event.occurrence
 
@@ -901,6 +912,7 @@ def test_metrics_issue_dual_processing_metrics(
             },
             sample_rate=1.0,
         )
+        mock_trigger.assert_called_once()
 
     def test_basic__no_filter(self) -> None:
         triggered_action_filters, _ = evaluate_workflows_action_filters(