Skip to content

Commit 6f4485e

Browse files
ref: fix more typing issues in HC modules (#73580)
<!-- Describe your PR here. -->
1 parent 880e6d4 commit 6f4485e

File tree

2 files changed

+7
-8
lines changed

2 files changed

+7
-8
lines changed

src/sentry/audit_log/services/log/impl.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
import datetime
44

55
from django.db import IntegrityError, router, transaction
6-
from django.db.models import QuerySet
76

87
from sentry.audit_log.services.log import AuditLogEvent, LogService, UserIpEvent
98
from sentry.db.postgres.transactions import enforce_constraints
@@ -54,12 +53,12 @@ def record_user_ip(self, *, event: UserIpEvent) -> None:
5453
def find_last_log(
5554
self,
5655
*,
57-
organization_id: int | None,
56+
organization_id: int,
5857
target_object_id: int | None,
59-
event: int | None,
58+
event: int,
6059
data: dict[str, str] | None = None,
6160
) -> AuditLogEvent | None:
62-
last_entry_q: QuerySet[AuditLogEntry] = AuditLogEntry.objects.filter(
61+
last_entry_q = AuditLogEntry.objects.filter(
6362
organization_id=organization_id,
6463
target_object=target_object_id,
6564
event=event,
@@ -98,9 +97,9 @@ def record_user_ip(self, *, event: UserIpEvent) -> None:
9897
def find_last_log(
9998
self,
10099
*,
101-
organization_id: int | None,
100+
organization_id: int,
102101
target_object_id: int | None,
103-
event: int | None,
102+
event: int,
104103
data: dict[str, str] | None = None,
105104
) -> AuditLogEvent | None:
106105
return None

src/sentry/audit_log/services/log/service.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,9 @@ def record_user_ip(self, *, event: UserIpEvent) -> None:
3535
def find_last_log(
3636
self,
3737
*,
38-
organization_id: int | None,
38+
organization_id: int,
3939
target_object_id: int | None,
40-
event: int | None,
40+
event: int,
4141
data: dict[str, str] | None = None,
4242
) -> AuditLogEvent | None:
4343
pass

0 commit comments

Comments
 (0)