♻️ ref(metric alerts): refactor _build_incident_query_builder and _calculate_incident_time_range (#86014)

refactory work to make notification action work with metric alert
registry.

here, i remove the `windowed_stats` param because its completely unused,
and hoist FK lookups from `_build_incident_query_builder` and
`_calculate_incident_time_range`

Author: iamrajjoshi

src/sentry/incidents/logic.py

@@ -270,25 +270,49 @@ def _unpack_organization(alert_rule: AlertRule) -> Organization:
     return organization
 
 
-def _build_incident_query_builder(
-    incident: Incident,
-    entity_subscription: EntitySubscription,
-    start: datetime | None = None,
-    end: datetime | None = None,
-    windowed_stats: bool = False,
+@dataclass
+class BaseMetricIssueQueryParams:
+    snuba_query: SnubaQuery
+    date_started: datetime
+    current_end_date: datetime
+    organization: Organization
+
+
+@dataclass
+class CalculateOpenPeriodTimeRangeParams(BaseMetricIssueQueryParams):
+    start_arg: datetime | None = None
+    end_arg: datetime | None = None
+
+
+@dataclass
+class BuildMetricQueryBuilderParams(BaseMetricIssueQueryParams):
+    project_ids: list[int]
+    entity_subscription: EntitySubscription
+    start_arg: datetime | None = None
+    end_arg: datetime | None = None
+
+
+def _build_metric_query_builder(
+    params: BuildMetricQueryBuilderParams,
 ) -> BaseQueryBuilder:
-    snuba_query = _unpack_snuba_query(incident.alert_rule)
-    start, end = _calculate_incident_time_range(incident, start, end, windowed_stats=windowed_stats)
-    project_ids = list(
-        IncidentProject.objects.filter(incident=incident).values_list("project_id", flat=True)
+    start, end = _calculate_open_period_time_range(
+        CalculateOpenPeriodTimeRangeParams(
+            snuba_query=params.snuba_query,
+            date_started=params.date_started,
+            current_end_date=params.current_end_date,
+            organization=params.organization,
+            start_arg=params.start_arg,
+            end_arg=params.end_arg,
+        )
     )
-    query_builder = entity_subscription.build_query_builder(
-        query=snuba_query.query,
-        project_ids=project_ids,
-        environment=snuba_query.environment,
+
+    query_builder = params.entity_subscription.build_query_builder(
+        query=params.snuba_query.query,
+        project_ids=params.project_ids,
+        environment=params.snuba_query.environment,
         params={
-            "organization_id": incident.organization_id,
-            "project_id": project_ids,
+            "organization_id": params.organization.id,
+            "project_id": params.project_ids,
             "start": start,
             "end": end,
         },
@@ -309,37 +333,19 @@ def _build_incident_query_builder(
     return query_builder
 
 
-def _calculate_incident_time_range(
-    incident: Incident,
-    start_arg: datetime | None = None,
-    end_arg: datetime | None = None,
-    windowed_stats: bool = False,
+def _calculate_open_period_time_range(
+    params: CalculateOpenPeriodTimeRangeParams,
 ) -> tuple[datetime, datetime]:
-    snuba_query = _unpack_snuba_query(incident.alert_rule)
-    time_window = snuba_query.time_window if incident.alert_rule is not None else 60
+    time_window = params.snuba_query.time_window
     time_window_delta = timedelta(seconds=time_window)
-    start = (incident.date_started - time_window_delta) if start_arg is None else start_arg
-    end = (incident.current_end_date + time_window_delta) if end_arg is None else end_arg
-    if windowed_stats:
-        now = django_timezone.now()
-        end = start + timedelta(seconds=time_window * (WINDOWED_STATS_DATA_POINTS / 2))
-        start = start - timedelta(seconds=time_window * (WINDOWED_STATS_DATA_POINTS / 2))
-        if end > now:
-            end = now
-
-            # If the incident ended already, 'now' could be greater than we'd like
-            # which would result in showing too many data points after an incident ended.
-            # This depends on when the task to process snapshots runs.
-            # To resolve that, we ensure that the end is never greater than the date
-            # an incident ended + the smaller of time_window*10 or 10 days.
-            latest_end_date = incident.current_end_date + min(
-                timedelta(seconds=time_window * 10), timedelta(days=10)
-            )
-            end = min(end, latest_end_date)
-
-            start = end - timedelta(seconds=time_window * WINDOWED_STATS_DATA_POINTS)
+    start = (
+        (params.date_started - time_window_delta) if params.start_arg is None else params.start_arg
+    )
+    end = (
+        (params.current_end_date + time_window_delta) if params.end_arg is None else params.end_arg
+    )
 
-    retention = quotas.backend.get_event_retention(organization=incident.organization) or 90
+    retention = quotas.backend.get_event_retention(organization=params.organization) or 90
     start = max(
         start.replace(tzinfo=timezone.utc),
         datetime.now(timezone.utc) - timedelta(days=retention),
@@ -353,7 +359,6 @@ def get_incident_aggregates(
     incident: Incident,
     start: datetime | None = None,
     end: datetime | None = None,
-    windowed_stats: bool = False,
 ) -> dict[str, float | int]:
     """
     Calculates aggregate stats across the life of an incident, or the provided range.
@@ -363,13 +368,20 @@ def get_incident_aggregates(
         snuba_query,
         incident.organization_id,
     )
-    if entity_subscription.dataset == Dataset.EventsAnalyticsPlatform:
-        start, end = _calculate_incident_time_range(
-            incident, start, end, windowed_stats=windowed_stats
-        )
+    project_ids = list(
+        IncidentProject.objects.filter(incident=incident).values_list("project_id", flat=True)
+    )
 
-        project_ids = list(
-            IncidentProject.objects.filter(incident=incident).values_list("project_id", flat=True)
+    if entity_subscription.dataset == Dataset.EventsAnalyticsPlatform:
+        start, end = _calculate_open_period_time_range(
+            CalculateOpenPeriodTimeRangeParams(
+                snuba_query=snuba_query,
+                date_started=incident.date_started,
+                current_end_date=incident.current_end_date,
+                organization=incident.organization,
+                start_arg=start,
+                end_arg=end,
+            )
         )
 
         params = SnubaParams(
@@ -404,8 +416,17 @@ def get_incident_aggregates(
             )
             raise
     else:
-        query_builder = _build_incident_query_builder(
-            incident, entity_subscription, start, end, windowed_stats
+        query_builder = _build_metric_query_builder(
+            BuildMetricQueryBuilderParams(
+                snuba_query=snuba_query,
+                organization=incident.organization,
+                project_ids=project_ids,
+                entity_subscription=entity_subscription,
+                date_started=incident.date_started,
+                current_end_date=incident.current_end_date,
+                start_arg=start,
+                end_arg=end,
+            )
         )
         try:
             results = query_builder.run_query(referrer="incidents.get_incident_aggregates")