Skip to content

Commit 7737c5b

Browse files
committed
fix merge
1 parent 2711052 commit 7737c5b

File tree

1 file changed

+14
-45
lines changed

1 file changed

+14
-45
lines changed

tests/sentry/workflow_engine/processors/test_workflow.py

Lines changed: 14 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
import pytest
55
from django.utils import timezone
66

7-
from sentry.eventstore.models import GroupEvent
87
from sentry.eventstream.base import GroupState
98
from sentry.grouping.grouptype import ErrorGroupType
109
from sentry.models.activity import Activity
@@ -477,15 +476,10 @@ def test_enqueues_workflow_all_logic_type(self) -> None:
477476

478477
process_workflows(self.event_data)
479478

480-
<<<<<<< HEAD
481-
project_ids = buffer.backend.bulk_get_sorted_set(
479+
project_ids = workflow_buffer.get_backend().bulk_get_sorted_set(
482480
self.buffer_keys,
483481
min=0,
484482
max=self.buffer_timestamp,
485-
=======
486-
project_ids = workflow_buffer.get_backend().get_sorted_set(
487-
WORKFLOW_ENGINE_BUFFER_LIST_KEY, 0, self.buffer_timestamp
488-
>>>>>>> 72e32fd402c (fixup)
489483
)
490484
assert list(project_ids.keys()) == [self.project.id]
491485

@@ -514,15 +508,10 @@ def test_enqueues_workflow_any_logic_type(self) -> None:
514508

515509
process_workflows(self.event_data)
516510

517-
<<<<<<< HEAD
518-
project_ids = buffer.backend.bulk_get_sorted_set(
511+
project_ids = workflow_buffer.get_backend().bulk_get_sorted_set(
519512
self.buffer_keys,
520513
min=0,
521514
max=self.buffer_timestamp,
522-
=======
523-
project_ids = workflow_buffer.get_backend().get_sorted_set(
524-
WORKFLOW_ENGINE_BUFFER_LIST_KEY, 0, self.buffer_timestamp
525-
>>>>>>> 72e32fd402c (fixup)
526515
)
527516
assert list(project_ids.keys()) == [self.project.id]
528517

@@ -601,15 +590,10 @@ def test_enqueues_with_when_and_if_slow_conditions(self) -> None:
601590

602591
process_workflows(self.event_data)
603592

604-
<<<<<<< HEAD
605-
project_ids = buffer.backend.bulk_get_sorted_set(
593+
project_ids = workflow_buffer.get_backend().bulk_get_sorted_set(
606594
self.buffer_keys,
607595
min=0,
608596
max=self.buffer_timestamp,
609-
=======
610-
project_ids = workflow_buffer.get_backend().get_sorted_set(
611-
WORKFLOW_ENGINE_BUFFER_LIST_KEY, 0, self.buffer_timestamp
612-
>>>>>>> 72e32fd402c (fixup)
613597
)
614598
assert list(project_ids.keys()) == [self.project.id]
615599

@@ -635,15 +619,10 @@ def test_enqueues_event_if_meets_fast_conditions(self) -> None:
635619

636620
process_workflows(self.event_data)
637621

638-
<<<<<<< HEAD
639-
project_ids = buffer.backend.bulk_get_sorted_set(
622+
project_ids = workflow_buffer.get_backend().bulk_get_sorted_set(
640623
self.buffer_keys,
641624
min=0,
642625
max=self.buffer_timestamp,
643-
=======
644-
project_ids = workflow_buffer.get_backend().get_sorted_set(
645-
WORKFLOW_ENGINE_BUFFER_LIST_KEY, 0, self.buffer_timestamp
646-
>>>>>>> 72e32fd402c (fixup)
647626
)
648627
assert not project_ids
649628

@@ -652,15 +631,10 @@ def test_enqueues_event_if_meets_fast_conditions(self) -> None:
652631

653632
process_workflows(self.event_data)
654633

655-
<<<<<<< HEAD
656-
project_ids = buffer.backend.bulk_get_sorted_set(
634+
project_ids = workflow_buffer.get_backend().bulk_get_sorted_set(
657635
self.buffer_keys,
658636
min=0,
659637
max=self.buffer_timestamp,
660-
=======
661-
project_ids = workflow_buffer.get_backend().get_sorted_set(
662-
WORKFLOW_ENGINE_BUFFER_LIST_KEY, 0, self.buffer_timestamp
663-
>>>>>>> 72e32fd402c (fixup)
664638
)
665639
assert list(project_ids.keys()) == [self.project.id]
666640

@@ -810,15 +784,10 @@ def test_enqueues_when_slow_conditions(self):
810784

811785
enqueue_workflows(queue_items)
812786

813-
<<<<<<< HEAD
814-
project_ids = buffer.backend.bulk_get_sorted_set(
787+
project_ids = workflow_buffer.get_backend().bulk_get_sorted_set(
815788
self.buffer_keys,
816789
min=0,
817790
max=timezone.now().timestamp(),
818-
=======
819-
project_ids = workflow_buffer.get_backend().get_sorted_set(
820-
WORKFLOW_ENGINE_BUFFER_LIST_KEY, 0, timezone.now().timestamp()
821-
>>>>>>> 72e32fd402c (fixup)
822791
)
823792
assert list(project_ids.keys()) == [self.project.id]
824793

@@ -854,14 +823,11 @@ def setUp(self) -> None:
854823

855824
@patch("sentry.buffer.backend.push_to_sorted_set")
856825
@patch("sentry.buffer.backend.push_to_hash_bulk")
857-
<<<<<<< HEAD
858826
@patch("random.choice")
859-
=======
860827
@override_options({"workflow_engine.buffer.use_new_buffer": False})
861-
>>>>>>> 72e32fd402c (fixup)
862828
def test_enqueue_workflows__adds_to_workflow_engine_buffer(
863829
self, mock_randchoice, mock_push_to_hash_bulk, mock_push_to_sorted_set
864-
):
830+
) -> None:
865831
mock_randchoice.return_value = f"{DelayedWorkflow.buffer_key}:{5}"
866832
enqueue_workflows(
867833
{
@@ -883,10 +849,13 @@ def test_enqueue_workflows__adds_to_workflow_engine_buffer(
883849

884850
@patch("sentry.workflow_engine.buffer._backend.push_to_sorted_set")
885851
@patch("sentry.workflow_engine.buffer._backend.push_to_hash_bulk")
852+
@patch("random.choice")
886853
@override_options({"workflow_engine.buffer.use_new_buffer": True})
887854
def test_enqueue_workflows__adds_to_workflow_engine_buffer_new_buffer(
888-
self, mock_push_to_hash_bulk, mock_push_to_sorted_set
889-
):
855+
self, mock_randchoice, mock_push_to_hash_bulk, mock_push_to_sorted_set
856+
) -> None:
857+
key_choice = f"{DelayedWorkflow.buffer_key}:{5}"
858+
mock_randchoice.return_value = key_choice
890859
enqueue_workflows(
891860
{
892861
self.workflow: DelayedWorkflowItem(
@@ -901,7 +870,7 @@ def test_enqueue_workflows__adds_to_workflow_engine_buffer_new_buffer(
901870
)
902871

903872
mock_push_to_sorted_set.assert_called_once_with(
904-
key=WORKFLOW_ENGINE_BUFFER_LIST_KEY,
873+
key=key_choice,
905874
value=[self.group_event.project_id],
906875
)
907876

@@ -910,7 +879,7 @@ def test_enqueue_workflows__adds_to_workflow_engine_buffer_new_buffer(
910879
@override_options({"workflow_engine.buffer.use_new_buffer": False})
911880
def test_enqueue_workflow__adds_to_workflow_engine_set(
912881
self, mock_push_to_hash_bulk, mock_push_to_sorted_set
913-
):
882+
) -> None:
914883
current_time = timezone.now()
915884
workflow_filter_group_2 = self.create_data_condition_group()
916885
self.create_workflow_data_condition_group(

0 commit comments

Comments
 (0)