🔧 chore: add some more record_failures

Author: iamrajjoshi

src/sentry/integrations/source_code_management/commit_context.py

@@ -106,13 +106,15 @@ def get_blame_for_files(
         ).capture() as lifecycle:
             try:
                 client = self.get_client()
-            except Identity.DoesNotExist:
-                sentry_sdk.capture_exception()
+            except Identity.DoesNotExist as e:
+                lifecycle.record_failure(e)
+                sentry_sdk.capture_exception(e)
                 return []
             try:
                 response = client.get_blame_for_files(files, extra)
-            except IdentityNotValid:
-                sentry_sdk.capture_exception()
+            except IdentityNotValid as e:
+                lifecycle.record_failure(e)
+                sentry_sdk.capture_exception(e)
                 return []
             # Swallow rate limited errors so we don't log them as exceptions
             except ApiRateLimitedError as e:

src/sentry/integrations/source_code_management/metrics.py

@@ -1,5 +1,5 @@
 from collections.abc import Mapping
-from enum import Enum, StrEnum
+from enum import StrEnum
 from typing import Any
 
 from attr import dataclass
@@ -15,7 +15,7 @@
 from sentry.organizations.services.organization import RpcOrganization
 
 
-class SCMIntegrationInteractionType(Enum):
+class SCMIntegrationInteractionType(StrEnum):
     """
     SCM integration features
     """
@@ -37,9 +37,6 @@ class SCMIntegrationInteractionType(Enum):
     # Tasks
     LINK_ALL_REPOS = "LINK_ALL_REPOS"
 
-    def __str__(self) -> str:
-        return self.value.lower()
-
 
 @dataclass
 class SCMIntegrationInteractionEvent(IntegrationEventLifecycleMetric):
@@ -70,15 +67,6 @@ def get_extras(self) -> Mapping[str, Any]:
         }
 
 
-class LinkAllReposHaltReason(StrEnum):
-    """Common reasons why a link all repos task may halt without success/failure."""
-
-    MISSING_INTEGRATION = "missing_integration"
-    MISSING_ORGANIZATION = "missing_organization"
-    RATE_LIMITED = "rate_limited"
-    REPOSITORY_NOT_CREATED = "repository_not_created"
-
-
 @dataclass
 class CommitContextIntegrationInteractionEvent(SCMIntegrationInteractionEvent):
     """
@@ -109,3 +97,12 @@ class CommitContextHaltReason(StrEnum):
     COMMIT_NOT_IN_DEFAULT_BRANCH = "commit_not_in_default_branch"
     MISSING_PR = "missing_pr"
     ALREADY_QUEUED = "already_queued"
+
+
+class LinkAllReposHaltReason(StrEnum):
+    """Common reasons why a link all repos task may halt without success/failure."""
+
+    MISSING_INTEGRATION = "missing_integration"
+    MISSING_ORGANIZATION = "missing_organization"
+    RATE_LIMITED = "rate_limited"
+    REPOSITORY_NOT_CREATED = "repository_not_created"