Skip to content

Commit 7a04836

Browse files
authored
fix(ourlogs): Remove special casing from logs severity (#97908)
### Summary Log severity are only valid as lower case (which is how they're sent), transforming them to all uppercase causes a mismatch between representation and filtering #### Other These functions can be cleaned up later (we no longer use severity number to calculate log level), but for now lower them so they match the text when filtering Closes ENG-5274
1 parent feda7b4 commit 7a04836

File tree

2 files changed

+11
-10
lines changed

2 files changed

+11
-10
lines changed

static/app/views/explore/logs/tables/logsTableRow.spec.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ describe('logsTableRow', () => {
5050
[OurLogKnownFieldKey.PROJECT_ID]: project.id,
5151
[OurLogKnownFieldKey.ORGANIZATION_ID]: Number(organization.id),
5252
[OurLogKnownFieldKey.TRACE_ID]: '7b91699f',
53+
[OurLogKnownFieldKey.SEVERITY]: 'info',
5354
});
5455

5556
// These are the detailed attributes of the row - only displayed when you click the row.
@@ -286,7 +287,7 @@ describe('logsTableRow', () => {
286287

287288
// Check that the attribute values are rendered
288289
expect(screen.queryByText(projects[0]!.id)).not.toBeInTheDocument();
289-
expect(screen.getByText('error')).toBeInTheDocument();
290+
expect(screen.getAllByText('info')).toHaveLength(2); // Severity circle and text
290291
expect(screen.getByText('7b91699f')).toBeInTheDocument();
291292

292293
// Check that the attributes keys are rendered
@@ -444,7 +445,7 @@ describe('logsTableRow', () => {
444445
expect(parsedData).toMatchObject({
445446
message: 'test log body',
446447
trace: '7b91699f',
447-
severity: 'error',
448+
severity: 'info',
448449
item_id: '1',
449450
});
450451

static/app/views/explore/logs/utils.tsx

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -133,14 +133,14 @@ export enum SeverityLevel {
133133
*/
134134
export function severityLevelToText(level: SeverityLevel) {
135135
return {
136-
[SeverityLevel.TRACE]: t('TRACE'),
137-
[SeverityLevel.DEBUG]: t('DEBUG'),
138-
[SeverityLevel.INFO]: t('INFO'),
139-
[SeverityLevel.WARN]: t('WARN'),
140-
[SeverityLevel.ERROR]: t('ERROR'),
141-
[SeverityLevel.FATAL]: t('FATAL'),
142-
[SeverityLevel.DEFAULT]: t('DEFAULT'),
143-
[SeverityLevel.UNKNOWN]: t('UNKNOWN'), // Maps to info for now.
136+
[SeverityLevel.TRACE]: t('trace'),
137+
[SeverityLevel.DEBUG]: t('debug'),
138+
[SeverityLevel.INFO]: t('info'),
139+
[SeverityLevel.WARN]: t('warn'),
140+
[SeverityLevel.ERROR]: t('error'),
141+
[SeverityLevel.FATAL]: t('fatal'),
142+
[SeverityLevel.DEFAULT]: t('default'),
143+
[SeverityLevel.UNKNOWN]: t('unknown'), // Maps to info for now.
144144
}[level];
145145
}
146146

0 commit comments

Comments
 (0)