Skip to content

Commit 7a1a70f

Browse files
trevor-eandrewshie-sentry
authored andcommitted
refactor(preprod): move size status check code into own dir (#98959)
Preparation for when we have more than just size analysis status checks.
1 parent af6e625 commit 7a1a70f

File tree

10 files changed

+11
-11
lines changed

10 files changed

+11
-11
lines changed

bin/preprod/trigger_size_status_check

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ logger = logging.getLogger(__name__)
1212
from sentry.models.commitcomparison import CommitComparison
1313
from sentry.models.project import Project
1414
from sentry.preprod.models import PreprodArtifact, PreprodArtifactSizeMetrics
15-
from sentry.preprod.vcs.status_checks.tasks import create_preprod_status_check_task
15+
from sentry.preprod.vcs.status_checks.size.tasks import create_preprod_status_check_task
1616

1717
#################
1818
# Configuration #

src/sentry/preprod/api/endpoints/organization_preprod_artifact_assemble.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
from sentry.preprod.analytics import PreprodArtifactApiAssembleEvent
1717
from sentry.preprod.tasks import assemble_preprod_artifact, create_preprod_artifact
1818
from sentry.preprod.url_utils import get_preprod_artifact_url
19-
from sentry.preprod.vcs.status_checks.tasks import create_preprod_status_check_task
19+
from sentry.preprod.vcs.status_checks.size.tasks import create_preprod_status_check_task
2020
from sentry.tasks.assemble import ChunkFileState
2121

2222

src/sentry/preprod/api/endpoints/project_preprod_artifact_update.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
from sentry.preprod.analytics import PreprodArtifactApiUpdateEvent
1313
from sentry.preprod.authentication import LaunchpadRpcSignatureAuthentication
1414
from sentry.preprod.models import PreprodArtifact
15-
from sentry.preprod.vcs.status_checks.tasks import create_preprod_status_check_task
15+
from sentry.preprod.vcs.status_checks.size.tasks import create_preprod_status_check_task
1616

1717

1818
def validate_preprod_artifact_update_schema(request_body: bytes) -> tuple[dict, str | None]:

src/sentry/preprod/tasks.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
PreprodBuildConfiguration,
2020
)
2121
from sentry.preprod.producer import produce_preprod_artifact_to_kafka
22-
from sentry.preprod.vcs.status_checks.tasks import create_preprod_status_check_task
22+
from sentry.preprod.vcs.status_checks.size.tasks import create_preprod_status_check_task
2323
from sentry.silo.base import SiloMode
2424
from sentry.tasks.assemble import (
2525
AssembleResult,

src/sentry/preprod/vcs/status_checks/__init__.py

Whitespace-only changes.

src/sentry/preprod/vcs/status_checks/size/__init__.py

Whitespace-only changes.

src/sentry/preprod/vcs/status_checks/tasks.py renamed to src/sentry/preprod/vcs/status_checks/size/tasks.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
from sentry.models.repository import Repository
2424
from sentry.preprod.models import PreprodArtifact, PreprodArtifactSizeMetrics
2525
from sentry.preprod.url_utils import get_preprod_artifact_url
26-
from sentry.preprod.vcs.status_checks.templates import format_status_check_messages
26+
from sentry.preprod.vcs.status_checks.size.templates import format_status_check_messages
2727
from sentry.silo.base import SiloMode
2828
from sentry.tasks.base import instrumented_task
2929
from sentry.taskworker.config import TaskworkerConfig

tests/sentry/preprod/vcs/status_checks/test_status_checks_tasks.py renamed to tests/sentry/preprod/vcs/status_checks/size/test_status_checks_tasks.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
from sentry.models.commitcomparison import CommitComparison
88
from sentry.models.repository import Repository
99
from sentry.preprod.models import PreprodArtifact
10-
from sentry.preprod.vcs.status_checks.tasks import create_preprod_status_check_task
10+
from sentry.preprod.vcs.status_checks.size.tasks import create_preprod_status_check_task
1111
from sentry.testutils.cases import TestCase
1212
from sentry.testutils.silo import region_silo_test
1313

@@ -79,11 +79,11 @@ def _create_working_status_check_setup(self, preprod_artifact):
7979
mock_provider.create_status_check.return_value = "check_12345"
8080

8181
patcher_client = patch(
82-
"sentry.preprod.vcs.status_checks.tasks._get_status_check_client",
82+
"sentry.preprod.vcs.status_checks.size.tasks._get_status_check_client",
8383
return_value=(mock_client, repository),
8484
)
8585
patcher_provider = patch(
86-
"sentry.preprod.vcs.status_checks.tasks._get_status_check_provider",
86+
"sentry.preprod.vcs.status_checks.size.tasks._get_status_check_provider",
8787
return_value=mock_provider,
8888
)
8989

@@ -95,11 +95,11 @@ def _create_no_api_calls_setup(self):
9595
mock_provider = Mock()
9696

9797
patcher_client = patch(
98-
"sentry.preprod.vcs.status_checks.tasks._get_status_check_client",
98+
"sentry.preprod.vcs.status_checks.size.tasks._get_status_check_client",
9999
return_value=(mock_client, None),
100100
)
101101
patcher_provider = patch(
102-
"sentry.preprod.vcs.status_checks.tasks._get_status_check_provider",
102+
"sentry.preprod.vcs.status_checks.size.tasks._get_status_check_provider",
103103
return_value=mock_provider,
104104
)
105105

tests/sentry/preprod/vcs/status_checks/test_templates.py renamed to tests/sentry/preprod/vcs/status_checks/size/test_templates.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
from sentry.integrations.source_code_management.status_check import StatusCheckStatus
44
from sentry.preprod.models import PreprodArtifact, PreprodArtifactSizeMetrics
5-
from sentry.preprod.vcs.status_checks.templates import format_status_check_messages
5+
from sentry.preprod.vcs.status_checks.size.templates import format_status_check_messages
66
from sentry.testutils.cases import TestCase
77
from sentry.testutils.silo import region_silo_test
88

0 commit comments

Comments
 (0)