Skip to content

Commit 7af686b

Browse files
authored
chore(Android): Re-add Profiling onboarding for Android (#85963)
Profiling has been removed from Android onboarding in #81322 Profiling is now more stable again and via #85337 we now also can choose which features should be selected by default. This PR - re-adds the Profiling feature to Android onboarding as inactive (opt-in) - adds an explainer comment to the Manual setup snippet which is shown when user activates Profiling
1 parent 5eb33e0 commit 7af686b

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

static/app/components/onboarding/productSelection.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ function getDisabledProducts(organization: Organization): DisabledProducts {
7676
// Since the ProductSelection component is rendered in the onboarding/project creation flow only, it is ok to have this list here
7777
// NOTE: Please keep the prefix in alphabetical order
7878
export const platformProductAvailability = {
79-
android: [ProductSolution.PERFORMANCE_MONITORING],
79+
android: [ProductSolution.PERFORMANCE_MONITORING, ProductSolution.PROFILING],
8080
'apple-ios': [ProductSolution.PERFORMANCE_MONITORING, ProductSolution.PROFILING],
8181
'apple-macos': [ProductSolution.PERFORMANCE_MONITORING, ProductSolution.PROFILING],
8282
bun: [ProductSolution.PERFORMANCE_MONITORING],
@@ -198,6 +198,7 @@ export const platformProductAvailability = {
198198
* If not defined in here, all products are selected
199199
*/
200200
const platformDefaultProducts: Partial<Record<PlatformKey, ProductSolution[]>> = {
201+
android: [ProductSolution.PERFORMANCE_MONITORING],
201202
php: [ProductSolution.PERFORMANCE_MONITORING],
202203
'php-laravel': [ProductSolution.PERFORMANCE_MONITORING],
203204
'php-symfony': [ProductSolution.PERFORMANCE_MONITORING],

static/app/gettingStartedDocs/android/android.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,8 @@ const getConfigurationSnippet = (params: Params) => `
8484
params.isProfilingSelected
8585
? `
8686
<!-- enable profiling when starting transactions, adjust in production env -->
87+
<!-- note: there is a known issue in the Android Runtime that can be triggered by Profiling in certain circumstances -->
88+
<!-- see https://docs.sentry.io/platforms/android/profiling/troubleshooting/ -->
8789
<meta-data android:name="io.sentry.traces.profiling.sample-rate" android:value="1.0" />`
8890
: ''
8991
}

0 commit comments

Comments
 (0)