ref(workflow-engine): Delete dead deletion code (#108092)

While auditing delete behavior, noticed that some potentially
problematic code wasn't actually being used, so we remove it.

Author: kcons

src/sentry/workflow_engine/migration_helpers/issue_alert_dual_write.py

@@ -21,10 +21,7 @@
     WorkflowDataConditionGroup,
 )
 from sentry.workflow_engine.models.data_condition import Condition
-from sentry.workflow_engine.processors.workflow import (
-    WorkflowDataConditionGroupType,
-    delete_workflow,
-)
+from sentry.workflow_engine.processors.workflow import WorkflowDataConditionGroupType
 
 logger = logging.getLogger(__name__)
 
@@ -186,26 +183,6 @@ def update_dcg(
     return dcg
 
 
-def delete_migrated_issue_alert(rule: Rule) -> int | None:
-    try:
-        alert_rule_workflow = AlertRuleWorkflow.objects.get(rule_id=rule.id)
-    except AlertRuleWorkflow.DoesNotExist:
-        # OK state, rule may not have been migrated
-        logger.info(
-            "rule was not dual written or objects were already deleted, returning early",
-            extra={"rule_id": rule.id},
-        )
-        return None
-
-    workflow: Workflow = alert_rule_workflow.workflow
-    workflow_id = workflow.id
-
-    delete_workflow(workflow)
-    alert_rule_workflow.delete()
-
-    return workflow_id
-
-
 def delete_workflow_actions(if_dcg: DataConditionGroup) -> None:
     dcg_actions = DataConditionGroupAction.objects.filter(condition_group=if_dcg)
     action_ids = dcg_actions.values_list("action_id", flat=True)

src/sentry/workflow_engine/processors/workflow.py

@@ -5,7 +5,6 @@
 from typing import DefaultDict
 
 import sentry_sdk
-from django.db import router, transaction
 from django.db.models import Q
 
 from sentry import features
@@ -14,13 +13,7 @@
 from sentry.services.eventstore.models import GroupEvent
 from sentry.workflow_engine.buffer.batch_client import DelayedWorkflowClient, DelayedWorkflowItem
 from sentry.workflow_engine.caches.workflow import get_workflows_by_detectors
-from sentry.workflow_engine.models import (
-    Action,
-    DataConditionGroup,
-    Detector,
-    DetectorWorkflow,
-    Workflow,
-)
+from sentry.workflow_engine.models import DataConditionGroup, Detector, DetectorWorkflow, Workflow
 from sentry.workflow_engine.models.data_condition import DataCondition
 from sentry.workflow_engine.models.workflow_data_condition_group import WorkflowDataConditionGroup
 from sentry.workflow_engine.processors.contexts.workflow_event_context import (
@@ -49,32 +42,6 @@ class WorkflowDataConditionGroupType(StrEnum):
     WORKFLOW_TRIGGER = "workflow_trigger"
 
 
-def delete_workflow(workflow: Workflow) -> bool:
-    with transaction.atomic(router.db_for_write(Workflow)):
-        action_filters = DataConditionGroup.objects.filter(
-            workflowdataconditiongroup__workflow=workflow
-        )
-
-        actions = Action.objects.filter(
-            dataconditiongroupaction__condition_group__in=action_filters
-        )
-
-        # Delete the actions associated with a workflow, this is not a cascade delete
-        # because we want to create a UI to maintain notification actions separately
-        if actions:
-            actions.delete()
-
-        if action_filters:
-            action_filters.delete()
-
-        if workflow.when_condition_group:
-            workflow.when_condition_group.delete()
-
-        workflow.delete()
-
-    return True
-
-
 @scopedstats.timer()
 def enqueue_workflows(
     client: DelayedWorkflowClient,

tests/sentry/workflow_engine/migration_helpers/test_issue_alert_dual_write.py

@@ -21,7 +21,6 @@
 from sentry.testutils.cases import TestCase
 from sentry.testutils.helpers import install_slack
 from sentry.workflow_engine.migration_helpers.issue_alert_dual_write import (
-    delete_migrated_issue_alert,
     update_migrated_issue_alert,
 )
 from sentry.workflow_engine.models import (
@@ -368,11 +367,6 @@ def assert_issue_alert_deleted(
         assert not DataConditionGroupAction.objects.filter(condition_group=if_dcg).exists()
         assert not Action.objects.all().exists()
 
-    def test_delete_issue_alert(self) -> None:
-        delete_migrated_issue_alert(self.issue_alert)
-
-        self.assert_issue_alert_deleted(self.workflow, self.when_dcg, self.if_dcg)
-
     def test_delete_issue_alert__rule_deletion_task(self) -> None:
         self.issue_alert.update(status=ObjectStatus.PENDING_DELETION)
         RegionScheduledDeletion.schedule(self.issue_alert, days=0)

tests/sentry/workflow_engine/processors/test_workflow.py

@@ -1,7 +1,6 @@
 from datetime import timedelta
 from unittest.mock import MagicMock, Mock, patch
 
-import pytest
 from django.utils import timezone
 
 from sentry.eventstream.base import GroupState
@@ -10,20 +9,13 @@
 from sentry.models.activity import Activity
 from sentry.models.environment import Environment
 from sentry.services.eventstore.models import GroupEvent
-from sentry.testutils.factories import Factories
 from sentry.testutils.helpers.datetime import before_now, freeze_time
 from sentry.testutils.helpers.features import with_feature
-from sentry.testutils.pytest.fixtures import django_db_all
 from sentry.types.activity import ActivityType
 from sentry.utils import json
 from sentry.utils.cache import cache
 from sentry.workflow_engine.buffer.batch_client import DelayedWorkflowClient, DelayedWorkflowItem
-from sentry.workflow_engine.models import (
-    Action,
-    DataConditionGroup,
-    DataConditionGroupAction,
-    Workflow,
-)
+from sentry.workflow_engine.models import DataConditionGroup
 from sentry.workflow_engine.models.data_condition import Condition
 from sentry.workflow_engine.models.workflow_fire_history import WorkflowFireHistory
 from sentry.workflow_engine.processors.contexts.workflow_event_context import (
@@ -32,7 +24,6 @@
 )
 from sentry.workflow_engine.processors.data_condition_group import get_data_conditions_for_group
 from sentry.workflow_engine.processors.workflow import (
-    delete_workflow,
     enqueue_workflows,
     evaluate_workflow_triggers,
     evaluate_workflows_action_filters,
@@ -1148,83 +1139,3 @@ def test_enqueue_workflow__adds_to_workflow_engine_set(self) -> None:
                 )
             },
         )
-
-
-@django_db_all
-class TestDeleteWorkflow:
-    @pytest.fixture(autouse=True)
-    def setUp(self) -> None:
-        self.organization = Factories.create_organization()
-        self.project = Factories.create_project(organization=self.organization)
-
-        self.workflow = Factories.create_workflow()
-        self.workflow_trigger = Factories.create_data_condition_group(
-            organization=self.organization
-        )
-        self.workflow.when_condition_group = self.workflow_trigger
-        self.workflow.save()
-
-        self.action_filter = Factories.create_data_condition_group(organization=self.organization)
-        self.action = Factories.create_action()
-        self.action_and_filter = Factories.create_data_condition_group_action(
-            condition_group=self.action_filter,
-            action=self.action,
-        )
-
-        self.workflow_actions = Factories.create_workflow_data_condition_group(
-            workflow=self.workflow,
-            condition_group=self.action_filter,
-        )
-
-        self.trigger_condition = Factories.create_data_condition(
-            condition_group=self.workflow_trigger,
-            comparison=1,
-            condition_result=True,
-        )
-
-        self.action_condition = Factories.create_data_condition(
-            condition_group=self.action_filter,
-            comparison=1,
-            condition_result=True,
-        )
-
-    @pytest.mark.parametrize(
-        "instance_attr",
-        [
-            "workflow",
-            "workflow_trigger",
-            "action_filter",
-            "action_and_filter",
-            "workflow_actions",
-            "trigger_condition",
-            "action_condition",
-        ],
-    )
-    def test_delete_workflow(self, instance_attr: str) -> None:
-        instance = getattr(self, instance_attr)
-        instance_id = instance.id
-        cls = instance.__class__
-
-        delete_workflow(self.workflow)
-        assert not cls.objects.filter(id=instance_id).exists()
-
-    def test_delete_workflow__no_actions(self) -> None:
-        Action.objects.get(id=self.action.id).delete()
-        assert not DataConditionGroupAction.objects.filter(id=self.action_and_filter.id).exists()
-
-        workflow_id = self.workflow.id
-        delete_workflow(self.workflow)
-
-        assert not Workflow.objects.filter(id=workflow_id).exists()
-
-    def test_delete_workflow__no_workflow_triggers(self) -> None:
-        # TODO - when this condition group is deleted, it's removing the workflow
-        # it's basically inverted from what's expected on the cascade delete
-        self.workflow.when_condition_group = None
-        self.workflow.save()
-
-        DataConditionGroup.objects.get(id=self.workflow_trigger.id).delete()
-
-        workflow_id = self.workflow.id
-        delete_workflow(self.workflow)
-        assert not Workflow.objects.filter(id=workflow_id).exists()