Handle GroupMeta in bulk project delete

Author: dcramer

src/sentry/tasks/deletion.py

@@ -93,7 +93,7 @@ def delete_project(object_id, continuous=True, **kwargs):
     from sentry.models import (
         Project, ProjectKey, ProjectStatus, TagKey, TagValue, GroupTagKey,
         GroupTagValue, Activity, EventMapping, Group, GroupEmailThread,
-        GroupRuleStatus, GroupHash, GroupSeen, UserReport
+        GroupRuleStatus, GroupHash, GroupMeta, GroupSeen, UserReport
     )
 
     try:
@@ -121,6 +121,15 @@ def delete_project(object_id, continuous=True, **kwargs):
                 delete_project.delay(object_id=object_id, countdown=15)
             return
 
+    # TODO(dcramer): GroupMeta has no project relation so we cant easily bulk
+    # delete today
+    has_more = delete_objects([GroupMeta], relation={'group__project': p},
+                              logger=logger)
+    if has_more:
+        if continuous:
+            delete_project.delay(object_id=object_id, countdown=15)
+        return
+
     has_more = delete_events(relation={'project_id': p.id}, logger=logger)
     if has_more:
         if continuous:

tests/sentry/tasks/test_deletion.py

@@ -4,8 +4,8 @@
 
 from sentry.exceptions import DeleteAborted
 from sentry.models import (
-    GroupTagKey, GroupTagValue, Organization, OrganizationStatus, Project,
-    ProjectStatus, TagKey, TagValue, Team, TeamStatus
+    GroupMeta, GroupTagKey, GroupTagValue, Organization, OrganizationStatus,
+    Project, ProjectStatus, TagKey, TagValue, Team, TeamStatus
 )
 from sentry.tasks.deletion import (
     delete_organization, delete_project, delete_tag_key, delete_team
@@ -77,6 +77,8 @@ def test_simple(self):
             name='test',
             status=ProjectStatus.PENDING_DELETION,
         )
+        group = self.create_group(project=project)
+        GroupMeta.objects.create(group=group, key='foo', value='bar')
 
         with self.tasks():
             delete_project(object_id=project.id)