Skip to content

Commit 80e576d

Browse files
Revert "feat(replays): Replay layout move start time (#58488)"
This reverts commit 13f2e6b. Co-authored-by: asottile-sentry <[email protected]>
1 parent 7f6fe45 commit 80e576d

File tree

2 files changed

+31
-26
lines changed

2 files changed

+31
-26
lines changed

static/app/components/replays/header/replayMetaData.tsx

Lines changed: 2 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,7 @@ import styled from '@emotion/styled';
33

44
import ErrorCounts from 'sentry/components/replays/header/errorCounts';
55
import HeaderPlaceholder from 'sentry/components/replays/header/headerPlaceholder';
6-
import TimeSince from 'sentry/components/timeSince';
7-
import {IconCalendar, IconCursorArrow} from 'sentry/icons';
6+
import {IconCursorArrow} from 'sentry/icons';
87
import {t} from 'sentry/locale';
98
import {space} from 'sentry/styles/space';
109
import EventView from 'sentry/utils/discover/eventView';
@@ -38,22 +37,6 @@ function ReplayMetaData({replayErrors, replayRecord}: Props) {
3837

3938
return (
4039
<KeyMetrics>
41-
<KeyMetricLabel>{t('Start Time')}</KeyMetricLabel>
42-
<KeyMetricData>
43-
{replayRecord ? (
44-
<TimeContainer>
45-
<IconCalendar color="gray300" size="sm" />
46-
<TimeSince
47-
date={replayRecord.started_at}
48-
isTooltipHoverable
49-
unitStyle="regular"
50-
/>
51-
</TimeContainer>
52-
) : (
53-
<HeaderPlaceholder width="80px" height="16px" />
54-
)}
55-
</KeyMetricData>
56-
5740
<KeyMetricLabel>{t('Dead Clicks')}</KeyMetricLabel>
5841
<KeyMetricData>
5942
{replayRecord?.count_dead_clicks ? (
@@ -97,7 +80,7 @@ function ReplayMetaData({replayErrors, replayRecord}: Props) {
9780
const KeyMetrics = styled('dl')`
9881
display: grid;
9982
grid-template-rows: max-content 1fr;
100-
grid-template-columns: repeat(5, max-content);
83+
grid-template-columns: repeat(4, max-content);
10184
grid-auto-flow: column;
10285
gap: 0 ${space(3)};
10386
align-items: center;
@@ -134,10 +117,4 @@ const ClickCount = styled(Count)<{color: ColorOrAlias}>`
134117
align-items: center;
135118
`;
136119

137-
const TimeContainer = styled('div')`
138-
display: flex;
139-
gap: ${space(1)};
140-
align-items: center;
141-
`;
142-
143120
export default ReplayMetaData;

static/app/views/replays/detail/page.tsx

Lines changed: 29 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ import HeaderPlaceholder from 'sentry/components/replays/header/headerPlaceholde
1111
import ReplayMetaData from 'sentry/components/replays/header/replayMetaData';
1212
import ShareButton from 'sentry/components/replays/shareButton';
1313
import SentryDocumentTitle from 'sentry/components/sentryDocumentTitle';
14+
import TimeSince from 'sentry/components/timeSince';
15+
import {IconCalendar} from 'sentry/icons';
1416
import {t} from 'sentry/locale';
1517
import {space} from 'sentry/styles/space';
1618
import type {ReplayError, ReplayRecord} from 'sentry/views/replays/types';
@@ -59,7 +61,23 @@ function Page({children, orgSlug, replayRecord, projectSlug, replayErrors}: Prop
5961
ip_address: replayRecord.user.ip || '',
6062
id: replayRecord.user.id || '',
6163
}}
62-
hideEmail
64+
// this is the subheading for the avatar, so displayEmail in this case is a misnomer
65+
displayEmail={
66+
<div>
67+
{replayRecord ? (
68+
<TimeContainer>
69+
<IconCalendar color="gray300" size="xs" />
70+
<StyledTimeSince
71+
date={replayRecord.started_at}
72+
isTooltipHoverable
73+
unitStyle="regular"
74+
/>
75+
</TimeContainer>
76+
) : (
77+
<HeaderPlaceholder width="80px" height="16px" />
78+
)}
79+
</div>
80+
}
6381
/>
6482
) : (
6583
<HeaderPlaceholder width="100%" height="58px" />
@@ -98,4 +116,14 @@ const ButtonActionsWrapper = styled(Layout.HeaderActions)`
98116
}
99117
`;
100118

119+
const TimeContainer = styled('div')`
120+
display: flex;
121+
gap: ${space(0.5)};
122+
align-items: center;
123+
`;
124+
125+
const StyledTimeSince = styled(TimeSince)`
126+
font-size: ${p => p.theme.fontSizeMedium};
127+
`;
128+
101129
export default Page;

0 commit comments

Comments
 (0)