ref(dx): Move nodestore to services (#97715)

Author: evanpurkhiser

pyproject.toml

@@ -516,7 +516,6 @@ module = [
     "sentry.monitors.consumers.monitor_consumer",
     "sentry.monkey.*",
     "sentry.net.socket",
-    "sentry.nodestore.*",
     "sentry.notifications.platform.*",
     "sentry.notifications.services.*",
     "sentry.options.rollout",
@@ -559,6 +558,7 @@ module = [
     "sentry.services.eventstore.processing.*",
     "sentry.services.eventstore.reprocessing.*",
     "sentry.services.eventstore.snuba.backend",
+    "sentry.services.nodestore.*",
     "sentry.shared_integrations.exceptions.*",
     "sentry.slug.*",
     "sentry.snuba.metrics.extraction",
@@ -725,7 +725,6 @@ module = [
     "tests.sentry.middleware.test_reporting_endpoint",
     "tests.sentry.models.fixtures.*",
     "tests.sentry.net.*",
-    "tests.sentry.nodestore.*",
     "tests.sentry.notifications.notification_action.metric_alert_registry.*",
     "tests.sentry.notifications.notifications.organization_request.*",
     "tests.sentry.notifications.platform.*",
@@ -768,6 +767,7 @@ module = [
     "tests.sentry.sentry_apps.web.*",
     "tests.sentry.services.eventstore.processing.*",
     "tests.sentry.services.eventstore.snuba.*",
+    "tests.sentry.services.nodestore.*",
     "tests.sentry.snuba.metrics.test_metrics_query_layer.*",
     "tests.sentry.tasks.integrations.*",
     "tests.sentry.tasks.snapshots.*",

src/sentry/app.py

@@ -35,6 +35,6 @@ def active_request(self, request: HttpRequest) -> Generator[None]:
 from sentry.buffer import backend as buffer  # NOQA
 from sentry.digests import backend as digests  # NOQA
 from sentry.locks import locks  # NOQA
-from sentry.nodestore import backend as nodestore  # NOQA
 from sentry.quotas import backend as quotas  # NOQA
 from sentry.ratelimits import backend as ratelimiter  # NOQA
+from sentry.services.nodestore import backend as nodestore  # NOQA

src/sentry/backup/imports.py

@@ -41,7 +41,7 @@
 from sentry.hybridcloud.outbox.category import OutboxCategory, OutboxScope
 from sentry.models.importchunk import ControlImportChunkReplica
 from sentry.models.orgauthtoken import OrgAuthToken
-from sentry.nodestore.django.models import Node
+from sentry.services.nodestore.django.models import Node
 from sentry.silo.base import SiloMode
 from sentry.silo.safety import unguarded_write
 from sentry.utils.env import is_split_db

src/sentry/conf/server.py

@@ -404,7 +404,7 @@ def env(
     "sentry.deletions",
     "sentry.discover",
     "sentry.analytics.events",
-    "sentry.nodestore",
+    "sentry.services.nodestore",
     "sentry.users",
     "sentry.sentry_apps",
     "sentry.integrations",
@@ -2164,7 +2164,7 @@ def custom_parameter_sort(parameter: dict) -> tuple[str, int]:
 SENTRY_SNUBA_CACHE_TTL_SECONDS = 60
 
 # Node storage backend
-SENTRY_NODESTORE = "sentry.nodestore.django.DjangoNodeStorage"
+SENTRY_NODESTORE = "sentry.services.nodestore.django.DjangoNodeStorage"
 SENTRY_NODESTORE_OPTIONS: dict[str, Any] = {}
 
 # Tag storage backend

src/sentry/nodestore/__init__.py

@@ -1,13 +1,10 @@
-from django.conf import settings
+"""
+Backward compatibility shim for getsentry.
 
-from sentry.utils.services import LazyServiceWrapper
+This module re-exports everything from the new sentry.services.nodestore location
+to maintain compatibility with existing getsentry imports.
+"""
 
-from .base import NodeStorage
-
-backend = LazyServiceWrapper(
-    NodeStorage,
-    settings.SENTRY_NODESTORE,
-    settings.SENTRY_NODESTORE_OPTIONS,
-    metrics_path="nodestore",
-)
-backend.expose(locals())
+# Re-export everything from the new location
+from sentry.services.nodestore import *  # noqa: F401, F403
+from sentry.services.nodestore import backend  # noqa: F401