Skip to content

Commit 83c64c9

Browse files
committed
chore(logs): Remove ourlogs-high-fidelity feature flag backend
This feature has been rolled out so we can delete the flag now. Depends on #104016
1 parent c3e99bb commit 83c64c9

File tree

3 files changed

+3
-19
lines changed

3 files changed

+3
-19
lines changed

src/sentry/api/bases/organization_events.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -163,12 +163,6 @@ def get_snuba_params(
163163
sampling_mode = cast(SAMPLING_MODES, sampling_mode.upper())
164164
sentry_sdk.set_tag("sampling_mode", sampling_mode)
165165

166-
# kill switch: disable the highest accuracy flex time strategy to avoid hammering snuba
167-
if sampling_mode == "HIGHEST_ACCURACY_FLEX_TIME" and not features.has(
168-
"organizations:ourlogs-high-fidelity", organization, actor=request.user
169-
):
170-
raise ParseError(f"sampling mode: {sampling_mode} is not supported")
171-
172166
if quantize_date_params:
173167
filter_params = self.quantize_date_params(request, filter_params)
174168
params = SnubaParams(

src/sentry/features/temporary.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -585,8 +585,6 @@ def register_temporary_features(manager: FeatureManager) -> None:
585585
manager.add("organizations:ourlogs-tags-ui", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
586586
# Enable service hooks outbox
587587
manager.add("organizations:service-hooks-outbox", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=False)
588-
# Enable UI for log high fidelity queries
589-
manager.add("organizations:ourlogs-high-fidelity", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
590588
# Enable alerting on trace metrics
591589
manager.add("organizations:tracemetrics-alerts", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
592590
# Enable trace metrics in dashboards UI

tests/snuba/api/endpoints/test_organization_events_ourlogs.py

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -562,7 +562,6 @@ def test_high_accuracy_flex_time_filter_trace(self):
562562
"dataset": self.dataset,
563563
"sampling": "HIGHEST_ACCURACY_FLEX_TIME",
564564
},
565-
features={"organizations:ourlogs-high-fidelity": True},
566565
)
567566
assert response.status_code == 200, response.content
568567

@@ -601,7 +600,6 @@ def test_high_accuracy_flex_time_order_by_timestamp(self):
601600
"dataset": self.dataset,
602601
"sampling": "HIGHEST_ACCURACY_FLEX_TIME",
603602
},
604-
features={"organizations:ourlogs-high-fidelity": True},
605603
)
606604
assert response.status_code == 200, response.content
607605

@@ -616,7 +614,6 @@ def test_high_accuracy_flex_time_empty_page_no_next(self):
616614
"dataset": self.dataset,
617615
"sampling": "HIGHEST_ACCURACY_FLEX_TIME",
618616
},
619-
features={"organizations:ourlogs-high-fidelity": True},
620617
)
621618

622619
assert response.status_code == 200, response.content
@@ -647,7 +644,6 @@ def test_high_accuracy_flex_time_partial_page_no_next(self):
647644
"sampling": "HIGHEST_ACCURACY_FLEX_TIME",
648645
"per_page": 10,
649646
},
650-
features={"organizations:ourlogs-high-fidelity": True},
651647
)
652648

653649
assert response.status_code == 200, response.content
@@ -680,7 +676,6 @@ def test_high_accuracy_flex_time_full_page_no_next(self):
680676
"sampling": "HIGHEST_ACCURACY_FLEX_TIME",
681677
"per_page": 5,
682678
},
683-
features={"organizations:ourlogs-high-fidelity": True},
684679
)
685680

686681
assert response.status_code == 200, response.content
@@ -715,7 +710,7 @@ def test_high_accuracy_flex_time_full_page_with_next(self):
715710
"per_page": 5,
716711
}
717712

718-
response = self.do_request(request, features={"organizations:ourlogs-high-fidelity": True})
713+
response = self.do_request(request)
719714

720715
assert response.status_code == 200, response.content
721716
assert [row["message"] for row in response.data["data"]] == [
@@ -731,7 +726,6 @@ def test_high_accuracy_flex_time_full_page_with_next(self):
731726

732727
response = self.do_request(
733728
{**request, "cursor": links["next"]["cursor"]},
734-
features={"organizations:ourlogs-high-fidelity": True},
735729
)
736730

737731
assert response.status_code == 200, response.content
@@ -801,7 +795,7 @@ def test_high_accuracy_flex_time_partial_page_with_next(self):
801795
"end": hour_4.isoformat(),
802796
}
803797

804-
response = self.do_request(request, features={"organizations:ourlogs-high-fidelity": True})
798+
response = self.do_request(request)
805799

806800
assert response.status_code == 200, response.content
807801
assert [row["message"] for row in response.data["data"]] == ["log 1"]
@@ -815,7 +809,6 @@ def test_high_accuracy_flex_time_partial_page_with_next(self):
815809

816810
response = self.do_request(
817811
{**request, "cursor": links["next"]["cursor"]},
818-
features={"organizations:ourlogs-high-fidelity": True},
819812
)
820813

821814
assert response.status_code == 200, response.content
@@ -878,7 +871,7 @@ def test_high_accuracy_flex_time_empty_page_with_next(self):
878871
"end": hour_4.isoformat(),
879872
}
880873

881-
response = self.do_request(request, features={"organizations:ourlogs-high-fidelity": True})
874+
response = self.do_request(request)
882875

883876
assert response.status_code == 200, response.content
884877
assert response.data["data"] == []
@@ -892,7 +885,6 @@ def test_high_accuracy_flex_time_empty_page_with_next(self):
892885

893886
response = self.do_request(
894887
{**request, "cursor": links["next"]["cursor"]},
895-
features={"organizations:ourlogs-high-fidelity": True},
896888
)
897889

898890
assert response.status_code == 200, response.content

0 commit comments

Comments
 (0)