ref(crons): Remove issue_platform module (#97710)

This has been (mostly) been replaced with detectors

Author: evanpurkhiser

src/sentry/uptime/grouptype.py

@@ -11,7 +11,9 @@
 from sentry import features, options
 from sentry.issues.grouptype import GroupCategory, GroupType
 from sentry.issues.issue_occurrence import IssueEvidence, IssueOccurrence
+from sentry.issues.producer import PayloadType, produce_occurrence_to_kafka
 from sentry.issues.status_change_message import StatusChangeMessage
+from sentry.models.group import GroupStatus
 from sentry.ratelimits.sliding_windows import Quota
 from sentry.types.group import PriorityLevel
 from sentry.uptime.models import UptimeStatus, UptimeSubscription, get_project_subscription
@@ -34,6 +36,23 @@
 logger = logging.getLogger(__name__)
 
 
+def resolve_uptime_issue(detector: Detector):
+    """
+    Sends an update to the issue platform to resolve the uptime issue for this
+    monitor.
+    """
+    status_change = StatusChangeMessage(
+        fingerprint=build_fingerprint(detector),
+        project_id=detector.project_id,
+        new_status=GroupStatus.RESOLVED,
+        new_substatus=None,
+    )
+    produce_occurrence_to_kafka(
+        payload_type=PayloadType.STATUS_CHANGE,
+        status_change=status_change,
+    )
+
+
 @dataclass(frozen=True)
 class UptimePacketValue:
     """

src/sentry/uptime/issue_platform.py

@@ -11,8 +11,7 @@
 from sentry.quotas.base import SeatAssignmentResult
 from sentry.types.actor import Actor
 from sentry.uptime.detectors.url_extraction import extract_domain_parts
-from sentry.uptime.grouptype import UptimeDomainCheckFailure
-from sentry.uptime.issue_platform import resolve_uptime_issue
+from sentry.uptime.grouptype import UptimeDomainCheckFailure, resolve_uptime_issue
 from sentry.uptime.models import (
     ProjectUptimeSubscription,
     UptimeStatus,

src/sentry/uptime/subscriptions/subscriptions.py

@@ -1,4 +1,3 @@
-from hashlib import md5
 from unittest import mock
 
 import pytest
@@ -9,14 +8,12 @@
 from sentry.conf.types.uptime import UptimeRegionConfig
 from sentry.constants import DataCategory, ObjectStatus
 from sentry.deletions.tasks.scheduled import run_scheduled_deletions
-from sentry.models.group import Group, GroupStatus
 from sentry.quotas.base import SeatAssignmentResult
 from sentry.testutils.cases import UptimeTestCase
 from sentry.testutils.helpers import override_options
 from sentry.testutils.skips import requires_kafka
 from sentry.types.actor import Actor
-from sentry.uptime.grouptype import UptimeDomainCheckFailure, build_detector_fingerprint_component
-from sentry.uptime.issue_platform import create_issue_platform_occurrence
+from sentry.uptime.grouptype import UptimeDomainCheckFailure
 from sentry.uptime.models import (
     ProjectUptimeSubscription,
     UptimeStatus,
@@ -770,7 +767,8 @@ def test(self, mock_disable_seat: mock.MagicMock) -> None:
         assert not detector.enabled
 
     @mock.patch("sentry.quotas.backend.disable_seat")
-    def test_disable_failed(self, mock_disable_seat: mock.MagicMock) -> None:
+    @mock.patch("sentry.uptime.subscriptions.subscriptions.resolve_uptime_issue")
+    def test_disable_failed(self, mock_resolve_uptime_issue, mock_disable_seat) -> None:
         with (
             self.tasks(),
             self.feature(UptimeDomainCheckFailure.build_ingest_feature_name()),
@@ -786,21 +784,8 @@ def test_disable_failed(self, mock_disable_seat: mock.MagicMock) -> None:
             )
             detector = get_detector(proj_sub.uptime_subscription)
 
-            create_issue_platform_occurrence(
-                self.create_uptime_result(
-                    subscription_id=proj_sub.uptime_subscription.subscription_id
-                ),
-                detector,
-            )
-            fingerprint = build_detector_fingerprint_component(detector).encode("utf-8")
-            hashed_fingerprint = md5(fingerprint).hexdigest()
-            assert Group.objects.filter(
-                grouphash__hash=hashed_fingerprint, status=GroupStatus.UNRESOLVED
-            ).exists()
             disable_uptime_detector(detector)
-            assert Group.objects.filter(
-                grouphash__hash=hashed_fingerprint, status=GroupStatus.RESOLVED
-            ).exists()
+            mock_resolve_uptime_issue.assert_called_with(detector)
 
         proj_sub.refresh_from_db()
         assert proj_sub.status == ObjectStatus.DISABLED

tests/sentry/uptime/subscriptions/test_subscriptions.py

@@ -1,4 +1,6 @@
-from datetime import datetime, timedelta
+import uuid
+from datetime import datetime, timedelta, timezone
+from hashlib import md5
 from itertools import cycle
 from unittest import mock
 
@@ -12,6 +14,8 @@
 )
 
 from sentry.issues.issue_occurrence import IssueEvidence, IssueOccurrence
+from sentry.issues.producer import PayloadType, produce_occurrence_to_kafka
+from sentry.models.group import Group, GroupStatus
 from sentry.testutils.cases import TestCase, UptimeTestCase
 from sentry.testutils.helpers.datetime import freeze_time
 from sentry.uptime.grouptype import (
@@ -22,6 +26,7 @@
     build_event_data,
     build_evidence_display,
     build_fingerprint,
+    resolve_uptime_issue,
 )
 from sentry.uptime.models import UptimeStatus, UptimeSubscription, get_detector
 from sentry.uptime.types import UptimeMonitorMode
@@ -30,6 +35,52 @@
 from sentry.workflow_engine.types import DetectorPriorityLevel
 
 
+class ResolveUptimeIssueTest(UptimeTestCase):
+    def test(self):
+        subscription = self.create_uptime_subscription(subscription_id=uuid.uuid4().hex)
+        self.create_project_uptime_subscription(uptime_subscription=subscription)
+        detector = get_detector(subscription)
+        result = self.create_uptime_result(subscription.subscription_id)
+
+        fingerprint = build_detector_fingerprint_component(detector)
+
+        with self.feature(UptimeDomainCheckFailure.build_ingest_feature_name()):
+            occurrence = IssueOccurrence(
+                id=uuid.uuid4().hex,
+                resource_id=None,
+                project_id=detector.project_id,
+                event_id=uuid.uuid4().hex,
+                fingerprint=[fingerprint],
+                type=UptimeDomainCheckFailure,
+                issue_title=f"Downtime detected for {subscription.url}",
+                subtitle="Your monitored domain is down",
+                evidence_display=[],
+                evidence_data={},
+                culprit="",
+                detection_time=datetime.now(timezone.utc),
+                level="error",
+                assignee=detector.owner,
+            )
+            produce_occurrence_to_kafka(
+                payload_type=PayloadType.OCCURRENCE,
+                occurrence=occurrence,
+                event_data={
+                    **build_event_data(result, detector),
+                    "event_id": occurrence.event_id,
+                    "fingerprint": occurrence.fingerprint,
+                    "timestamp": occurrence.detection_time.isoformat(),
+                },
+            )
+
+        hashed_detector_fingerprint = md5(fingerprint.encode("utf-8")).hexdigest()
+        group_detector = Group.objects.get(grouphash__hash=hashed_detector_fingerprint)
+        assert group_detector.status == GroupStatus.UNRESOLVED
+
+        resolve_uptime_issue(detector)
+        group_detector.refresh_from_db()
+        assert group_detector.status == GroupStatus.RESOLVED
+
+
 class BuildDetectorFingerprintComponentTest(UptimeTestCase):
     def test_build_detector_fingerprint_component(self) -> None:
         project_subscription = self.create_project_uptime_subscription()