update tests

Author: ceorourke

src/sentry/incidents/subscription_processor.py

@@ -1,4 +1,3 @@
-
 from __future__ import annotations
 
 import logging
@@ -515,6 +514,9 @@ def process_update(self, subscription_update: QuerySubscriptionUpdate) -> None:
                     results = self.process_results_workflow_engine(
                         subscription_update, aggregation_value, organization
                     )
+            else:
+                # XXX: after we fully migrate to single processing we can return early here like line 545
+                metrics.incr("incidents.alert_rules.skipping_update_invalid_aggregation_value")
 
             if has_metric_issue_single_processing:
                 # don't go through the legacy system
@@ -539,7 +541,6 @@ def process_update(self, subscription_update: QuerySubscriptionUpdate) -> None:
                     return
 
             if aggregation_value is None:
-                metrics.incr("incidents.alert_rules.skipping_update_invalid_aggregation_value")
                 return
 
             fired_incident_triggers: list[IncidentTrigger] = []

tests/sentry/incidents/subscription_processor/test_subscription_processor_base.py

@@ -210,12 +210,14 @@ def send_update(self, value, time_delta=None, subscription=None):
             processor.process_update(message)
         return processor
 
-    # assert active incident: assert that open period exists
-    # which means occurrence created, open period for its group, date_ended is null
-    # query for occurrence evidence_data["detector_id"] == self.detector.id?
-    # wait but we can't even filter. sigh.
-    # I guess I can check the detector status. ugh.
-    # I can also check that there's no open periods for the *project*, but idk how helpful that is
+    def assert_no_open_period(self, rule, subscription=None):
+        # TODO: inverse of below
+        pass
+
+    def assert_open_period(self, rule, subscription=None):
+        # TODO: once we are writing to IncidentGroupOpenPeriod look up the GroupOpenPeriod
+        pass
+
     def get_detector_state(self, detector: Detector) -> DetectorPriorityLevel:
         detector_state = DetectorState.objects.get(detector=detector)
         return int(detector_state.state)