Skip to content

Commit 8bd2e17

Browse files
michellewzhangandrewshie-sentry
authored andcommitted
fix(replay): fix feedback replay context not resetting (#98757)
closes https://linear.app/getsentry/issue/REPLAY-129/replay-previewer-buggy-when-viewing-a-played-video Fixes the issue where the `currentTime` was getting mutated when navigating between different feedback replay previews. This change will force the entire lazy-loaded component tree (including the `ReplayContextProvider`) to completely re-mount whenever the `replayId` changes. This includes resetting the `ReplayContextProvider` state, which contains the `currentTime` that was getting corrupted. before: https://github.com/user-attachments/assets/f78e39ce-5554-4933-9932-87f7652c5d69 after: https://github.com/user-attachments/assets/86b03077-1855-430a-b379-39ef25535d6c
1 parent 995194c commit 8bd2e17

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

static/app/components/feedback/feedbackItem/replaySection.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ export default function ReplaySection({eventTimestampMs, organization, replayId}
3737

3838
return (
3939
<LazyLoad
40+
key={replayId}
4041
{...props}
4142
LazyComponent={LazyReplayClipPreviewComponent}
4243
clipOffsets={CLIP_OFFSETS}

0 commit comments

Comments
 (0)