ref(ui) Move forms out of views/settings/components (#31785)

Move the undeprecated forms library out of views/settings and into
components/. This better reflects how we use form components in the
application and gives shorter import paths everywhere.

Author: markstory

docs-ui/stories/assets/icons/popper.tsx

@@ -4,8 +4,8 @@ import styled from '@emotion/styled';
 import Code from 'docs-ui/components/code';
 
 import SelectField from 'sentry/components/deprecatedforms/selectField';
+import BooleanField from 'sentry/components/forms/booleanField';
 import space from 'sentry/styles/space';
-import BooleanField from 'sentry/views/settings/components/forms/booleanField';
 
 import {iconProps} from './data';
 import IconSample from './sample';

docs-ui/stories/components/form-fields.stories.js

@@ -1,21 +1,21 @@
 import {action} from '@storybook/addon-actions';
 
-import FileField from 'app/views/settings/components/forms/fileField';
+import FileField from 'app/components/forms/fileField';
+import NewBooleanField from 'sentry/components/forms/booleanField';
+import CheckboxField from 'sentry/components/forms/checkboxField';
+import RadioGroup from 'sentry/components/forms/controls/radioGroup';
+import RangeSlider from 'sentry/components/forms/controls/rangeSlider';
+import DatePickerField from 'sentry/components/forms/datePickerField';
+import Form from 'sentry/components/forms/form';
+import FormField from 'sentry/components/forms/formField';
+import RadioBooleanField from 'sentry/components/forms/radioBooleanField';
+import RadioField from 'sentry/components/forms/radioField';
+import SelectField from 'sentry/components/forms/selectField';
+import TextareaField from 'sentry/components/forms/textareaField';
+import TextCopyInput from 'sentry/components/forms/textCopyInput';
+import TextField from 'sentry/components/forms/textField';
 import {Panel} from 'sentry/components/panels';
 import Switch from 'sentry/components/switchButton';
-import NewBooleanField from 'sentry/views/settings/components/forms/booleanField';
-import CheckboxField from 'sentry/views/settings/components/forms/checkboxField';
-import RadioGroup from 'sentry/views/settings/components/forms/controls/radioGroup';
-import RangeSlider from 'sentry/views/settings/components/forms/controls/rangeSlider';
-import DatePickerField from 'sentry/views/settings/components/forms/datePickerField';
-import Form from 'sentry/views/settings/components/forms/form';
-import FormField from 'sentry/views/settings/components/forms/formField';
-import RadioBooleanField from 'sentry/views/settings/components/forms/radioBooleanField';
-import RadioField from 'sentry/views/settings/components/forms/radioField';
-import SelectField from 'sentry/views/settings/components/forms/selectField';
-import TextareaField from 'sentry/views/settings/components/forms/textareaField';
-import TextCopyInput from 'sentry/views/settings/components/forms/textCopyInput';
-import TextField from 'sentry/views/settings/components/forms/textField';
 
 export default {
   title: 'Components/Forms/Fields',

docs-ui/stories/components/form.stories.js

@@ -1,9 +1,9 @@
-import NewBooleanField from 'sentry/views/settings/components/forms/booleanField';
-import Form from 'sentry/views/settings/components/forms/form';
-import RadioField from 'sentry/views/settings/components/forms/radioField';
-import RangeField from 'sentry/views/settings/components/forms/rangeField';
-import SelectField from 'sentry/views/settings/components/forms/selectField';
-import TextField from 'sentry/views/settings/components/forms/textField';
+import NewBooleanField from 'sentry/components/forms/booleanField';
+import Form from 'sentry/components/forms/form';
+import RadioField from 'sentry/components/forms/radioField';
+import RangeField from 'sentry/components/forms/rangeField';
+import SelectField from 'sentry/components/forms/selectField';
+import TextField from 'sentry/components/forms/textField';
 
 export default {
   title: 'Components/Forms/Form',

docs-ui/stories/components/multipleCheckbox.stories.js

@@ -1,6 +1,6 @@
 import {action} from '@storybook/addon-actions';
 
-import MultipleCheckbox from 'sentry/views/settings/components/forms/controls/multipleCheckbox';
+import MultipleCheckbox from 'sentry/components/forms/controls/multipleCheckbox';
 
 export default {
   title: 'Components/Forms/Controls/Multiple Checkbox',

docs-ui/stories/components/panels.stories.js

@@ -1,6 +1,7 @@
 import {Fragment} from 'react';
 
 import Button from 'sentry/components/button';
+import Field from 'sentry/components/forms/field';
 import {
   Panel,
   PanelAlert,
@@ -10,7 +11,6 @@ import {
   PanelTable,
 } from 'sentry/components/panels';
 import {IconTelescope} from 'sentry/icons';
-import Field from 'sentry/views/settings/components/forms/field';
 
 import {_BulkController} from './bulkController.stories';
 

docs-ui/stories/components/rangeSlider.stories.js

@@ -1,6 +1,6 @@
 import {Fragment} from 'react';
 
-import RangeSlider from 'sentry/views/settings/components/forms/controls/rangeSlider';
+import RangeSlider from 'sentry/components/forms/controls/rangeSlider';
 
 export default {
   title: 'Components/Forms/Controls/Range Slider',

docs-ui/stories/utilities/textCopyInput.stories.js

@@ -1,6 +1,6 @@
 import {action} from '@storybook/addon-actions';
 
-import TextCopyInput from 'sentry/views/settings/components/forms/textCopyInput';
+import TextCopyInput from 'sentry/components/forms/textCopyInput';
 
 export default {
   title: 'Utilities/Copy/Input',

static/app/actionCreators/formSearch.tsx

@@ -2,8 +2,8 @@ import flatMap from 'lodash/flatMap';
 import flatten from 'lodash/flatten';
 
 import FormSearchActions from 'sentry/actions/formSearchActions';
+import {Field, JsonFormObject} from 'sentry/components/forms/type';
 import {FormSearchField} from 'sentry/stores/formSearchStore';
-import {Field, JsonFormObject} from 'sentry/views/settings/components/forms/type';
 
 type Params = {
   fields: Record<string, Field>;

static/app/actionCreators/indicator.tsx

@@ -3,10 +3,10 @@ import styled from '@emotion/styled';
 import * as Sentry from '@sentry/react';
 
 import IndicatorActions from 'sentry/actions/indicatorActions';
+import FormModel, {FieldValue} from 'sentry/components/forms/model';
 import {DEFAULT_TOAST_DURATION} from 'sentry/constants';
 import {t, tct} from 'sentry/locale';
 import space from 'sentry/styles/space';
-import FormModel, {FieldValue} from 'sentry/views/settings/components/forms/model';
 
 type IndicatorType = 'loading' | 'error' | 'success' | 'undo' | '';
 

static/app/components/asyncComponentSearchInput.tsx

@@ -4,9 +4,9 @@ import styled from '@emotion/styled';
 import debounce from 'lodash/debounce';
 
 import {Client, ResponseMeta} from 'sentry/api';
+import Input from 'sentry/components/forms/controls/input';
 import LoadingIndicator from 'sentry/components/loadingIndicator';
 import {t} from 'sentry/locale';
-import Input from 'sentry/views/settings/components/forms/controls/input';
 
 type RenderProps = {
   busy: boolean;