Merge pull request #2587 from drcapulet/alexc-fix-digest-types

Don't use unreliable identity check in digest pipeline.

In some unknown cases, it's possible that the result of `record.value.event.group.get_status()` is a long rather than an integer. This results in the check `0L is 0` which is `False` (and not the correct answer to the intended check.)

This will likely fix GH-2549.

Author: ted kaemming

src/sentry/digests/notifications.py

@@ -200,7 +200,7 @@ def build_digest(project, records, state=None):
     state = attach_state(**state)
 
     def check_group_state(record):
-        return record.value.event.group.get_status() is GroupStatus.UNRESOLVED
+        return record.value.event.group.get_status() == GroupStatus.UNRESOLVED
 
     pipeline = Pipeline(). \
         map(functools.partial(rewrite_record, **state)). \

tests/sentry/models/test_group.py

@@ -97,4 +97,4 @@ def test_status_with_expired_snooze(self):
             group=group,
             until=timezone.now() - timedelta(minutes=1),
         )
-        assert group.get_status() is GroupStatus.UNRESOLVED
+        assert group.get_status() == GroupStatus.UNRESOLVED