feat(preprod): support multiple apps in the status check (#98846)

Updates our status check logic to support multiple apps for the same
commit, say if the user is uploading from a monorepo or producing
multiple apps like an iOS and macOS variant.

<img width="855" height="327" alt="Screenshot 2025-09-04 at 5 09 51 PM"
src="https://github.com/user-attachments/assets/d17dfa85-1e92-4594-84c3-4ed6e50136dc"
/>

Author: trevor-e

bin/preprod/trigger_size_status_check

@@ -130,6 +130,24 @@ def as_choices(cls):
     # An identifier for the main binary
     main_binary_identifier = models.CharField(max_length=255, db_index=True, null=True)
 
+    def get_sibling_artifacts_for_commit(self) -> models.QuerySet["PreprodArtifact"]:
+        """
+        Get all artifacts for the same commit comparison (monorepo scenario).
+
+        Note: Always includes the calling artifact itself along with any siblings.
+        Results are filtered by the current artifact's organization for security.
+
+        Returns:
+            QuerySet of PreprodArtifact objects, ordered by app_id for stable results
+        """
+        if not self.commit_comparison:
+            return PreprodArtifact.objects.none()
+
+        return PreprodArtifact.objects.filter(
+            commit_comparison=self.commit_comparison,
+            project__organization_id=self.project.organization_id,
+        ).order_by("app_id")
+
     class Meta:
         app_label = "preprod"
         db_table = "sentry_preprodartifact"

src/sentry/preprod/models.py

@@ -48,12 +48,12 @@
     ),
 )
 def assemble_preprod_artifact(
-    org_id,
-    project_id,
-    checksum,
-    chunks,
-    artifact_id,
-    **kwargs,
+    org_id: int,
+    project_id: int,
+    checksum: Any,
+    chunks: Any,
+    artifact_id: int,
+    **kwargs: Any,
 ) -> None:
     """
     Creates a preprod artifact from uploaded chunks.
@@ -241,6 +241,15 @@ def create_preprod_artifact(
                 extras=extras,
             )
 
+            # TODO(preprod): add gating to only create if has quota
+            PreprodArtifactSizeMetrics.objects.get_or_create(
+                preprod_artifact=preprod_artifact,
+                metrics_artifact_type=PreprodArtifactSizeMetrics.MetricsArtifactType.MAIN_ARTIFACT,
+                defaults={
+                    "state": PreprodArtifactSizeMetrics.SizeAnalysisState.PENDING,
+                },
+            )
+
             logger.info(
                 "Created preprod artifact row",
                 extra={
@@ -329,8 +338,9 @@ def _assemble_preprod_artifact_file(
 
 
 def _assemble_preprod_artifact_size_analysis(
-    assemble_result: AssembleResult, project, artifact_id, org_id
+    assemble_result: AssembleResult, project, artifact_id: int, org_id: int
 ):
+    preprod_artifact = None
     try:
         preprod_artifact = PreprodArtifact.objects.get(
             project=project,
@@ -357,35 +367,73 @@ def _assemble_preprod_artifact_size_analysis(
             pass  # Ignore cleanup errors
         raise Exception(f"PreprodArtifact with id {artifact_id} does not exist")
 
-    size_analysis_results = SizeAnalysisResults.parse_raw(assemble_result.bundle_temp_file.read())
+    try:
+        size_analysis_results = SizeAnalysisResults.parse_raw(
+            assemble_result.bundle_temp_file.read()
+        )
+
+        with transaction.atomic(router.db_for_write(PreprodArtifactSizeMetrics)):
+            # TODO(preprod): parse this from the treemap json and handle other artifact types
+            size_metrics, created = PreprodArtifactSizeMetrics.objects.update_or_create(
+                preprod_artifact=preprod_artifact,
+                metrics_artifact_type=PreprodArtifactSizeMetrics.MetricsArtifactType.MAIN_ARTIFACT,
+                defaults={
+                    "analysis_file_id": assemble_result.bundle.id,
+                    "min_install_size": None,  # No min value at this time
+                    "max_install_size": size_analysis_results.install_size,
+                    "min_download_size": None,  # No min value at this time
+                    "max_download_size": size_analysis_results.download_size,
+                    "state": PreprodArtifactSizeMetrics.SizeAnalysisState.COMPLETED,
+                },
+            )
 
-    # Update size metrics in its own transaction
-    with transaction.atomic(router.db_for_write(PreprodArtifactSizeMetrics)):
-        size_metrics, created = PreprodArtifactSizeMetrics.objects.update_or_create(
-            preprod_artifact=preprod_artifact,
-            defaults={
+        logger.info(
+            "Created or updated preprod artifact size metrics with analysis file",
+            extra={
+                "preprod_artifact_id": preprod_artifact.id,
+                "size_metrics_id": size_metrics.id,
                 "analysis_file_id": assemble_result.bundle.id,
-                "metrics_artifact_type": PreprodArtifactSizeMetrics.MetricsArtifactType.MAIN_ARTIFACT,  # TODO: parse this from the treemap json
-                "min_install_size": None,  # No min value at this time
-                "max_install_size": size_analysis_results.install_size,
-                "min_download_size": None,  # No min value at this time
-                "max_download_size": size_analysis_results.download_size,
-                "state": PreprodArtifactSizeMetrics.SizeAnalysisState.COMPLETED,
+                "was_created": created,
+                "project_id": project.id,
+                "organization_id": org_id,
             },
         )
 
-    logger.info(
-        "Created or updated preprod artifact size metrics with analysis file",
-        extra={
-            "preprod_artifact_id": preprod_artifact.id,
-            "size_metrics_id": size_metrics.id,
-            "analysis_file_id": assemble_result.bundle.id,
-            "was_created": created,
-            "project_id": project.id,
-            "organization_id": org_id,
-        },
-    )
+    except Exception as e:
+        logger.exception(
+            "Failed to process size analysis results",
+            extra={
+                "preprod_artifact_id": artifact_id,
+                "project_id": project.id,
+                "organization_id": org_id,
+            },
+        )
+
+        with transaction.atomic(router.db_for_write(PreprodArtifactSizeMetrics)):
+            try:
+                PreprodArtifactSizeMetrics.objects.update_or_create(
+                    preprod_artifact=preprod_artifact,
+                    metrics_artifact_type=PreprodArtifactSizeMetrics.MetricsArtifactType.MAIN_ARTIFACT,
+                    defaults={
+                        "state": PreprodArtifactSizeMetrics.SizeAnalysisState.FAILED,
+                        "error_code": PreprodArtifactSizeMetrics.ErrorCode.PROCESSING_ERROR,
+                        "error_message": str(e),
+                    },
+                )
+            except Exception:
+                logger.exception(
+                    "Failed to update preprod artifact size metrics",
+                    extra={
+                        "preprod_artifact_id": artifact_id,
+                        "project_id": project.id,
+                        "organization_id": org_id,
+                    },
+                )
+
+        # Re-raise to trigger further error handling if needed
+        raise
 
+    # Always trigger status check update (success or failure)
     create_preprod_status_check_task.apply_async(
         kwargs={
             "preprod_artifact_id": artifact_id,

src/sentry/preprod/tasks.py

@@ -21,7 +21,7 @@
 from sentry.models.commitcomparison import CommitComparison
 from sentry.models.project import Project
 from sentry.models.repository import Repository
-from sentry.preprod.models import PreprodArtifact
+from sentry.preprod.models import PreprodArtifact, PreprodArtifactSizeMetrics
 from sentry.preprod.url_utils import get_preprod_artifact_url
 from sentry.preprod.vcs.status_checks.templates import format_status_check_messages
 from sentry.silo.base import SiloMode
@@ -58,20 +58,6 @@ def create_preprod_status_check_task(preprod_artifact_id: int) -> None:
         extra={"artifact_id": preprod_artifact.id},
     )
 
-    match preprod_artifact.state:
-        case PreprodArtifact.ArtifactState.UPLOADING | PreprodArtifact.ArtifactState.UPLOADED:
-            status = StatusCheckStatus.IN_PROGRESS
-        case PreprodArtifact.ArtifactState.FAILED:
-            status = StatusCheckStatus.FAILURE
-        case PreprodArtifact.ArtifactState.PROCESSED:
-            status = StatusCheckStatus.SUCCESS
-        case _:
-            raise ValueError(f"Unhandled artifact state: {preprod_artifact.state}")
-
-    title, subtitle, summary = format_status_check_messages(preprod_artifact)
-
-    target_url = get_preprod_artifact_url(preprod_artifact)
-
     if not preprod_artifact.commit_comparison:
         logger.info(
             "preprod.status_checks.create.no_commit_comparison",
@@ -91,6 +77,9 @@ def create_preprod_status_check_task(preprod_artifact_id: int) -> None:
         )
         return
 
+    # Get all artifacts for this commit across all projects in the organization
+    all_artifacts = list(preprod_artifact.get_sibling_artifacts_for_commit())
+
     client, repository = _get_status_check_client(preprod_artifact.project, commit_comparison)
     if not client or not repository:
         # logging handled in _get_status_check_client. for now we can be lax about users potentially
@@ -110,6 +99,24 @@ def create_preprod_status_check_task(preprod_artifact_id: int) -> None:
         )
         return
 
+    size_metrics_map: dict[int, list[PreprodArtifactSizeMetrics]] = {}
+    if all_artifacts:
+        artifact_ids = [artifact.id for artifact in all_artifacts]
+        size_metrics_qs = PreprodArtifactSizeMetrics.objects.filter(
+            preprod_artifact_id__in=artifact_ids,
+        ).select_related("preprod_artifact")
+
+        for metrics in size_metrics_qs:
+            if metrics.preprod_artifact_id not in size_metrics_map:
+                size_metrics_map[metrics.preprod_artifact_id] = []
+            size_metrics_map[metrics.preprod_artifact_id].append(metrics)
+
+    status = _compute_overall_status(all_artifacts, size_metrics_map)
+
+    title, subtitle, summary = format_status_check_messages(all_artifacts, size_metrics_map, status)
+
+    target_url = get_preprod_artifact_url(preprod_artifact)
+
     check_id = provider.create_status_check(
         repo=commit_comparison.head_repo_name,
         sha=commit_comparison.head_sha,
@@ -138,6 +145,38 @@ def create_preprod_status_check_task(preprod_artifact_id: int) -> None:
     )
 
 
+def _compute_overall_status(
+    artifacts: list[PreprodArtifact], size_metrics_map: dict[int, list[PreprodArtifactSizeMetrics]]
+) -> StatusCheckStatus:
+    if not artifacts:
+        raise ValueError("Cannot compute status for empty artifact list")
+
+    states = {artifact.state for artifact in artifacts}
+
+    if PreprodArtifact.ArtifactState.FAILED in states:
+        return StatusCheckStatus.FAILURE
+    elif (
+        PreprodArtifact.ArtifactState.UPLOADING in states
+        or PreprodArtifact.ArtifactState.UPLOADED in states
+    ):
+        return StatusCheckStatus.IN_PROGRESS
+    elif all(state == PreprodArtifact.ArtifactState.PROCESSED for state in states):
+        # All artifacts are processed, but we need to check if size analysis (if present) is complete
+        for artifact in artifacts:
+            size_metrics_list = size_metrics_map.get(artifact.id, [])
+            if size_metrics_list:
+                for size_metrics in size_metrics_list:
+                    if size_metrics.state == PreprodArtifactSizeMetrics.SizeAnalysisState.FAILED:
+                        return StatusCheckStatus.FAILURE
+                    elif (
+                        size_metrics.state != PreprodArtifactSizeMetrics.SizeAnalysisState.COMPLETED
+                    ):
+                        return StatusCheckStatus.IN_PROGRESS
+        return StatusCheckStatus.SUCCESS
+    else:
+        return StatusCheckStatus.IN_PROGRESS
+
+
 def _get_status_check_client(
     project: Project, commit_comparison: CommitComparison
 ) -> tuple[StatusCheckClient, Repository] | tuple[None, None]: