Skip to content

Commit 947aa3c

Browse files
authored
feat(rulesnooze): Update endpoint to include info about if snooze is for all (#47414)
this pr adds an additional field to the ProjectRuleDetailsEndpoint to show if the snoozed rule is snoozed for everyone or just one user. This will be used in a banner on the front end.
1 parent 6fb9d24 commit 947aa3c

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

src/sentry/api/endpoints/project_rule_details.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,7 @@ def get(self, request: Request, project, rule) -> Response:
101101
creator_name = user_service.get_user(snooze.owner_id).get_display_name()
102102
created_by = creator_name
103103
serialized_rule["snoozeCreatedBy"] = created_by
104+
serialized_rule["snoozeForEveryone"] = snooze.user_id is None
104105
else:
105106
serialized_rule["snooze"] = False
106107

tests/sentry/api/endpoints/test_project_rule_details.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,7 @@ def test_with_snooze_rule(self):
160160

161161
assert response.data["snooze"]
162162
assert response.data["snoozeCreatedBy"] == "You"
163+
assert not response.data["snoozeForEveryone"]
163164

164165
def test_with_snooze_rule_everyone(self):
165166
user2 = self.create_user("[email protected]")
@@ -176,6 +177,7 @@ def test_with_snooze_rule_everyone(self):
176177

177178
assert response.data["snooze"]
178179
assert response.data["snoozeCreatedBy"] == user2.get_display_name()
180+
assert response.data["snoozeForEveryone"]
179181

180182
@responses.activate
181183
def test_with_unresponsive_sentryapp(self):

0 commit comments

Comments
 (0)