ref(seer): Refactor Seer request helper tests (#74670)

This makes a number of changes to the existing tests for `make_signed_seer_api_request`, both for clarity and in anticipation of new tests being added.

Changes:

- The helper function `url_request` has been renamed `run_test_case`, given a docstring, moved up to the module level, and given the ability to use a custom path when making mock requests.
- The mock returned from said function is now captured before it's asserted on, primarily to give it a name so it's clearer what it is.
- The default path and body values have been pulled into constants.
- The single generically-named test testing three cases has been split into three separate tests, named according to what they're testing.

Author: lobsterkatie

tests/sentry/seer/test_signed_seer_api.py

@@ -6,46 +6,62 @@
 from sentry.seer.signed_seer_api import make_signed_seer_api_request
 from sentry.testutils.helpers import override_options
 
+REQUEST_BODY = b'{"b": 12, "thing": "thing"}'
+PATH = "/v0/some/url"
+
+
+def run_test_case(path: str = PATH, timeout: int | None = None):
+    """
+    Make a mock connection pool, call `make_signed_seer_api_request` on it, and return the
+    pool's `urlopen` method, so we can make assertions on how `make_signed_seer_api_request`
+    used it.
+    """
+    mock = Mock()
+    mock.host = "localhost"
+    mock.port = None
+    mock.scheme = "http"
+    with override_settings(SEER_API_SHARED_SECRET="secret-one"):
+        make_signed_seer_api_request(
+            mock,
+            path=path,
+            body=REQUEST_BODY,
+            timeout=timeout,
+        )
+
+    return mock.urlopen
+
 
 @pytest.mark.django_db
-def test_make_signed_seer_api_request():
-    body = b'{"b": 12, "thing": "thing"}'
-
-    def url_request(timeout: int | None = None):
-        mock = Mock()
-        mock.host = "localhost"
-        mock.port = None
-        mock.scheme = "http"
-        with override_settings(SEER_API_SHARED_SECRET="secret-one"):
-            make_signed_seer_api_request(
-                mock,
-                path="/v0/some/url",
-                body=body,
-                timeout=timeout,
-            )
-
-        return mock.urlopen
-
-    url_request().assert_called_once_with(
+def test_simple():
+    mock_url_open = run_test_case()
+    mock_url_open.assert_called_once_with(
         "POST",
-        "/v0/some/url",
-        body=body,
+        PATH,
+        body=REQUEST_BODY,
         headers={"content-type": "application/json;charset=utf-8"},
     )
 
-    url_request(timeout=5).assert_called_once_with(
+
+@pytest.mark.django_db
+def test_uses_given_timeout():
+    mock_url_open = run_test_case(timeout=5)
+    mock_url_open.assert_called_once_with(
         "POST",
-        "/v0/some/url",
-        body=body,
+        PATH,
+        body=REQUEST_BODY,
         headers={"content-type": "application/json;charset=utf-8"},
         timeout=5,
     )
 
+
+@pytest.mark.django_db
+def test_uses_shared_secret():
     with override_options({"seer.api.use-shared-secret": 1.0}):
-        url_request().assert_called_once_with(
+        mock_url_open = run_test_case()
+        mock_url_open.assert_called_once_with(
             "POST",
-            "/v0/some/url",
-            body=body,
+            PATH,
+            body=REQUEST_BODY,
             headers={
                 "content-type": "application/json;charset=utf-8",
                 "Authorization": "Rpcsignature rpc0:96f23d5b3df807a9dc91f090078a46c00e17fe8b0bc7ef08c9391fa8b37a66b5",