Skip to content

Commit 982cd52

Browse files
authored
fix(Replay): Include Timestamp Attribute in Trace Item (#104030)
This PR is in regards to the following issue: https://sentry.sentry.io/issues/7061220977/?alert_rule_id=14394965&alert_type=issue&notification_uuid=c59f28da-3fac-4c5f-8e8c-f54412d24dc5&project=11276&referrer=slack Upon further exploration, it seems like the EAP replay query is unable to find any timestamp data: <img width="439" height="323" alt="image" src="https://github.com/user-attachments/assets/a537ed40-437f-4d6a-9bfc-5fdb6eaf9fbe" /> This is likely because the timestamp column is not placed as an attribute when we create the trace item. Relates to: https://linear.app/getsentry/issue/REPLAY-824/create-query-function-for-replay-details
1 parent 370834f commit 982cd52

File tree

3 files changed

+14
-7
lines changed

3 files changed

+14
-7
lines changed

src/sentry/replays/endpoints/organization_replay_details.py

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@ def query_replay_instance_eap(
3939
select = [
4040
Column("replay_id"),
4141
Function("min", parameters=[Column("project_id")], alias="agg_project_id"),
42-
Function("min", parameters=[Column("timestamp")], alias="started_at"),
43-
Function("max", parameters=[Column("timestamp")], alias="finished_at"),
42+
Function("min", parameters=[Column("sentry.timestamp")], alias="started_at"),
43+
Function("max", parameters=[Column("sentry.timestamp")], alias="finished_at"),
4444
Function("count", parameters=[Column("segment_id")], alias="count_segments"),
4545
Function("sum", parameters=[Column("count_error_events")], alias="count_errors"),
4646
Function("sum", parameters=[Column("count_warning_events")], alias="count_warnings"),
@@ -51,7 +51,10 @@ def query_replay_instance_eap(
5151
Column("click_is_dead"),
5252
Function(
5353
"greaterOrEquals",
54-
[Column("timestamp"), int(datetime(year=2023, month=7, day=24).timestamp())],
54+
[
55+
Column("sentry.timestamp"),
56+
int(datetime(year=2023, month=7, day=24).timestamp()),
57+
],
5558
),
5659
],
5760
alias="count_dead_clicks",
@@ -62,7 +65,10 @@ def query_replay_instance_eap(
6265
Column("click_is_rage"),
6366
Function(
6467
"greaterOrEquals",
65-
[Column("timestamp"), int(datetime(year=2023, month=7, day=24).timestamp())],
68+
[
69+
Column("sentry.timestamp"),
70+
int(datetime(year=2023, month=7, day=24).timestamp()),
71+
],
6672
),
6773
],
6874
alias="count_rage_clicks",
@@ -84,8 +90,7 @@ def query_replay_instance_eap(
8490
attribute_types={
8591
"replay_id": str,
8692
"project_id": int,
87-
"timestamp": int,
88-
"replay_start_timestamp": int,
93+
"sentry.timestamp": int,
8994
"segment_id": int,
9095
"is_archived": int,
9196
"count_error_events": int,

src/sentry/testutils/cases.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3860,7 +3860,6 @@ def create_eap_replay_breadcrumb(
38603860
"replay_id": replay_id,
38613861
"segment_id": segment_id,
38623862
"project_id": project.id,
3863-
"timestamp": int(timestamp.timestamp()),
38643863
"category": category,
38653864
}
38663865

tests/sentry/replays/endpoints/test_query_replay_instance_eap.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,9 @@ def test_eap_replay_query(self) -> None:
116116
assert "started_at" in replay1_data
117117
assert "finished_at" in replay1_data
118118

119+
assert replay1_data["started_at"] is not None, "started_at should not be None"
120+
assert replay1_data["finished_at"] is not None, "finished_at should not be None"
121+
119122
assert replay1_data["count_dead_clicks"] == 3, "2 DEAD_CLICK + 1 RAGE_CLICK = 3 dead"
120123
assert replay1_data["count_rage_clicks"] == 1, "1 RAGE_CLICK = 1 rage"
121124

0 commit comments

Comments
 (0)