chore(aci): update filters for environments on workflows (#87418)

Author: cathteng

src/sentry/workflow_engine/processors/workflow.py

@@ -8,6 +8,7 @@
 from sentry import buffer, features
 from sentry.db.models.manager.base_query_set import BaseQuerySet
 from sentry.eventstore.models import GroupEvent
+from sentry.models.environment import Environment
 from sentry.utils import json, metrics
 from sentry.workflow_engine.models import (
     Action,
@@ -156,6 +157,13 @@ def process_workflows(job: WorkflowJob) -> set[Workflow]:
         logger.exception("Detector not found for event", extra={"event_id": job["event"].event_id})
         return set()
 
+    try:
+        environment = job["event"].get_environment()
+    except Environment.DoesNotExist:
+        metrics.incr("workflow_engine.process_workflows.error")
+        logger.exception("Missing environment for event", extra={"event_id": job["event"].event_id})
+        return set()
+
     # TODO: remove fetching org, only used for FF check
     organization = detector.project.organization
 

tests/sentry/workflow_engine/processors/test_workflow.py

@@ -6,6 +6,7 @@
 from sentry import buffer
 from sentry.eventstream.base import GroupState
 from sentry.grouping.grouptype import ErrorGroupType
+from sentry.models.environment import Environment
 from sentry.models.rule import Rule
 from sentry.testutils.factories import Factories
 from sentry.testutils.helpers import with_feature
@@ -118,6 +119,19 @@ def test_error_event__logger(self, mock_logger):
         )
 
     def test_same_environment_only(self):
+        env = self.create_environment(project=self.project)
+        other_env = self.create_environment(project=self.project)
+
+        self.group, self.event, self.group_event = self.create_group_event(environment=env.name)
+        self.job = WorkflowJob(
+            {
+                "event": self.group_event,
+                "group_state": GroupState(
+                    id=1, is_new=False, is_regression=True, is_new_group_environment=False
+                ),
+            }
+        )
+
         # only processes workflows with the same env or no env specified
         self.error_workflow.update(environment=None)
 
@@ -133,13 +147,21 @@ def test_same_environment_only(self):
         dcg = self.create_data_condition_group()
         matching_env_workflow = self.create_workflow(
             when_condition_group=dcg,
-            environment=self.group_event.get_environment(),
+            environment=env,
         )
         self.create_detector_workflow(
             detector=self.error_detector,
             workflow=matching_env_workflow,
         )
 
+        mismatched_env_workflow = self.create_workflow(
+            when_condition_group=dcg, environment=other_env
+        )
+        self.create_detector_workflow(
+            detector=self.error_detector,
+            workflow=mismatched_env_workflow,
+        )
+
         triggered_workflows = process_workflows(self.job)
         assert triggered_workflows == {self.error_workflow, matching_env_workflow}
 
@@ -183,6 +205,20 @@ def test_no_detector(self, mock_logger, mock_metrics):
             extra={"event_id": self.event.event_id},
         )
 
+    @patch("sentry.workflow_engine.processors.workflow.metrics")
+    @patch("sentry.workflow_engine.processors.workflow.logger")
+    def test_no_environment(self, mock_logger, mock_metrics):
+        Environment.objects.all().delete()
+        triggered_workflows = process_workflows(self.job)
+
+        assert not triggered_workflows
+
+        mock_metrics.incr.assert_called_once_with("workflow_engine.process_workflows.error")
+        mock_logger.exception.assert_called_once_with(
+            "Missing environment for event",
+            extra={"event_id": self.event.event_id},
+        )
+
     @patch("sentry.utils.metrics.incr")
     @patch("sentry.workflow_engine.processors.workflow.logger")
     def test_no_metrics_triggered(self, mock_logger, mock_incr):
@@ -244,6 +280,13 @@ def test_workflow_trigger(self):
         triggered_workflows = evaluate_workflow_triggers({self.workflow}, self.job)
         assert triggered_workflows == {self.workflow}
 
+    def test_workflow_trigger__no_conditions(self):
+        assert self.workflow.when_condition_group
+        self.workflow.when_condition_group.conditions.all().delete()
+
+        triggered_workflows = evaluate_workflow_triggers({self.workflow}, self.job)
+        assert triggered_workflows == {self.workflow}
+
     def test_no_workflow_trigger(self):
         triggered_workflows = evaluate_workflow_triggers(set(), self.job)
         assert not triggered_workflows

tests/sentry/workflow_engine/test_base.py

@@ -187,6 +187,7 @@ def create_group_event(
         project: Project | None = None,
         event: Event | None = None,
         occurrence: IssueOccurrence | None = None,
+        environment: str | None = None,
         fingerprint="test_fingerprint",
         group_type_id: int | None = None,
     ) -> tuple[Group, Event, GroupEvent]:
@@ -195,6 +196,7 @@ def create_group_event(
             project.id,
             datetime.now(),
             fingerprint,
+            environment,
         )
 
         if group_type_id: