Skip to content

Commit 99edf04

Browse files
authored
fix(ci): Only set CI=1 for e2e tests for now (#21410)
Our JS code (specifically, getDynamicTest) uses the CI env variable incorrectly to detect pull request or acceptance test builds and during the compilation, this value gets hard-coded into the wheel. This PR is a stop gap solution to address #21409 quickly.
1 parent 8bef7e0 commit 99edf04

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

docker/cloudbuild.yaml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,8 @@ steps:
6464
- get-onpremise-repo
6565
entrypoint: 'bash'
6666
dir: onpremise
67+
env:
68+
- 'CI=1'
6769
args:
6870
- '-e'
6971
- '-c'
@@ -89,6 +91,7 @@ steps:
8991
entrypoint: 'bash'
9092
dir: onpremise
9193
env:
94+
- 'CI=1'
9295
- 'SENTRY_PYTHON3=1'
9396
args:
9497
- '-e'
@@ -170,7 +173,6 @@ options:
170173
- 'SENTRY_IMAGE=us.gcr.io/$PROJECT_ID/sentry:$COMMIT_SHA'
171174
- 'DOCKER_REPO=getsentry/sentry'
172175
- 'SENTRY_TEST_HOST=http://nginx'
173-
- 'CI=1'
174176
secrets:
175177
- kmsKeyName: projects/sentryio/locations/global/keyRings/service-credentials/cryptoKeys/cloudbuild
176178
secretEnv:

0 commit comments

Comments
 (0)