Skip to content

Commit 9d0f6d0

Browse files
authored
fix(ts): Improve type for errors on AsyncComponent (#25290)
1 parent 77427ef commit 9d0f6d0

File tree

5 files changed

+5
-5
lines changed

5 files changed

+5
-5
lines changed

src/sentry/static/sentry/app/components/asyncComponent.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ type AsyncComponentState = {
2121
loading: boolean;
2222
reloading: boolean;
2323
error: boolean;
24-
errors: object;
24+
errors: Record<string, JQueryXHR>;
2525
remainingRequests?: number;
2626
[key: string]: any;
2727
};

src/sentry/static/sentry/app/views/dashboardsV2/orgDashboards.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ class OrgDashboards extends AsyncComponent<Props, State> {
4545
loading: true,
4646
reloading: false,
4747
error: false,
48-
errors: [],
48+
errors: {},
4949

5050
dashboards: [],
5151
selectedDashboard: null,

src/sentry/static/sentry/app/views/eventsV2/eventDetails/content.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ class EventDetailsContent extends AsyncComponent<Props, State> {
6767
loading: true,
6868
reloading: false,
6969
error: false,
70-
errors: [],
70+
errors: {},
7171
event: undefined,
7272

7373
// local state

src/sentry/static/sentry/app/views/eventsV2/landing.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ class DiscoverLanding extends AsyncComponent<Props, State> {
7070
loading: true,
7171
reloading: false,
7272
error: false,
73-
errors: [],
73+
errors: {},
7474

7575
// local component state
7676
isBannerHidden: isBannerHidden(),

src/sentry/static/sentry/app/views/performance/transactionDetails/content.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ class EventDetailsContent extends AsyncComponent<Props, State> {
5656
loading: true,
5757
reloading: false,
5858
error: false,
59-
errors: [],
59+
errors: {},
6060
event: undefined,
6161

6262
// local state

0 commit comments

Comments
 (0)