feat(dashboards): Surface split decision in widget type field (#74634)

Surface the split decision in the widget type field. This is because we
don't return the split decision on subsequent requests when we detect
that the `discover_widget_split` field is populated, but the frontend
still needs to know which dataset to show on subsequent loads.

Author: narsaynorath

src/sentry/api/serializers/models/dashboard.py

@@ -2,6 +2,7 @@
 
 import orjson
 
+from sentry import features
 from sentry.api.serializers import Serializer, register, serialize
 from sentry.constants import ALL_ACCESS_PROJECTS
 from sentry.models.dashboard import Dashboard
@@ -36,6 +37,21 @@ def get_attrs(self, item_list, user):
         return result
 
     def serialize(self, obj, attrs, user, **kwargs):
+        widget_type = (
+            DashboardWidgetTypes.get_type_name(obj.widget_type)
+            or DashboardWidgetTypes.TYPE_NAMES[0]
+        )
+
+        if (
+            features.has(
+                "organizations:performance-discover-dataset-selector",
+                obj.dashboard.organization,
+                actor=user,
+            )
+            and obj.discover_widget_split is not None
+        ):
+            widget_type = DashboardWidgetTypes.get_type_name(obj.discover_widget_split)
+
         return {
             "id": str(obj.id),
             "title": obj.title,
@@ -49,8 +65,7 @@ def serialize(self, obj, attrs, user, **kwargs):
             "queries": attrs["queries"],
             "limit": obj.limit,
             # Default to discover type if null
-            "widgetType": DashboardWidgetTypes.get_type_name(obj.widget_type)
-            or DashboardWidgetTypes.TYPE_NAMES[0],
+            "widgetType": widget_type,
             "layout": obj.detail.get("layout") if obj.detail else None,
         }
 

tests/sentry/api/endpoints/test_organization_dashboard_details.py

@@ -216,6 +216,52 @@ def test_response_truncates_with_retention(self):
             expected_adjusted_retention_start.replace(second=0)
         )
 
+    def test_dashboard_widget_type_returns_split_decision(self):
+        dashboard = Dashboard.objects.create(
+            title="Dashboard With Split Widgets",
+            created_by_id=self.user.id,
+            organization=self.organization,
+        )
+        DashboardWidget.objects.create(
+            dashboard=dashboard,
+            order=0,
+            title="error widget",
+            display_type=DashboardWidgetDisplayTypes.LINE_CHART,
+            widget_type=DashboardWidgetTypes.DISCOVER,
+            interval="1d",
+            detail={"layout": {"x": 0, "y": 0, "w": 1, "h": 1, "minH": 2}},
+            discover_widget_split=DashboardWidgetTypes.ERROR_EVENTS,
+        )
+        DashboardWidget.objects.create(
+            dashboard=dashboard,
+            order=1,
+            title="transaction widget",
+            display_type=DashboardWidgetDisplayTypes.LINE_CHART,
+            widget_type=DashboardWidgetTypes.DISCOVER,
+            interval="1d",
+            detail={"layout": {"x": 0, "y": 0, "w": 1, "h": 1, "minH": 2}},
+            discover_widget_split=DashboardWidgetTypes.TRANSACTION_LIKE,
+        )
+        DashboardWidget.objects.create(
+            dashboard=dashboard,
+            order=2,
+            title="no split",
+            display_type=DashboardWidgetDisplayTypes.LINE_CHART,
+            widget_type=DashboardWidgetTypes.DISCOVER,
+            interval="1d",
+            detail={"layout": {"x": 0, "y": 0, "w": 1, "h": 1, "minH": 2}},
+        )
+
+        with self.feature({"organizations:performance-discover-dataset-selector": True}):
+            response = self.do_request(
+                "get",
+                self.url(dashboard.id),
+            )
+        assert response.status_code == 200, response.content
+        assert response.data["widgets"][0]["widgetType"] == "error-events"
+        assert response.data["widgets"][1]["widgetType"] == "transaction-like"
+        assert response.data["widgets"][2]["widgetType"] == "discover"
+
 
 class OrganizationDashboardDetailsDeleteTest(OrganizationDashboardDetailsTestCase):
     def test_delete(self):