Skip to content

Commit a0ea44c

Browse files
fix(eco): downgrades weekly report timeouts from a failure to a halt (#97648)
1 parent 2ff2814 commit a0ea44c

File tree

2 files changed

+2
-10
lines changed

2 files changed

+2
-10
lines changed

src/sentry/tasks/summaries/metrics.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,6 @@
66
from sentry.integrations.utils.metrics import EventLifecycleMetric
77

88

9-
class WeeklyReportFailureReason(StrEnum):
10-
"""
11-
The reason for a failure in the weekly reporting pipeline.
12-
"""
13-
14-
TIMEOUT = "timeout"
15-
16-
179
class WeeklyReportHaltReason(StrEnum):
1810
"""
1911
The reason for a halt in the weekly reporting pipeline.
@@ -22,6 +14,7 @@ class WeeklyReportHaltReason(StrEnum):
2214
EMPTY_REPORT = "empty_report"
2315
DRY_RUN = "dry_run"
2416
DUPLICATE_DELIVERY = "duplicate_delivery"
17+
TIMEOUT = "timeout"
2518

2619

2720
class WeeklyReportOperationType(StrEnum):

src/sentry/tasks/summaries/weekly_reports.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
from sentry.silo.base import SiloMode
2727
from sentry.tasks.base import instrumented_task, retry
2828
from sentry.tasks.summaries.metrics import (
29-
WeeklyReportFailureReason,
3029
WeeklyReportHaltReason,
3130
WeeklyReportOperationType,
3231
WeeklyReportSLO,
@@ -158,7 +157,7 @@ def schedule_organizations(
158157

159158
batching.delete_min_org_id()
160159
except ProcessingDeadlineExceeded:
161-
lifecycle.record_failure(WeeklyReportFailureReason.TIMEOUT)
160+
lifecycle.record_halt(WeeklyReportHaltReason.TIMEOUT)
162161
raise
163162

164163

0 commit comments

Comments
 (0)