fix(aci): Reject condition_group for error detectors (#96602)

Author: malwilley

src/sentry/workflow_engine/endpoints/validators/base/detector.py

@@ -39,6 +39,7 @@ class BaseDetectorTypeValidator(CamelSnakeSerializer):
     config = serializers.JSONField(default=dict)
     owner = ActorField(required=False, allow_null=True)
     enabled = serializers.BooleanField(required=False)
+    condition_group = BaseDataConditionGroupValidator(required=False)
 
     def validate_type(self, value: str) -> builtins.type[GroupType]:
         type = grouptype.registry.get_by_slug(value)

src/sentry/workflow_engine/endpoints/validators/error_detector.py

@@ -25,6 +25,13 @@ def validate_type(self, value: str):
 
         return type
 
+    def validate_condition_group(self, value):
+        if value is not None:
+            raise serializers.ValidationError(
+                "Condition group is not supported for error detectors"
+            )
+        return value
+
     def validate_fingerprinting_rules(self, value):
         if not value:
             return value

tests/sentry/workflow_engine/detectors/test_error_detector.py

@@ -82,6 +82,28 @@ def test_invalid_resolve_duration(self) -> None:
             ErrorDetail(string="Resolve age must be a non-negative number", code="invalid")
         ]
 
+    def test_invalid_condition_group(self) -> None:
+        data = {
+            **self.valid_data,
+            "condition_group": {
+                "logic_type": "any",
+                "conditions": [
+                    {
+                        "type": "eq",
+                        "comparison": 100,
+                        "condition_result": "high",
+                    }
+                ],
+            },
+        }
+        validator = ErrorDetectorValidator(data=data, context=self.context)
+        assert not validator.is_valid()
+        assert validator.errors.get("conditionGroup") == [
+            ErrorDetail(
+                string="Condition group is not supported for error detectors", code="invalid"
+            )
+        ]
+
     def test_update_existing_with_valid_data(self) -> None:
         data = {**self.valid_data, "name": "Updated Detector"}
         validator = ErrorDetectorValidator(