Skip to content

Commit a3c20cc

Browse files
ref(js): Relative imports in settingsBreadcrumb (#71084)
These are just so deeply nested, it's kinda nicer this way
1 parent 61d26de commit a3c20cc

File tree

9 files changed

+20
-21
lines changed

9 files changed

+20
-21
lines changed

static/app/views/settings/components/settingsBreadcrumb/breadcrumbDropdown.spec.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import {render, screen, userEvent} from 'sentry-test/reactTestingLibrary';
22

3-
import BreadcrumbDropdown from 'sentry/views/settings/components/settingsBreadcrumb/breadcrumbDropdown';
3+
import BreadcrumbDropdown from './breadcrumbDropdown';
44

55
describe('Settings Breadcrumb Dropdown', () => {
66
const selectMock = jest.fn();

static/app/views/settings/components/settingsBreadcrumb/breadcrumbDropdown.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@ import {useState} from 'react';
22

33
import DropdownAutoCompleteMenu from 'sentry/components/dropdownAutoComplete/menu';
44
import type {Item} from 'sentry/components/dropdownAutoComplete/types';
5-
import Crumb from 'sentry/views/settings/components/settingsBreadcrumb/crumb';
6-
import Divider from 'sentry/views/settings/components/settingsBreadcrumb/divider';
75

6+
import Crumb from './crumb';
7+
import Divider from './divider';
88
import type {RouteWithName} from './types';
99

1010
interface AdditionalDropdownProps

static/app/views/settings/components/settingsBreadcrumb/breadcrumbTitle.spec.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ import {initializeOrg} from 'sentry-test/initializeOrg';
22
import {BreadcrumbContextProvider} from 'sentry-test/providers/breadcrumbContextProvider';
33
import {render, screen} from 'sentry-test/reactTestingLibrary';
44

5-
import SettingsBreadcrumb from 'sentry/views/settings/components/settingsBreadcrumb';
6-
import BreadcrumbTitle from 'sentry/views/settings/components/settingsBreadcrumb/breadcrumbTitle';
5+
import BreadcrumbTitle from './breadcrumbTitle';
6+
import SettingsBreadcrumb from '.';
77

88
jest.unmock('sentry/utils/recreateRoute');
99

static/app/views/settings/components/settingsBreadcrumb/findFirstRouteWithoutRouteParam.spec.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
import findFirstRouteWithoutRouteParam from 'sentry/views/settings/components/settingsBreadcrumb/findFirstRouteWithoutRouteParam';
2-
1+
import findFirstRouteWithoutRouteParam from './findFirstRouteWithoutRouteParam';
32
import type {RouteWithName} from './types';
43

54
describe('findFirstRouteWithoutRouteParam', function () {

static/app/views/settings/components/settingsBreadcrumb/index.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,13 @@ import Link from 'sentry/components/links/link';
44
import {t} from 'sentry/locale';
55
import getRouteStringFromRoutes from 'sentry/utils/getRouteStringFromRoutes';
66
import recreateRoute from 'sentry/utils/recreateRoute';
7-
import Crumb from 'sentry/views/settings/components/settingsBreadcrumb/crumb';
8-
import Divider from 'sentry/views/settings/components/settingsBreadcrumb/divider';
9-
import {OrganizationCrumb} from 'sentry/views/settings/components/settingsBreadcrumb/organizationCrumb';
10-
import ProjectCrumb from 'sentry/views/settings/components/settingsBreadcrumb/projectCrumb';
11-
import TeamCrumb from 'sentry/views/settings/components/settingsBreadcrumb/teamCrumb';
127

138
import {useBreadcrumbsPathmap} from './context';
9+
import Crumb from './crumb';
10+
import Divider from './divider';
11+
import {OrganizationCrumb} from './organizationCrumb';
12+
import ProjectCrumb from './projectCrumb';
13+
import TeamCrumb from './teamCrumb';
1414
import type {RouteWithName} from './types';
1515

1616
const MENUS = {

static/app/views/settings/components/settingsBreadcrumb/organizationCrumb.spec.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ import {render, screen, userEvent} from 'sentry-test/reactTestingLibrary';
66
import OrganizationsStore from 'sentry/stores/organizationsStore';
77
import type {Config} from 'sentry/types/system';
88
import {browserHistory} from 'sentry/utils/browserHistory';
9-
import {OrganizationCrumb} from 'sentry/views/settings/components/settingsBreadcrumb/organizationCrumb';
109

10+
import {OrganizationCrumb} from './organizationCrumb';
1111
import type {RouteWithName} from './types';
1212

1313
jest.unmock('sentry/utils/recreateRoute');

static/app/views/settings/components/settingsBreadcrumb/organizationCrumb.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,10 @@ import {browserHistory} from 'sentry/utils/browserHistory';
1010
import recreateRoute from 'sentry/utils/recreateRoute';
1111
import {resolveRoute} from 'sentry/utils/resolveRoute';
1212
import useOrganization from 'sentry/utils/useOrganization';
13-
import BreadcrumbDropdown from 'sentry/views/settings/components/settingsBreadcrumb/breadcrumbDropdown';
14-
import findFirstRouteWithoutRouteParam from 'sentry/views/settings/components/settingsBreadcrumb/findFirstRouteWithoutRouteParam';
15-
import MenuItem from 'sentry/views/settings/components/settingsBreadcrumb/menuItem';
1613

14+
import BreadcrumbDropdown from './breadcrumbDropdown';
15+
import findFirstRouteWithoutRouteParam from './findFirstRouteWithoutRouteParam';
16+
import MenuItem from './menuItem';
1717
import {CrumbLink} from '.';
1818

1919
type Props = RouteComponentProps<{projectId?: string}, {}>;

static/app/views/settings/components/settingsBreadcrumb/projectCrumb.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,10 @@ import recreateRoute from 'sentry/utils/recreateRoute';
1111
import replaceRouterParams from 'sentry/utils/replaceRouterParams';
1212
import useProjects from 'sentry/utils/useProjects';
1313
import withLatestContext from 'sentry/utils/withLatestContext';
14-
import BreadcrumbDropdown from 'sentry/views/settings/components/settingsBreadcrumb/breadcrumbDropdown';
15-
import findFirstRouteWithoutRouteParam from 'sentry/views/settings/components/settingsBreadcrumb/findFirstRouteWithoutRouteParam';
16-
import MenuItem from 'sentry/views/settings/components/settingsBreadcrumb/menuItem';
1714

15+
import BreadcrumbDropdown from './breadcrumbDropdown';
16+
import findFirstRouteWithoutRouteParam from './findFirstRouteWithoutRouteParam';
17+
import MenuItem from './menuItem';
1818
import {CrumbLink} from '.';
1919

2020
type Props = RouteComponentProps<{projectId?: string}, {}> & {

static/app/views/settings/components/settingsBreadcrumb/teamCrumb.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@ import {browserHistory} from 'sentry/utils/browserHistory';
77
import recreateRoute from 'sentry/utils/recreateRoute';
88
import {useParams} from 'sentry/utils/useParams';
99
import {useTeams} from 'sentry/utils/useTeams';
10-
import BreadcrumbDropdown from 'sentry/views/settings/components/settingsBreadcrumb/breadcrumbDropdown';
11-
import MenuItem from 'sentry/views/settings/components/settingsBreadcrumb/menuItem';
1210

11+
import BreadcrumbDropdown from './breadcrumbDropdown';
12+
import MenuItem from './menuItem';
1313
import {CrumbLink} from '.';
1414

1515
type Props = RouteComponentProps<{teamId: string}, {}>;

0 commit comments

Comments
 (0)