Skip to content

Commit a4f8819

Browse files
authored
fix(dashboards): Ignore limit for release widget queries (#86117)
There was a bug that saved `limit` with widgets (fixed [here](#85951)). It seems like release health widgets were passing along the limit explicitly for tables which caused it to truncate the data even when we override it depending on the widget builder vs dashboard context. The other widget queries components do not explicitly pass down the widget's limit so I've removed it to make it consistent. This means we won't prematurely truncate the request for data for the release health widget. Additionally fixes #85796
1 parent b33a568 commit a4f8819

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

static/app/views/dashboards/widgetCard/releaseWidgetQueries.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -360,6 +360,7 @@ class ReleaseWidgetQueries extends Component<Props, State> {
360360
cursor,
361361
dashboardFilters,
362362
onDataFetched,
363+
limit,
363364
} = this.props;
364365
const config = ReleasesConfig;
365366

@@ -372,7 +373,7 @@ class ReleaseWidgetQueries extends Component<Props, State> {
372373
widget={this.transformWidget(widget)}
373374
dashboardFilters={dashboardFilters}
374375
cursor={cursor}
375-
limit={this.limit}
376+
limit={limit}
376377
onDataFetched={onDataFetched}
377378
loading={
378379
requiresCustomReleaseSorting(widget.queries[0]!)

static/app/views/dashboards/widgetCard/widgetCardDataLoader.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ export function WidgetCardDataLoader({
8484
organization={organization}
8585
widget={widget}
8686
selection={selection}
87-
limit={widget.limit ?? tableItemLimit}
87+
limit={tableItemLimit}
8888
onDataFetched={onDataFetched}
8989
dashboardFilters={dashboardFilters}
9090
>

0 commit comments

Comments
 (0)