Remove SENTRY_ENABLE_EXPLORE_USERS

Author: dcramer

CHANGES

@@ -15,6 +15,7 @@ Version 7.7.0
 - Upped TSDB's storage of 10s to 60m of data.
 - Added protocol version 7 to client spec.
   - Adds 'fingerprint' attribute.
+- The behavior of SENTRY_ENABLE_EXPLORE_USERS is now default and the setting has been removed.
 
 Version 7.6.2
 -------------

src/sentry/conf/server.py

@@ -707,7 +707,6 @@ def create_partitioned_queues(name):
 
 # Early draft features. Not slated or public release yet.
 SENTRY_ENABLE_EXPLORE_CODE = False
-SENTRY_ENABLE_EXPLORE_USERS = True
 
 # Prevent variables (e.g. context locals, http data, etc) from exceeding this
 # size in characters

src/sentry/tasks/post_process.py

@@ -55,8 +55,7 @@ def post_process_group(event, is_new, is_regression, is_sample, **kwargs):
     if settings.SENTRY_ENABLE_EXPLORE_CODE:
         record_affected_code.delay(event=event)
 
-    if settings.SENTRY_ENABLE_EXPLORE_USERS:
-        record_affected_user.delay(event=event)
+    record_affected_user.delay(event=event)
 
     record_additional_tags(event=event)
 
@@ -102,10 +101,6 @@ def plugin_post_process_group(plugin_slug, event, **kwargs):
 def record_affected_user(event, **kwargs):
     from sentry.models import Group
 
-    if not settings.SENTRY_ENABLE_EXPLORE_USERS:
-        logger.info('Skipping sentry:user tag due to SENTRY_ENABLE_EXPLORE_USERS')
-        return
-
     user_ident = event.user_ident
     if not user_ident:
         logger.info('No user data found for event_id=%s', event.event_id)

src/sentry/utils/pytest.py

@@ -63,7 +63,6 @@ def pytest_configure(config):
 
     # enable draft features
     settings.SENTRY_ENABLE_EXPLORE_CODE = True
-    settings.SENTRY_ENABLE_EXPLORE_USERS = True
     settings.SENTRY_ENABLE_EMAIL_REPLIES = True
 
     # disable error reporting by default

tests/sentry/tasks/post_process/tests.py

@@ -48,23 +48,12 @@ def test_record_affected_user(self, mock_record_affected_user):
         group = self.create_group(project=self.project)
         event = self.create_event(group=group)
 
-        with self.settings(SENTRY_ENABLE_EXPLORE_USERS=False):
-            post_process_group(
-                event=event,
-                is_new=True,
-                is_regression=False,
-                is_sample=False,
-            )
-
-        assert not mock_record_affected_user.delay.called
-
-        with self.settings(SENTRY_ENABLE_EXPLORE_USERS=True):
-            post_process_group(
-                event=event,
-                is_new=True,
-                is_regression=False,
-                is_sample=False,
-            )
+        post_process_group(
+            event=event,
+            is_new=True,
+            is_regression=False,
+            is_sample=False,
+        )
 
         mock_record_affected_user.delay.assert_called_once_with(
             event=event,