ref(hybrid-cloud): Removes unused onboarding task handling (#60337)

Author: GabeVillalobos

src/sentry/receivers/onboarding.py

@@ -25,7 +25,6 @@
     event_processed,
     first_cron_checkin_received,
     first_cron_monitor_created,
-    first_event_pending,
     first_event_received,
     first_event_with_minified_stack_trace_received,
     first_feedback_received,
@@ -102,17 +101,6 @@ def record_new_project(project, user=None, user_id=None, **kwargs):
         )
 
 
-@first_event_pending.connect(weak=False)
-def record_raven_installed(project, user, **kwargs):
-    OrganizationOnboardingTask.objects.record(
-        organization_id=project.organization_id,
-        task=OnboardingTask.FIRST_EVENT,
-        status=OnboardingTaskStatus.PENDING,
-        user_id=user.id if user else None,
-        project_id=project.id,
-    )
-
-
 @first_event_received.connect(weak=False)
 def record_first_event(project, event, **kwargs):
     """

src/sentry/services/hybrid_cloud/organization/impl.py

@@ -623,7 +623,9 @@ def send_signal(
     ) -> None:
         signal.signal.send_robust(None, organization_id=organization_id, **args)
 
-    def get_organization_owner_members(self, organization_id: int) -> List[RpcOrganizationMember]:
+    def get_organization_owner_members(
+        self, *, organization_id: int
+    ) -> List[RpcOrganizationMember]:
         org: Organization = Organization.objects.get(id=organization_id)
         owner_members = org.get_members_with_org_roles(roles=[roles.get_top_dog().id])
 

src/sentry/services/hybrid_cloud/organization/service.py

@@ -363,7 +363,9 @@ def schedule_signal(
 
     @regional_rpc_method(resolve=ByOrganizationId())
     @abstractmethod
-    def get_organization_owner_members(self, organization_id: int) -> List[RpcOrganizationMember]:
+    def get_organization_owner_members(
+        self, *, organization_id: int
+    ) -> List[RpcOrganizationMember]:
         pass
 
 

src/sentry/signals.py

@@ -122,7 +122,6 @@ def send_robust(self, sender, **named) -> List[Tuple[Receiver, Union[Exception,
 
 # Organization Onboarding Signals
 project_created = BetterSignal()  # ["project", "user", "user_id", "default_rules"]
-first_event_pending = BetterSignal()  # ["project", "user"]
 
 first_event_received = BetterSignal()  # ["project", "event"]
 # We use signal for consistency with other places but

src/sentry/web/frontend/react_page.py

@@ -10,9 +10,7 @@
 
 from sentry import features, options
 from sentry.api.utils import customer_domain_path, generate_organization_url
-from sentry.models.project import Project
 from sentry.services.hybrid_cloud.organization import organization_service
-from sentry.signals import first_event_pending
 from sentry.utils.http import is_using_customer_domain, query_string
 from sentry.web.frontend.base import BaseView, ControlSiloOrganizationView
 from sentry.web.helpers import render_to_response
@@ -121,11 +119,6 @@ def handle_auth_required(self, request: Request, *args, **kwargs) -> HttpRespons
         return super().handle_auth_required(request, *args, **kwargs)
 
     def handle(self, request: Request, organization, **kwargs) -> HttpResponse:
-        if "project_id" in kwargs and request.GET.get("onboarding"):
-            project = Project.objects.filter(
-                organization=organization, slug=kwargs["project_id"]
-            ).first()
-            first_event_pending.send(project=project, user=request.user, sender=self)
         request.organization = organization
         return self.handle_react(request)
 

tests/sentry/receivers/test_onboarding.py

@@ -18,7 +18,6 @@
 from sentry.signals import (
     alert_rule_created,
     event_processed,
-    first_event_pending,
     first_event_received,
     first_replay_received,
     first_transaction_received,
@@ -63,30 +62,6 @@ def test_no_existing_task(self):
         assert task.project_id == project.id
         assert task.date_completed == project.first_event
 
-    def test_existing_pending_task(self):
-        now = django_timezone.now()
-        project = self.create_project(first_event=now)
-
-        first_event_pending.send(project=project, user=self.user, sender=type(project))
-
-        task = OrganizationOnboardingTask.objects.get(
-            organization=project.organization, task=OnboardingTask.FIRST_EVENT
-        )
-
-        assert task.status == OnboardingTaskStatus.PENDING
-        assert task.project_id == project.id
-
-        event = self.store_event(data={}, project_id=project.id)
-        first_event_received.send(project=project, event=event, sender=type(project))
-
-        task = OrganizationOnboardingTask.objects.get(
-            organization=project.organization, task=OnboardingTask.FIRST_EVENT
-        )
-
-        assert task.status == OnboardingTaskStatus.COMPLETE
-        assert task.project_id == project.id
-        assert task.date_completed == project.first_event
-
     def test_existing_complete_task(self):
         now = django_timezone.now()
         project = self.create_project(first_event=now)
@@ -172,18 +147,6 @@ def test_project_created(self):
         )
         assert task is not None
 
-    def test_first_event_pending(self):
-        now = django_timezone.now()
-        project = self.create_project(first_event=now)
-        first_event_pending.send(project=project, user=self.user, sender=type(project))
-
-        task = OrganizationOnboardingTask.objects.get(
-            organization=project.organization,
-            task=OnboardingTask.FIRST_EVENT,
-            status=OnboardingTaskStatus.PENDING,
-        )
-        assert task is not None
-
     def test_first_event_received(self):
         now = django_timezone.now()
         project = self.create_project(first_event=now)