feat(billing): force global-views flag into PlanFeatures (#97148)

cvxluo · web-flow · commit a9043737ea8a · 2025-08-12T10:24:02.000-07:00
`PlanFeatures` takes a list of features and determines what plan has every one of those features. This is used in `powerFeatureHovercard`, which for a given feature, it shows a hovercard that says "Requires x plan", where x is the plan name from `PlanFeatures`. We wanted to move `global-views` to flagpole controlled, rather than getsentry (see getsentry/getsentry#17944), but since `PlanFeatures` reads from getsentry to determine what plan name to show, we ran into an issue where the plan name showed as 'unavailable' instead of 'business' (see #96947) To move `global-views` to flagpole controlled without having the hovercard break, we need `PlanFeatures` to know that `global-views` is a business feature. This _temporarily_ hard codes the feature into every business plan that `PlanFeatures` retrieves, so that we can safely remove the flag from getsentry. The motivation to have the flag in flagpole is so [this product change](https://sentry.slack.com/archives/C01N4L6SPT2/p1754414626890039) can be rolled out via the automator.
diff --git a/static/gsApp/components/features/planFeature.spec.tsx b/static/gsApp/components/features/planFeature.spec.tsx
@@ -170,4 +170,44 @@ describe('PlanFeature', function () {
       });
     });
   });
+
+  it('returns global-views in business plan even if response does not include it', async function () {
+    const mockFn = jest.fn(() => null);
+
+    const sub = SubscriptionFixture({organization, planTier: PlanTier.MM2});
+    SubscriptionStore.set(organization.slug, sub);
+
+    render(
+      <PlanFeature organization={organization} features={['global-views']}>
+        {mockFn}
+      </PlanFeature>
+    );
+
+    await waitFor(() => {
+      expect(mockFn).toHaveBeenCalledWith({
+        plan: PlanDetailsLookupFixture('am2_business'),
+        tierChange: 'am2',
+      });
+    });
+  });
+
+  it('returns business plan with other features including global-views', async function () {
+    const mockFn = jest.fn(() => null);
+
+    const sub = SubscriptionFixture({organization, planTier: PlanTier.MM2});
+    SubscriptionStore.set(organization.slug, sub);
+
+    render(
+      <PlanFeature organization={organization} features={['global-views', 'sso-basic']}>
+        {mockFn}
+      </PlanFeature>
+    );
+
+    await waitFor(() => {
+      expect(mockFn).toHaveBeenCalledWith({
+        plan: PlanDetailsLookupFixture('am2_business'),
+        tierChange: 'am2',
+      });
+    });
+  });
 });
diff --git a/static/gsApp/components/features/planFeature.tsx b/static/gsApp/components/features/planFeature.tsx
@@ -6,7 +6,11 @@ import {descopeFeatureName} from 'sentry/utils';
 import withSubscription from 'getsentry/components/withSubscription';
 import {useBillingConfig} from 'getsentry/hooks/useBillingConfig';
 import type {Plan, Subscription} from 'getsentry/types';
-import {isBizPlanFamily, isDeveloperPlan} from 'getsentry/utils/billing';
+import {
+  isAmEnterprisePlan,
+  isBizPlanFamily,
+  isDeveloperPlan,
+} from 'getsentry/utils/billing';
 
 type RenderProps = {
   /**
@@ -105,6 +109,18 @@ function PlanFeature({subscription, features, organization, children}: Props) {
     plans = billingConfig.planList;
   }
 
+  // HACK: we want to remove `global-views` from getsentry and move it to flagpole,
+  // but since PlanFeature hooks into getsentry to determine which plan
+  // `global-views` is in, we need to hardcode it into the plans here
+  // TODO: remove this
+  for (const plan of plans) {
+    if (isBizPlanFamily(plan) || isAmEnterprisePlan(plan.id)) {
+      if (!plan.features.includes('global-views')) {
+        plan.features.push('global-views');
+      }
+    }
+  }
+
   // Locate the first plan that offers these features
   const requiredPlan = plans.find(plan =>
     features.map(descopeFeatureName).every(f => plan.features.includes(f))
diff --git a/tests/js/getsentry-test/fixtures/am1Plans.ts b/tests/js/getsentry-test/fixtures/am1Plans.ts
@@ -83,7 +83,6 @@ const AM1_BUSINESS_FEATURES = [
   'data-forwarding',
   'discard-groups',
   'discover-query',
-  'global-views',
   'integrations-codeowners',
   'integrations-enterprise-alert-rule',
   'integrations-enterprise-incident-management',
diff --git a/tests/js/getsentry-test/fixtures/am2Plans.ts b/tests/js/getsentry-test/fixtures/am2Plans.ts
@@ -94,7 +94,6 @@ const AM2_BUSINESS_FEATURES = [
   'data-forwarding',
   'discard-groups',
   'discover-query',
-  'global-views',
   'integrations-codeowners',
   'integrations-enterprise-alert-rule',
   'integrations-enterprise-incident-management',
diff --git a/tests/js/getsentry-test/fixtures/am3Plans.ts b/tests/js/getsentry-test/fixtures/am3Plans.ts
@@ -115,7 +115,6 @@ const AM3_BUSINESS_FEATURES = [
   'data-forwarding',
   'discard-groups',
   'discover-query',
-  'global-views',
   'indexed-spans-extraction',
   'insights-initial-modules',
   'insights-addon-modules',
diff --git a/tests/js/getsentry-test/fixtures/featureList.ts b/tests/js/getsentry-test/fixtures/featureList.ts
@@ -74,10 +74,6 @@ export function FeatureListFixture(): Record<string, Feature> {
       name: 'Discover Query Builder',
       description: 'Build and save custom queries using Discover.',
     },
-    'global-views': {
-      name: 'Cross project visibility',
-      description: 'View data across all projects in your organization.',
-    },
     invoices: {
       name: 'Invoicing',
       description: 'Standard invoicing for your accounting department.',
diff --git a/tests/js/getsentry-test/fixtures/mm2Plans.ts b/tests/js/getsentry-test/fixtures/mm2Plans.ts
@@ -57,7 +57,6 @@ const MM2_PLANS: Record<string, Plan> = {
       'custom-inbound-filters',
       'data-forwarding',
       'discover',
-      'global-views',
       'rate-limits',
       'sso-saml2',
       'integrations-event-hooks',
@@ -113,7 +112,6 @@ const MM2_PLANS: Record<string, Plan> = {
       'custom-inbound-filters',
       'data-forwarding',
       'discover',
-      'global-views',
       'rate-limits',
       'sso-saml2',
       'integrations-event-hooks',
@@ -169,7 +167,6 @@ const MM2_PLANS: Record<string, Plan> = {
       'custom-inbound-filters',
       'data-forwarding',
       'discover',
-      'global-views',
       'rate-limits',
       'sso-saml2',
       'integrations-event-hooks',
@@ -225,7 +222,6 @@ const MM2_PLANS: Record<string, Plan> = {
       'custom-inbound-filters',
       'data-forwarding',
       'discover',
-      'global-views',
       'rate-limits',
       'sso-saml2',
       'integrations-event-hooks',
@@ -281,7 +277,6 @@ const MM2_PLANS: Record<string, Plan> = {
       'custom-inbound-filters',
       'data-forwarding',
       'discover',
-      'global-views',
       'rate-limits',
       'sso-saml2',
       'integrations-event-hooks',
@@ -337,7 +332,6 @@ const MM2_PLANS: Record<string, Plan> = {
       'custom-inbound-filters',
       'data-forwarding',
       'discover',
-      'global-views',
       'rate-limits',
       'sso-saml2',
       'integrations-event-hooks',
@@ -685,7 +679,6 @@ const MM2_PLANS: Record<string, Plan> = {
       'discard-groups',
       'dashboards-basic',
       'discover-query',
-      'global-views',
       'integrations-codeowners',
       'integrations-event-hooks',
       'integrations-stacktrace-link',
