fix(issue-platform): Fix bug where searching by issue shortname in discover returns too many results (#47406)

We're not correctly filtering when we use a query like
`issue:<shortname>` for any issue platform issues in discover. This
fixes that to work with all new issue types in the future.

Once we've migrated perf issues over we'll need to remove the perf issue
case here as well.

Author: wedamija

src/sentry/search/events/datasets/discover.py

@@ -1602,10 +1602,10 @@ def _issue_filter_converter(self, search_filter: SearchFilter) -> Optional[Where
         value = to_list(search_filter.value.value)
         # `unknown` is a special value for when there is no issue associated with the event
         group_short_ids = [v for v in value if v and v != "unknown"]
-        error_group_filter_values = ["" for v in value if not v or v == "unknown"]
+        general_group_filter_values = ["" for v in value if not v or v == "unknown"]
         perf_group_filter_values = ["" for v in value if not v or v == "unknown"]
 
-        error_groups = []
+        general_groups = []
         performance_groups = []
 
         if group_short_ids and self.builder.params.organization is not None:
@@ -1618,26 +1618,26 @@ def _issue_filter_converter(self, search_filter: SearchFilter) -> Optional[Where
                 raise InvalidSearchQuery(f"Invalid value '{group_short_ids}' for 'issue:' filter")
             else:
                 for group in groups:
-                    if group.issue_category == GroupCategory.ERROR:
-                        error_groups.append(group.id)
-                    elif group.issue_category == GroupCategory.PERFORMANCE:
+                    if group.issue_category == GroupCategory.PERFORMANCE:
                         performance_groups.append(group.id)
-                error_groups = sorted(error_groups)
+                    else:
+                        general_groups.append(group.id)
+                general_groups = sorted(general_groups)
                 performance_groups = sorted(performance_groups)
 
-                error_group_filter_values.extend(error_groups)
+                general_group_filter_values.extend(general_groups)
                 perf_group_filter_values.extend(performance_groups)
 
         # TODO (udameli): if both groups present, return data for both
-        if error_group_filter_values:
+        if general_group_filter_values:
             return self.builder.convert_search_filter_to_condition(
                 SearchFilter(
                     SearchKey("issue.id"),
                     operator,
                     SearchValue(
-                        error_group_filter_values
+                        general_group_filter_values
                         if search_filter.is_in_filter
-                        else error_group_filter_values[0]
+                        else general_group_filter_values[0]
                     ),
                 )
             )

tests/snuba/api/endpoints/test_organization_events.py

@@ -625,20 +625,40 @@ def test_generic_issue_ids_filter(self):
             before_now(hours=1).replace(tzinfo=timezone.utc),
             user=user_data,
         )
+        event, _, group_info = self.store_search_issue(
+            self.project.id,
+            self.user.id,
+            [f"{ProfileFileIOGroupType.type_id}-group2"],
+            "prod",
+            before_now(hours=1).replace(tzinfo=timezone.utc),
+            user=user_data,
+        )
+
+        query = {
+            "field": ["title", "release", "environment", "user.display", "timestamp"],
+            "statsPeriod": "90d",
+            "query": f"issue.id:{group_info.group.id}",
+            "dataset": "issuePlatform",
+        }
+        with self.feature(["organizations:profiling"]):
+            response = self.do_request(query)
+        assert response.status_code == 200, response.content
+        assert len(response.data["data"]) == 1
+        assert response.data["data"][0]["title"] == group_info.group.title
+        assert response.data["data"][0]["environment"] == "prod"
+        assert response.data["data"][0]["user.display"] == user_data["email"]
+        assert response.data["data"][0]["timestamp"] == event.timestamp
 
         query = {
             "field": ["title", "release", "environment", "user.display", "timestamp"],
             "statsPeriod": "90d",
             "query": f"issue:{group_info.group.qualified_short_id}",
             "dataset": "issuePlatform",
         }
-        with self.feature(
-            [
-                "organizations:profiling",
-            ]
-        ):
+        with self.feature(["organizations:profiling"]):
             response = self.do_request(query)
         assert response.status_code == 200, response.content
+        assert len(response.data["data"]) == 1
         assert response.data["data"][0]["title"] == group_info.group.title
         assert response.data["data"][0]["environment"] == "prod"
         assert response.data["data"][0]["user.display"] == user_data["email"]