fix(dashboards): Release filter should apply conditions over base query (#71101)

When using OR filters, the previous application of filters would result
in incorrect results. A OR B AND C is not the same as (A OR B) AND C,
which is the proper way to apply the filter to the base query of a
widget.

Author: narsaynorath

static/app/components/modals/widgetViewerModal.spec.tsx

@@ -238,7 +238,7 @@ describe('Modals -> WidgetViewerModal', function () {
             query: expect.objectContaining({
               query:
                 // The release was injected into the discover query
-                'title:/organizations/:orgId/performance/summary/ release:"[email protected]" ',
+                '(title:/organizations/:orgId/performance/summary/) release:"[email protected]" ',
             }),
           })
         );

static/app/views/dashboards/detail.spec.tsx

@@ -453,7 +453,8 @@ describe('Dashboards > Detail', function () {
           '/organizations/org-slug/events-stats/',
           expect.objectContaining({
             query: expect.objectContaining({
-              query: 'event.type:transaction transaction:/api/cats release:"[email protected]" ',
+              query:
+                '(event.type:transaction transaction:/api/cats) release:"[email protected]" ',
             }),
           })
         )

static/app/views/dashboards/widgetCard/genericWidgetQueries.tsx

@@ -198,9 +198,13 @@ class GenericWidgetQueries<SeriesResponse, TableResponse> extends Component<
 
     const dashboardFilterConditions = dashboardFiltersToString(dashboardFilters);
     widget.queries.forEach(query => {
-      query.conditions =
-        query.conditions +
-        (dashboardFilterConditions === '' ? '' : ` ${dashboardFilterConditions}`);
+      if (dashboardFilterConditions) {
+        // If there is no base query, there's no need to add parens
+        if (query.conditions) {
+          query.conditions = `(${query.conditions})`;
+        }
+        query.conditions = query.conditions + ` ${dashboardFilterConditions}`;
+      }
     });
     return widget;
   }

static/app/views/dashboards/widgetCard/issueWidgetQueries.spec.tsx

@@ -142,7 +142,7 @@ describe('IssueWidgetQueries', function () {
       expect.objectContaining({
         data: expect.objectContaining({
           query:
-            'assigned_or_suggested:#visibility timesSeen:>100 release:["[email protected]","[email protected]"] ',
+            '(assigned_or_suggested:#visibility timesSeen:>100) release:["[email protected]","[email protected]"] ',
         }),
       })
     );

static/app/views/dashboards/widgetCard/widgetQueries.spec.tsx

@@ -142,7 +142,7 @@ describe('Dashboards > WidgetQueries', function () {
       '/organizations/org-slug/events-stats/',
       expect.objectContaining({
         query: expect.objectContaining({
-          query: 'event.type:error release:["[email protected]","[email protected]"] ',
+          query: '(event.type:error) release:["[email protected]","[email protected]"] ',
         }),
       })
     );
@@ -170,7 +170,7 @@ describe('Dashboards > WidgetQueries', function () {
       '/organizations/org-slug/events/',
       expect.objectContaining({
         query: expect.objectContaining({
-          query: 'event.type:error release:"[email protected]" ',
+          query: '(event.type:error) release:"[email protected]" ',
         }),
       })
     );