fix(py3): Various more iter -> list cohersions (#20205)

Co-authored-by: Burak Yigit Kaya <[email protected]>

Author: evanpurkhiser

src/sentry/api/serializers/models/rule.py

@@ -48,11 +48,11 @@ def serialize(self, obj, attrs, user):
             # as part of the rule editor
             "id": six.text_type(obj.id) if obj.id else None,
             "conditions": [
-                dict(o.items() + [("name", _generate_rule_label(obj.project, obj, o))])
+                dict(list(o.items()) + [("name", _generate_rule_label(obj.project, obj, o))])
                 for o in obj.data.get("conditions", [])
             ],
             "actions": [
-                dict(o.items() + [("name", _generate_rule_label(obj.project, obj, o))])
+                dict(list(o.items()) + [("name", _generate_rule_label(obj.project, obj, o))])
                 for o in obj.data.get("actions", [])
             ],
             "actionMatch": obj.data.get("action_match") or Rule.DEFAULT_CONDITION_MATCH,

src/sentry/tagstore/snuba/backend.py

@@ -543,7 +543,7 @@ def __get_release(self, project_id, group_id, first=True):
         if not result:
             return None
         else:
-            return result.keys()[0]
+            return list(result.keys())[0]
 
     def get_first_release(self, project_id, group_id):
         return self.__get_release(project_id, group_id, True)

tests/sentry/data_export/test_models.py

@@ -45,7 +45,7 @@ def test_status_property(self):
 
     def test_payload_property(self):
         assert isinstance(self.data_export.payload, dict)
-        keys = self.data_export.query_info.keys() + ["export_type"]
+        keys = list(self.data_export.query_info.keys()) + ["export_type"]
         assert sorted(self.data_export.payload.keys()) == sorted(keys)
 
     def test_file_name_property(self):

tests/snuba/tasks/test_unmerge.py

@@ -283,7 +283,7 @@ def create_message_event(template, parameters, environment, release, fingerprint
 
         with self.tasks():
             eventstream_state = eventstream.start_unmerge(
-                project.id, [events.keys()[0]], source.id, destination.id
+                project.id, [list(events.keys())[0]], source.id, destination.id
             )
             unmerge.delay(
                 project.id, source.id, destination.id, [events.keys()[0]], None, batch_size=5
@@ -320,7 +320,7 @@ def create_message_event(template, parameters, environment, release, fingerprint
 
         assert set(
             GroupHash.objects.filter(group_id=source.id).values_list("hash", flat=True)
-        ) == set([events.keys()[0], events.keys()[1]])
+        ) == set(itertools.islice(events.keys(), 2))
 
         assert set(
             GroupRelease.objects.filter(group_id=source.id).values_list(
@@ -347,7 +347,7 @@ def create_message_event(template, parameters, environment, release, fingerprint
 
         assert set(
             GroupHash.objects.filter(group_id=destination.id).values_list("hash", flat=True)
-        ) == set([events.keys()[2]])
+        ) == set(itertools.islice(events.keys(), 2, 3))
 
         assert set(
             GroupRelease.objects.filter(group_id=destination.id).values_list(

tests/snuba/tsdb/test_tsdb_backend.py

@@ -41,8 +41,8 @@ def has_shape(data, shape, allow_empty=False):
     if isinstance(data, dict):
         return (
             (allow_empty or len(data) > 0)
-            and all(has_shape(k, shape.keys()[0]) for k in data.keys())
-            and all(has_shape(v, shape.values()[0]) for v in data.values())
+            and all(has_shape(k, list(shape.keys())[0]) for k in data.keys())
+            and all(has_shape(v, list(shape.values())[0]) for v in data.values())
         )
     elif isinstance(data, list):
         return (allow_empty or len(data) > 0) and all(has_shape(v, shape[0]) for v in data)