Skip to content

Commit b2e9a60

Browse files
committed
From webpack, always set frame.in_app explicitly.
The client will always send a value for in_app, but in the case of webpack, we want to clobber it entirely. We cannot reasonable calculate this from the client when sourcemaps are involved.
1 parent 56e3ec2 commit b2e9a60

File tree

1 file changed

+7
-8
lines changed

1 file changed

+7
-8
lines changed

src/sentry/lang/javascript/processor.py

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -561,14 +561,13 @@ def expand_frames(self, frames):
561561
else:
562562
filename = filename.split('webpack:///', 1)[-1]
563563

564-
if frame.in_app is None:
565-
# As noted above, '~/' means they're coming from node_modules,
566-
# so these are not app dependencies
567-
if filename.startswith('~/'):
568-
frame.in_app = False
569-
# And conversely, local dependencies start with './'
570-
elif filename.startswith('./'):
571-
frame.in_app = True
564+
# As noted above, '~/' means they're coming from node_modules,
565+
# so these are not app dependencies
566+
if filename.startswith('~/'):
567+
frame.in_app = False
568+
# And conversely, local dependencies start with './'
569+
elif filename.startswith('./'):
570+
frame.in_app = True
572571

573572
# We want to explicitly generate a webpack module name
574573
frame.module = generate_module(filename)

0 commit comments

Comments
 (0)